Page MenuHomePhabricator
Create Task
Maniphest T350798

Write some tests for Codex interface
Open, Needs TriagePublic
Actions

Description

Anything non-trivial in the new interface would benefit from having test coverage. See HelpBanner.test.js for an example of how to write these tests. See also https://test-utils.vuejs.org/

Run tests with npx jest, which is also called by npm test during CI.

Details

SubjectRepoBranchLines +/-
Codex: test for CategoriesListmediawiki/extensions/FileImportermaster+57 -2
Codex: additional tests for CategoriesSectionmediawiki/extensions/FileImportermaster+26 -4
Codex: test for CategoriesSectionmediawiki/extensions/FileImportermaster+63 -1
Codex: Test for the FileTitle validationmediawiki/extensions/FileImportermaster+31 -1
First test for FileTitlemediawiki/extensions/FileImportermaster+22 -1
Customize query in gerrit

Related Objects
Search...

StatusSubtypeAssignedTask
 OpenNoneT347451 Codexify FileImporter
 OpenNoneT350798 Write some tests for Codex interface
 Resolvedlilients_WMDET350933 Codex: Split out the title edit component

Event Timeline

awight created this task.Nov 8 2023, 3:24 PM
awight updated the task description. (Show Details)Nov 9 2023, 7:49 AM
awight updated the task description. (Show Details)
gerritbot added a comment.Nov 20 2023, 2:45 PM

Change 975828 had a related patch set uploaded (by Svantje Lilienthal; author: Svantje Lilienthal):

[mediawiki/extensions/FileImporter@master] First test for FileTitle

https://gerrit.wikimedia.org/r/975828

gerritbot added a project: Patch-For-Review.Nov 20 2023, 2:45 PM
lilients_WMDE updated the task description. (Show Details)Nov 20 2023, 2:48 PM
lilients_WMDE updated the task description. (Show Details)
gerritbot added a comment.Nov 20 2023, 4:23 PM

Change 975828 merged by jenkins-bot:

[mediawiki/extensions/FileImporter@master] First test for FileTitle

https://gerrit.wikimedia.org/r/975828

ReleaseTaggerBot added a project: MW-1.42-notes (1.42.0-wmf.7; 2023-11-28).Nov 20 2023, 5:00 PM
Maintenance_bot removed a project: Patch-For-Review.Nov 20 2023, 5:10 PM
Tobi_WMDE_SW added a project: WMDE-TechWish-Sprint-2023-11-22.Nov 22 2023, 9:40 AM
MareikeHeuerWMDE updated the task description. (Show Details)Nov 23 2023, 3:27 PM
gerritbot added a comment.Nov 28 2023, 8:05 AM

Change 977988 had a related patch set uploaded (by WMDE-Fisch; author: WMDE-Fisch):

[mediawiki/extensions/FileImporter@master] Codex: Test for the FileTitle validation

https://gerrit.wikimedia.org/r/977988

gerritbot added a project: Patch-For-Review.Nov 28 2023, 8:05 AM
WMDE-Fisch updated the task description. (Show Details)Nov 28 2023, 8:07 AM
awight added a project: Epic.Nov 28 2023, 10:41 AM
awight moved this task from Sprint Backlog to Watching / Epic / Stalled on the WMDE-TechWish-Sprint-2023-11-22 board.
gerritbot added a comment.Nov 28 2023, 3:22 PM

Change 977988 merged by jenkins-bot:

[mediawiki/extensions/FileImporter@master] Codex: Test for the FileTitle validation

https://gerrit.wikimedia.org/r/977988

Maintenance_bot removed a project: Patch-For-Review.Nov 28 2023, 3:30 PM
ReleaseTaggerBot edited projects, added MW-1.42-notes (1.42.0-wmf.9; 2023-12-12); removed MW-1.42-notes (1.42.0-wmf.7; 2023-11-28).Nov 28 2023, 4:00 PM
MareikeHeuerWMDE updated the task description. (Show Details)Nov 29 2023, 1:07 PM
gerritbot added a comment.Dec 1 2023, 9:55 AM

Change 979301 had a related patch set uploaded (by Mareike Heuer; author: Mareike Heuer):

[mediawiki/extensions/FileImporter@master] Codex: test for CategoriesSection

https://gerrit.wikimedia.org/r/979301

gerritbot added a project: Patch-For-Review.Dec 1 2023, 9:55 AM
MareikeHeuerWMDE updated the task description. (Show Details)Dec 1 2023, 9:57 AM
MareikeHeuerWMDE updated the task description. (Show Details)Dec 1 2023, 10:55 AM
MareikeHeuerWMDE updated the task description. (Show Details)
MareikeHeuerWMDE updated the task description. (Show Details)
gerritbot added a comment.Dec 1 2023, 11:49 AM

Change 979301 merged by jenkins-bot:

[mediawiki/extensions/FileImporter@master] Codex: test for CategoriesSection

https://gerrit.wikimedia.org/r/979301

Maintenance_bot removed a project: Patch-For-Review.Dec 1 2023, 12:10 PM
thiemowmde updated the task description. (Show Details)Dec 6 2023, 12:29 PM
gerritbot added a comment.Dec 7 2023, 2:08 PM

Change 981335 had a related patch set uploaded (by Mareike Heuer; author: Mareike Heuer):

[mediawiki/extensions/FileImporter@master] Codex: test for CategoriesList

https://gerrit.wikimedia.org/r/981335

gerritbot added a project: Patch-For-Review.Dec 7 2023, 2:08 PM
gerritbot added a comment.Dec 7 2023, 3:03 PM

Change 981348 had a related patch set uploaded (by Mareike Heuer; author: Mareike Heuer):

[mediawiki/extensions/FileImporter@master] Codex: additional tests for CategoriesSection

https://gerrit.wikimedia.org/r/981348

thiemowmde closed subtask T350933: Codex: Split out the title edit component as Resolved.Dec 13 2023, 11:14 AM
gerritbot added a comment.Dec 18 2023, 9:44 AM

Change 981348 merged by jenkins-bot:

[mediawiki/extensions/FileImporter@master] Codex: additional tests for CategoriesSection

https://gerrit.wikimedia.org/r/981348

ReleaseTaggerBot edited projects, added MW-1.42-notes (1.42.0-wmf.10; 2023-12-19); removed MW-1.42-notes (1.42.0-wmf.9; 2023-12-12).Dec 18 2023, 10:00 AM
gerritbot added a comment.Jan 15 2024, 12:53 PM

Change 981335 merged by jenkins-bot:

[mediawiki/extensions/FileImporter@master] Codex: test for CategoriesList

https://gerrit.wikimedia.org/r/981335

ReleaseTaggerBot edited projects, added MW-1.42-notes (1.42.0-wmf.14; 2024-01-16); removed MW-1.42-notes (1.42.0-wmf.10; 2023-12-19).Jan 15 2024, 1:00 PM
WMDE-Fisch updated the task description. (Show Details)Jan 15 2024, 1:06 PM
Maintenance_bot removed a project: Patch-For-Review.Jan 15 2024, 1:30 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits