Page MenuHomePhabricator
Create Task
Maniphest T350615

Support ipv6 address or to bind to all (::)
Closed, ResolvedPublic
Actions

Description

It appears Poolcounter only supports using ipv4 addresses, at least using -l <ipv6 address> or -l :: doesn't work.

Details

SubjectRepoBranchLines +/-
PoolCounterConnectionManager: Add support for ipv6mediawiki/coreREL1_40+60 -3
PoolCounterConnectionManager: Add support for ipv6mediawiki/coreREL1_41+60 -3
PoolCounterConnectionManager: Add support for ipv6mediawiki/coremaster+65 -4
PoolCounterConnectionManager: Add support for ipv6mediawiki/coremaster+8 -4
PoolCounterConnectionManager: Add support for ipv6mediawiki/coreREL1_39+153 -0
PoolCounterConnectionManager: Add support for ipv6mediawiki/coreREL1_40+8 -4
PoolCounterConnectionManager: Add support for ipv6mediawiki/coreREL1_41+8 -4
Add support for ipv6mediawiki/services/poolcountermaster+41 -3
Customize query in gerrit

Related Objects
Search...

Event Timeline

Paladox created this task.Nov 6 2023, 6:38 PM
Restricted Application added a project: MediaWiki-Platform-Team. · View Herald TranscriptNov 6 2023, 6:38 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
gerritbot added a comment.Nov 9 2023, 4:02 PM

Change 971544 had a related patch set uploaded (by Paladox; author: Paladox):

[mediawiki/services/poolcounter@master] Add support for ipv6

https://gerrit.wikimedia.org/r/971544

gerritbot added a project: Patch-For-Review.Nov 9 2023, 4:02 PM
Hokwelum moved this task from Inbox, needs triage to Backlog: non-prioritized on the MediaWiki-Platform-Team board.Nov 13 2023, 4:26 PM
gerritbot added a comment.Nov 13 2023, 4:55 PM

Change 972724 had a related patch set uploaded (by Krinkle; author: Paladox):

[mediawiki/core@master] PoolCounterConnectionManager: Add support for ipv6

https://gerrit.wikimedia.org/r/972724

gerritbot added a comment.Nov 22 2023, 2:29 AM

Change 971544 merged by jenkins-bot:

[mediawiki/services/poolcounter@master] Add support for ipv6

https://gerrit.wikimedia.org/r/971544

gerritbot added a comment.Nov 22 2023, 2:48 AM

Change 972724 merged by jenkins-bot:

[mediawiki/core@master] PoolCounterConnectionManager: Add support for ipv6

https://gerrit.wikimedia.org/r/972724

ReleaseTaggerBot added a project: MW-1.42-notes (1.42.0-wmf.7; 2023-11-28).Nov 22 2023, 3:00 AM
Maintenance_bot removed a project: Patch-For-Review.Nov 22 2023, 3:10 AM
Paladox mentioned this in rMSPC1b75315b3230: Add support for ipv6.Nov 22 2023, 4:51 AM
Paladox closed this task as Resolved.Nov 22 2023, 6:11 AM
Paladox claimed this task.
gerritbot added a comment.Nov 22 2023, 6:11 AM

Change 976335 had a related patch set uploaded (by Paladox; author: Paladox):

[mediawiki/core@REL1_41] PoolCounterConnectionManager: Add support for ipv6

https://gerrit.wikimedia.org/r/976335

gerritbot added a project: Patch-For-Review.Nov 22 2023, 6:11 AM

Change 976336 had a related patch set uploaded (by Paladox; author: Paladox):

[mediawiki/core@REL1_40] PoolCounterConnectionManager: Add support for ipv6

https://gerrit.wikimedia.org/r/976336

gerritbot added a comment.Nov 22 2023, 11:10 PM

Change 976819 had a related patch set uploaded (by Reedy; author: Paladox):

[mediawiki/core@REL1_39] PoolCounterConnectionManager: Add support for ipv6

https://gerrit.wikimedia.org/r/976819

gerritbot added a comment.Nov 22 2023, 11:12 PM

Change 976819 abandoned by Reedy:

[mediawiki/core@REL1_39] PoolCounterConnectionManager: Add support for ipv6

Reason:

https://gerrit.wikimedia.org/r/976819

gerritbot added a comment.Nov 23 2023, 2:45 AM

Change 976335 merged by jenkins-bot:

[mediawiki/core@REL1_41] PoolCounterConnectionManager: Add support for ipv6

https://gerrit.wikimedia.org/r/976335

gerritbot added a comment.Nov 23 2023, 2:47 AM

Change 976336 merged by jenkins-bot:

[mediawiki/core@REL1_40] PoolCounterConnectionManager: Add support for ipv6

https://gerrit.wikimedia.org/r/976336

ReleaseTaggerBot added projects: MW-1.41-notes, MW-1.40-notes.Nov 23 2023, 3:00 AM
Maintenance_bot removed a project: Patch-For-Review.Nov 23 2023, 3:10 AM
hashar mentioned this in T352444: CirrusSearch generates a massive amount of "poolcounter-connection-error" messages.Nov 30 2023, 4:02 PM
hashar reopened this task as Open.Nov 30 2023, 4:05 PM
hashar subscribed.

Reopening since we are reverting the patch in master and production due to T352444. The code written does not support being passed an IPv4 and I guess it is missing unit tests.

Volans subscribed.Nov 30 2023, 4:24 PM

I've commented on https://gerrit.wikimedia.org/r/c/mediawiki/core/+/972724/4/includes/poolcounter/PoolCounterConnectionManager.php#84 what it looked like the possible issue with the patch.

Jdforrester-WMF subscribed.Nov 30 2023, 5:22 PM

The patch was already landed in REL1_40 and REL1_41; is a fix imminent, or should we back it out of those branches too?

• bd808 added subtasks: T352444: CirrusSearch generates a massive amount of "poolcounter-connection-error" messages, T351930: HTTP 504 connection timeout error accessing MW API on Beta cluster.Nov 30 2023, 5:22 PM
gerritbot added a comment.Nov 30 2023, 6:09 PM

Change 979082 had a related patch set uploaded (by Paladox; author: Paladox):

[mediawiki/core@master] PoolCounterConnectionManager: Add support for ipv6

https://gerrit.wikimedia.org/r/979082

gerritbot added a project: Patch-For-Review.Nov 30 2023, 6:09 PM
kostajh closed subtask T351930: HTTP 504 connection timeout error accessing MW API on Beta cluster as Resolved.Dec 1 2023, 7:12 AM
daniel reopened subtask T351930: HTTP 504 connection timeout error accessing MW API on Beta cluster as Open.Dec 4 2023, 11:48 AM
daniel closed subtask T351930: HTTP 504 connection timeout error accessing MW API on Beta cluster as Resolved.Dec 4 2023, 10:30 PM
gerritbot added a comment.Dec 13 2023, 3:36 PM

Change 979082 merged by jenkins-bot:

[mediawiki/core@master] PoolCounterConnectionManager: Add support for ipv6

https://gerrit.wikimedia.org/r/979082

gerritbot added a comment.Dec 13 2023, 3:37 PM

Change 982829 had a related patch set uploaded (by Jforrester; author: Paladox):

[mediawiki/core@REL1_41] PoolCounterConnectionManager: Add support for ipv6

https://gerrit.wikimedia.org/r/982829

gerritbot added a comment.Dec 13 2023, 3:53 PM

Change 982830 had a related patch set uploaded (by Jforrester; author: Paladox):

[mediawiki/core@REL1_40] PoolCounterConnectionManager: Add support for ipv6

https://gerrit.wikimedia.org/r/982830

ReleaseTaggerBot edited projects, added MW-1.42-notes (1.42.0-wmf.10; 2023-12-19); removed MW-1.42-notes (1.42.0-wmf.7; 2023-11-28).Dec 13 2023, 4:00 PM
gerritbot added a comment.Dec 13 2023, 4:25 PM

Change 982829 merged by jenkins-bot:

[mediawiki/core@REL1_41] PoolCounterConnectionManager: Add support for ipv6

https://gerrit.wikimedia.org/r/982829

Paladox closed this task as Resolved.Dec 13 2023, 4:26 PM
gerritbot added a comment.Dec 13 2023, 4:27 PM

Change 982830 merged by jenkins-bot:

[mediawiki/core@REL1_40] PoolCounterConnectionManager: Add support for ipv6

https://gerrit.wikimedia.org/r/982830

Maintenance_bot removed a project: Patch-For-Review.Dec 13 2023, 4:30 PM
Jdforrester-WMF added a comment.Dec 13 2023, 4:33 PM

Thank you for your work on this, @Paladox!

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits