Page MenuHomePhabricator
Create Task
Maniphest T349784

Add error type for invalid evaluation result
Closed, ResolvedPublic
Actions

Description

There are several places in the orchestrator where we check for an invalid Z22 / Evaluation result. We are currently using Z547 / Invalid format for this error condition, but Z547 wasn't really intended for this. We should have a new error type specifically for this error condition.

Possible names might be Invalid evaluation result (especially if it's only about the Z22 format) or Invalid function response (if it covers a broader range of sins).

Completion checklist

Details

SubjectRepoBranchLines +/-
wikifunctions: Switch Python evaluator to 2023-11-29-143341 (try 3)operations/deployment-chartsmaster+1 -1
wikifunctions: Switch JavaScript evaluator to 2023-11-29-143341operations/deployment-chartsmaster+1 -1
wikifunctions: Switch Python evaluator to 2023-11-29-143341operations/deployment-chartsmaster+1 -1
wikifunctions: Switch orchestrator to 2023-11-17-200241operations/deployment-chartsmaster+1 -1
wikifunctions: Switch JavaScript evaluator to 2023-11-22-195017operations/deployment-chartsmaster+1 -1
wikifunctions: Bump evaluators to 2023-11-20-171133operations/deployment-chartsmaster+2 -2
Update function-schemata sub-module to HEAD (17c4936)mediawiki/extensions/WikiLambdamaster+1 -1
Customize query in gerrit

Related Objects
Search...

Event Timeline

DMartin-WMF created this task.Oct 26 2023, 1:12 AM
DMartin-WMF renamed this task from function-schemata: add error type for invalid evaluation result to Add error type for invalid evaluation result.Oct 26 2023, 1:14 AM
DMartin-WMF added a parent task: T349785: Use error type for invalid evaluation result.Oct 26 2023, 1:18 AM
Jdforrester-WMF triaged this task as Medium priority.Oct 26 2023, 4:43 PM
Jdforrester-WMF moved this task from To triage to Backlog on the Abstract Wikipedia team board.
CodeReviewBot added a project: Patch-For-Review.Nov 7 2023, 3:00 AM

dmartin opened https://gitlab.wikimedia.org/repos/abstract-wiki/wikifunctions/function-schemata/-/merge_requests/53

Add error type for invalid evaluation result

CodeReviewBot added a comment.Nov 7 2023, 2:20 PM

jforrester merged https://gitlab.wikimedia.org/repos/abstract-wiki/wikifunctions/function-schemata/-/merge_requests/53

Add error type for invalid evaluation result

Maintenance_bot removed a project: Patch-For-Review.Nov 7 2023, 2:30 PM
DMartin-WMF closed this task as Resolved.Nov 7 2023, 4:33 PM
DMartin-WMF claimed this task.
DMartin-WMF reopened this task as Open.Nov 7 2023, 4:36 PM

Reopening until the new error type has been used in the orchestrator.

DMartin-WMF renamed this task from Add error type for invalid evaluation result to Add error type for invalid evaluation result, and use in the orchestrator.Nov 7 2023, 4:37 PM
DMartin-WMF added a project: function-orchestrator.
DMartin-WMF renamed this task from Add error type for invalid evaluation result, and use in the orchestrator to Add error type for invalid evaluation result.Nov 7 2023, 5:04 PM
DMartin-WMF closed this task as Resolved.

Oops - now re-closing. We already have a ticket for using the new error type: T349785

gerritbot added a comment.Nov 14 2023, 7:08 PM

Change 974256 had a related patch set uploaded (by David Martin; author: David Martin):

[mediawiki/extensions/WikiLambda@master] Update function-schemata sub-module to HEAD (17c4936)

https://gerrit.wikimedia.org/r/974256

gerritbot added a project: Patch-For-Review.Nov 14 2023, 7:08 PM
gerritbot added a comment.Nov 14 2023, 7:27 PM

Change 974256 merged by jenkins-bot:

[mediawiki/extensions/WikiLambda@master] Update function-schemata sub-module to HEAD (17c4936)

https://gerrit.wikimedia.org/r/974256

Maintenance_bot removed a project: Patch-For-Review.Nov 14 2023, 7:30 PM
Jdforrester-WMF reopened this task as Open.Nov 14 2023, 8:38 PM
Jdforrester-WMF moved this task from Backlog to To deploy on the Abstract Wikipedia team board.
Jdforrester-WMF subscribed.

This will need manual creation in production following https://wikitech.wikimedia.org/wiki/Wikifunctions/Runbook#Add_a_new_pre-defined_Object_in_production once this version (wmf.7) is live in production.

DMartin-WMF mentioned this in T287919: Audit ad Hoc Error Types in Orchestrator.Nov 16 2023, 5:59 AM
Jdforrester-WMF changed the task status from Open to In Progress.Nov 16 2023, 5:24 PM
gerritbot added a comment.Nov 20 2023, 5:28 PM

Change 975867 had a related patch set uploaded (by Jforrester; author: Jforrester):

[operations/deployment-charts@master] wikifunctions: Bump evaluators to 2023-11-20-171133

https://gerrit.wikimedia.org/r/975867

gerritbot added a project: Patch-For-Review.Nov 20 2023, 5:28 PM
gerritbot added a comment.Nov 20 2023, 5:36 PM

Change 975867 merged by jenkins-bot:

[operations/deployment-charts@master] wikifunctions: Bump evaluators to 2023-11-20-171133

https://gerrit.wikimedia.org/r/975867

Maintenance_bot removed a project: Patch-For-Review.Nov 20 2023, 6:11 PM
gerritbot added a comment.Nov 22 2023, 8:10 PM

Change 976846 had a related patch set uploaded (by Jforrester; author: Jforrester):

[operations/deployment-charts@master] wikifunctions: Switch JavaScript evaluator to 2023-11-22-195017

https://gerrit.wikimedia.org/r/976846

gerritbot added a project: Patch-For-Review.Nov 22 2023, 8:10 PM

Change 976847 had a related patch set uploaded (by Jforrester; author: Jforrester):

[operations/deployment-charts@master] wikifunctions: Switch Python evaluator to 2023-11-22-195017

https://gerrit.wikimedia.org/r/976847

gerritbot added a comment.Nov 22 2023, 8:11 PM

Change 976848 had a related patch set uploaded (by Jforrester; author: Jforrester):

[operations/deployment-charts@master] wikifunctions: Switch orchestrator to 2023-11-17-200241

https://gerrit.wikimedia.org/r/976848

gerritbot added a comment.Nov 27 2023, 2:37 PM

Change 976846 merged by jenkins-bot:

[operations/deployment-charts@master] wikifunctions: Switch JavaScript evaluator to 2023-11-22-195017

https://gerrit.wikimedia.org/r/976846

gerritbot added a comment.Nov 29 2023, 4:50 PM

Change 976848 merged by jenkins-bot:

[operations/deployment-charts@master] wikifunctions: Switch orchestrator to 2023-11-17-200241

https://gerrit.wikimedia.org/r/976848

Jdforrester-WMF added a comment.Nov 29 2023, 4:57 PM

The code to use this is now live in the orchestrator, but the ZObject also needs to be manually created on wikifunctions.org via the script.

gerritbot added a comment.Nov 29 2023, 7:04 PM

Change 976847 merged by jenkins-bot:

[operations/deployment-charts@master] wikifunctions: Switch Python evaluator to 2023-11-29-143341

https://gerrit.wikimedia.org/r/976847

Maintenance_bot removed a project: Patch-For-Review.Nov 29 2023, 7:10 PM
gerritbot added a comment.Nov 29 2023, 7:18 PM

Change 978678 had a related patch set uploaded (by Jforrester; author: Jforrester):

[operations/deployment-charts@master] wikifunctions: Switch JavaScript evaluator to 2023-11-29-143341

https://gerrit.wikimedia.org/r/978678

gerritbot added a project: Patch-For-Review.Nov 29 2023, 7:18 PM
gerritbot added a comment.Nov 29 2023, 7:20 PM

Change 978678 merged by jenkins-bot:

[operations/deployment-charts@master] wikifunctions: Switch JavaScript evaluator to 2023-11-29-143341

https://gerrit.wikimedia.org/r/978678

Maintenance_bot removed a project: Patch-For-Review.Nov 29 2023, 7:30 PM
gerritbot added a comment.Nov 29 2023, 8:54 PM

Change 978514 had a related patch set uploaded (by Jforrester; author: Jforrester):

[operations/deployment-charts@master] wikifunctions: Switch Python evaluator to 2023-11-29-143341 (try 3)

https://gerrit.wikimedia.org/r/978514

gerritbot added a project: Patch-For-Review.Nov 29 2023, 8:54 PM
gerritbot added a comment.Nov 29 2023, 8:57 PM

Change 978514 merged by jenkins-bot:

[operations/deployment-charts@master] wikifunctions: Switch Python evaluator to 2023-11-29-143341 (try 3)

https://gerrit.wikimedia.org/r/978514

Maintenance_bot removed a project: Patch-For-Review.Nov 29 2023, 9:11 PM
Jdforrester-WMF closed this task as Resolved.Dec 4 2023, 7:12 PM
Jdforrester-WMF moved this task from To deploy to Verify in production on the Abstract Wikipedia team board.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits