Page MenuHomePhabricator

Revise the license flow for 3D files in the upload wizard
Closed, ResolvedPublic

Description

Background
When one uploads a 3D file on Commons they have to agree to patent license terms before proceeding. Currently one of the terms is shown on the main page which is being updated to new designs as documented in T347596. The proposed changes in the own work form/flow do not leave a logical place for showing a 3D patent license. Also some of the other patent related terms are listed in the dialog that appears when the user proceeds. By moving the patent terms from the main page to this dialog it will keep all the related content together without disrupting the new proposals.

Link to UI

Acceptance criteria

  • Remove the patent license grant statement from the main page of own work flow
  • Add the new copy (second statement under the Patent License section) to the dialog that shows up when one proceeds to next step.
  • Update the copy under the warranty header as shown in the UI.
  • The next button on the dialog is enabled after the user agrees to the terms by clicking on the checkbox (existing behaviour)

Note: This should not change any content on the patent dialog that shows up for "someone else's work"

Yet to be fixed

  • Match line spacing with the wireframes. Currently it is too tight as pointed out in this comment.

Event Timeline

@Sneha Where should "Legal code" (below the new "I grant a permanent patent license...") link to?

@Sneha Where should "Legal code" (below the new "I grant a permanent patent license...") link to?

Nevermind, I assume that's https://foundation.wikimedia.org/wiki/Wikimedia_3D_file_patent_license

All the links remain the same as we have today hence did not add details. In the old design with a statement there was a legal code link we could use the same.

Change 975005 had a related patch set uploaded (by Matthias Mullie; author: Matthias Mullie):

[mediawiki/extensions/UploadWizard@master] Redesign the license flow for 3D files

https://gerrit.wikimedia.org/r/975005

Change 975005 merged by jenkins-bot:

[mediawiki/extensions/UploadWizard@master] Redesign the license flow for 3D files

https://gerrit.wikimedia.org/r/975005

Etonkovidova subscribed.

Checked in commons beta. Note: link to figma in the task description didn't work for me - this one worked figma link to Patent rights release popup

To @Sneha for review - all functionality is in place - no issues are found. Please review the following issues.

(1)Own work - the line spacing is consistent with what's in production. It looks tight and it's different from the mockup.

mockupbetalabscommons wmf.5 (current production)
Screen Shot 2023-11-22 at 5.35.00 PM.png (1×2 px, 323 KB)
Screen Shot 2023-11-22 at 5.45.35 PM.png (1×2 px, 496 KB)
Screen Shot 2023-11-22 at 5.46.13 PM.png (1×2 px, 360 KB)

(2) Not own work - the same issue about line spacing as in (1).

mockupbetalabscommons wmf.5 (current production)
Screen Shot 2023-11-22 at 5.35.34 PM.png (1×2 px, 347 KB)
The text is different from mockup and production
Screen Shot 2023-11-22 at 5.55.07 PM.png (1×2 px, 246 KB)
Screen Shot 2023-11-22 at 5.54.35 PM.png (1×2 px, 263 KB)

@Etonkovidova I am not able to view the images for "Own work" it simply shows the file name for me instead of the image.

For "Not own work" the slight change in text is intentional. That specific copy was changed in own work so should be the same in not own work too. It seems I had forgotten to update in wireframes but I just updated it. So what you are seeing in betalabs is all good.

@Etonkovidova I am not able to view the images for "Own work" it simply shows the file name for me instead of the image.

Yes, sorry - the files were not "attached" - fixed that.

For "Not own work" the slight change in text is intentional. That specific copy was changed in own work so should be the same in not own work too. It seems I had forgotten to update in wireframes but I just updated it. So what you are seeing in betalabs is all good.

Thanks, I was just double-checking.
I'm moving the task to Verify on Production column. Even if we decide to follow-up on (1)Own work - the line spacing [...] - it's outside of the scope of this task.

Thanks. Looks good to me except the line spacing as you pointed out. I will add that to the description here so it is not lost and we can fix it in next iteration. It seems minor. Until then lets leave the ticket open.

Change 977691 had a related patch set uploaded (by Matthias Mullie; author: Matthias Mullie):

[mediawiki/extensions/UploadWizard@master] Increase line spacing in patent dialog

https://gerrit.wikimedia.org/r/977691

Change 977691 merged by jenkins-bot:

[mediawiki/extensions/UploadWizard@master] Increase line spacing in patent dialog

https://gerrit.wikimedia.org/r/977691

mfossati subscribed.

Directly moving to verify on production: we agreed with @Etonkovidova that the latest patch is tiny enough.

Line spacing is fixed - checked in commons betalabs:

Screen Shot 2023-11-28 at 5.42.31 PM.png (1×1 px, 104 KB)
Screen Shot 2023-11-28 at 5.43.00 PM.png (1×1 px, 192 KB)

Checked in commons wmf.9:

Own work
Screen Shot 2023-12-13 at 2.09.49 PM.png (1×2 px, 388 KB)
not Own work
Screen Shot 2023-12-13 at 2.12.35 PM.png (1×1 px, 151 KB)