We are patching wdio-mediawiki's LoginPage, because we have found that the current implementation does not consistently work. In specific, it fails to await the appearance of the username input element, password input element, login button element before attempting to set values to the input elements and click to login. We must discover:
To whom and how to report this bug so that it can be fixed If it is presently working for wdio-mediawiki, and if so, how
Acceptance Criteria:
A bug report, Phabricator ticket, and/or pull request is submitted for the wdio-mediawiki LoginPage code Information on how to do that is added to some knowledge sharing page for our team, perhaps a relevant wiki
Technical Guidance:
The erroneous code may be found here: https://gerrit.wikimedia.org/r/plugins/gitiles/mediawiki/core/+/refs/heads/wmf/1.40.0-wmf.24/tests/selenium/wdio-mediawiki/LoginPage.js The patch we're proposing can be found here: https://github.com/wmde/wikibase-release-pipeline/blob/T343430-wdio-async/test/helpers/pages/SuiteLoginPage.js
During implementation of T346030, patched wdio-mediawiki code:
- test/helpers/SuiteLoginPage.js patched wdio-mediawiki/LoginPage
- test/helpers/PagePatch.js patched wdio-mediawiki/Page
- test/helpers/MediawikiScreenshotPatch.js patched screenshot-related functions in wdio-mediawiki/index.js
As part of this work first evaluate whether we should rely on this MediaWiki WDIO library at all: If not, then this task can become simply better organising our "patches" to be named to be our own library code, and remove the wdio-mediawiki npm dependency. We want to stick with wdio-mediawiki for now.