Page MenuHomePhabricator

Update requireLogin() for temp users on TranslationNotifications extension
Closed, ResolvedPublic1 Estimated Story Points

Description

In T344276, we want to make sure the SpecialPage::requireLogin() function is used in accordance with the introduction of temporary users. As for now, we want to treat temporary users just like anonymous or IP users.

Request:
Should requireLogin() be available to temporary users?
If yes, no update is needed.
If not, requireNamedUser must return true instead.

Notes:
RequireLogin was found in the following files:
includes/SpecialTranslatorSignup.php
Code Search Link

Event Timeline

It might be helpful to keep this special page available to temporary users, to encourage them to translate.

Temporary users do not have access to email or preferences, but they could receive notifications via their talk page. It would be nice not to show the message about setting their email in their preferences:

image.png (915×1 px, 99 KB)

Nikerabbit set the point value for this task to 1.
Nikerabbit subscribed.

This page uses user preferences to store the preferences, so we need to limit it to named users.

Change 977690 had a related patch set uploaded (by Abijeet Patro; author: Abijeet Patro):

[mediawiki/extensions/TranslationNotifications@master] SpecialTranslatorSignup: Require named user

https://gerrit.wikimedia.org/r/977690

abi_ changed the task status from Open to In Progress.Nov 27 2023, 2:56 PM
abi_ claimed this task.

Change 977690 merged by jenkins-bot:

[mediawiki/extensions/TranslationNotifications@master] SpecialTranslatorSignup: Require named user

https://gerrit.wikimedia.org/r/977690

This is now deployed on MediaWiki.org, and I've not noticed any issues.