"Show IP" button not shown on Special:Block if form has username pre-filled
Closed, ResolvedPublicBUG REPORT
Actions

Assigned To

Authored By

	Dreamy_Jazz
	May 4 2023, 6:02 PM

Description

Steps to replicate the issue (include links if applicable):

Login into an account that can block users and has the temporary account IP viewer right
Load Special:Block/*Unregistered 1

What happens?:
"Show IP" button is not shown

What should have happened instead?:
The "Show IP" button should appear because the username field is pre-filled with a temporary user

Software version (skip for WMF-hosted wikis like Wikipedia):
CheckUser master branch on local wiki

Other information (browser name/version, screenshots, etc.):
Was fixed in T332136 but reintroduced by T334713 / https://gerrit.wikimedia.org/r/c/mediawiki/extensions/CheckUser/+/904602/

Found when testing patch for T335392, but issue is present without the associated patch applied (so unrelated to that change).

Example:

	Subject	Repo	Branch	Lines +/-
	Trigger onTargetChange when Special:Block loads	mediawiki/extensions/CheckUser	master	+1 -0

Status	Subtype	Assigned	Task
			Restricted Task
Resolved		kostajh	T294511 2021 Security Team wikireplicas audit
Declined		None	T284948 Raw IPs of logged-out users disclosed in wiki-replicas
In Progress		Niharika	T324492 Temporary accounts - MVP
Open		Niharika	T340001 [Epic] Deployment plan for Temporary Accounts
Resolved		Niharika	T348895 [Epic] Temporary accounts testwiki deployment
Resolved	Goal	Niharika	T300294 [Epic] Temporary account block workflow
Resolved		Func	T334713 Should Special:Block perform automatic lookups of IP addresses for temporary users?
Resolved	BUG REPORT	Dreamy_Jazz	T335996 "Show IP" button not shown on Special:Block if form has username pre-filled
Resolved		Dreamy_Jazz	T371116 Deploy temporary accounts to test2wiki
Resolved		kostajh	T378334 Temporary Accounts: Minor pilot - Oct 29 deploy
Resolved		Tchanders	T378336 Temporary Accounts: Minor pilots - Nov 5 deploy
Open		None	T379108 Enable temporary accounts on metawiki beta

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 4 2023, 6:02 PM

Could I suggest that a test be added to ensure the "Show IP" button appears if the form is pre-loaded?

Dreamy_Jazz updated the task description. (Show Details)

Change 915827 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/extensions/CheckUser@master] Trigger onTargetChange when page loads

Dreamy_Jazz triaged this task as Medium priority.

Change 915827 merged by jenkins-bot:

[mediawiki/extensions/CheckUser@master] Trigger onTargetChange when Special:Block loads

Patch merged. Should be okay to close this now. A better name for onTargetChanged is probably needed per the discussion in the task.