Description

Now that CheckUser writes to the new tables for event table migration (T330158), reading from these tables when the migration stage is set to read new can commence.

This task is to add support to read new in Special:CheckUser's 'Get IP addresses' mode.

Acceptance criteria

Alias the current query info fields in CheckUserGetIPsPager to prepare for migration
Add code to read from the two new tables when reading new in CheckUserGetIPsPager

QA Results - Local

AC	Status	Details
1	✅	https://phabricator.wikimedia.org/T328998 here

Details

Subject	Repo	Branch	Lines +/-
Implement read new support for CheckUserGetIPsPager	mediawiki/extensions/CheckUser	master	+929 -127
[WIP] Implement read new support for CheckUserGetIPsPager	mediawiki/extensions/CheckUser	master	+156 -45
Prepare CheckUserGetIPsPager for event table migration	mediawiki/extensions/CheckUser	master	+7 -7

Customize query in gerrit

Related Objects
Search...

View Standalone Graph

This task is connected to more than 200 other tasks. Only direct parents and subtasks are shown here. Use View Standalone Graph to show more of the graph.

Status	Assigned	Task
		· · ·
Resolved	Dreamy_Jazz	T328992 Add read new support to Special:CheckUser for event table migration
Resolved	Dreamy_Jazz	T328998 Enable read new support in Special:CheckUser's 'Get IP Addresses' mode
		· · ·

Event Timeline

Dreamy_Jazz created this task.Feb 7 2023, 12:56 AM

Restricted Application removed a project: Patch-For-Review. · View Herald TranscriptFeb 7 2023, 12:56 AM

Dreamy_Jazz updated the task description. (Show Details)Feb 7 2023, 12:57 AM

Dreamy_Jazz moved this task from Inbox to CheckUser on the CheckUser board.Feb 7 2023, 11:37 PM

Dreamy_Jazz triaged this task as Medium priority.Feb 8 2023, 11:57 PM

Change 884133 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/extensions/CheckUser@master] Prepare CheckUserGetIPsPager for event table migration

https://gerrit.wikimedia.org/r/884133

gerritbot added a project: Patch-For-Review.Apr 23 2023, 1:28 PM

Dreamy_Jazz updated the task description. (Show Details)Apr 23 2023, 1:28 PM

Change 884133 abandoned by Dreamy Jazz:

[mediawiki/extensions/CheckUser@master] Prepare CheckUserGetIPsPager for event table migration

Reason:

https://gerrit.wikimedia.org/r/884133

Dreamy_Jazz updated the task description. (Show Details)May 19 2023, 2:09 PM

Dreamy_Jazz updated the task description. (Show Details)May 20 2023, 9:38 AM

Dreamy_Jazz edited projects, added Anti-Harassment (AHaT Sprint 32 - Baseball Cap); removed Patch-For-Review.Jul 14 2023, 10:25 AM

Dreamy_Jazz moved this task from Ready 🎬 (ONLY IF YOU HAVE NO MORE CODE TO REVIEW) to In Progress 💪 on the Anti-Harassment (AHaT Sprint 32 - Baseball Cap) board.

Change 938229 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/extensions/CheckUser@master] Implement read new support for CheckUserGetIPsPager

https://gerrit.wikimedia.org/r/938229

gerritbot added a project: Patch-For-Review.Jul 14 2023, 12:20 PM

Moving out of the sprint as T328995: Enable read new support in Special:CheckUser's 'Get edits' mode will need to come first.

Dreamy_Jazz moved this task from Untriaged to Blocked/Stalled on the Anti-Harassment board.Jul 20 2023, 5:13 PM

Change 954948 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/extensions/CheckUser@master] [WIP] Implement read new support for CheckUserGetIPsPager

https://gerrit.wikimedia.org/r/954948

Change 938229 abandoned by Dreamy Jazz:

[mediawiki/extensions/CheckUser@master] [WIP] Implement read new support for CheckUserGetIPsPager

Reason:

https://gerrit.wikimedia.org/r/938229

Dreamy_Jazz renamed this task from Use the CheckUserUnionSelectQueryBuilder in Special:CheckUser's 'Get IP Addresses' mode to Enable read new support in Special:CheckUser's 'Get IP Addresses' mode.Sep 6 2023, 7:59 PM

Dreamy_Jazz updated the task description. (Show Details)

Dreamy_Jazz edited projects, added Anti-Harassment (AHaT Sprint 32 - Baseball Cap); removed Anti-Harassment.

Dreamy_Jazz mentioned this in T315612: Re-enable paging for the Get IPs results.Oct 22 2023, 2:56 PM

Dreamy_Jazz moved this task from In Progress 💪 to Code Review 🔍 on the Anti-Harassment (AHaT Sprint 32 - Baseball Cap) board.Oct 23 2023, 12:48 AM

Change 954948 merged by jenkins-bot:

[mediawiki/extensions/CheckUser@master] Implement read new support for CheckUserGetIPsPager

https://gerrit.wikimedia.org/r/954948

Dreamy_Jazz added a project: Trust and Safety Product Sprint (Sprint Shamisen (20th Nov - 1st Dec. 2023)).Nov 17 2023, 1:10 PM

Dreamy_Jazz moved this task from Code Review 🔍 to QA/Testing 🐞 on the Anti-Harassment (AHaT Sprint 32 - Baseball Cap) board.

Dreamy_Jazz moved this task from Priority Backlog to Needs QA on the Trust and Safety Product Sprint (Sprint Shamisen (20th Nov - 1st Dec. 2023)) board.Nov 20 2023, 4:23 PM

Dreamy_Jazz updated the task description. (Show Details)Nov 25 2023, 2:44 PM

Dreamy_Jazz removed a project: Patch-For-Review.

Dreamy_Jazz edited projects, added Trust and Safety Product Sprint (Sprint Lute (11th Dec. - 22nd Dec. 2023)); removed Trust and Safety Product Sprint (Sprint Shamisen (20th Nov - 1st Dec. 2023)).Dec 11 2023, 5:04 PM

Dreamy_Jazz moved this task from Priority Backlog to Needs QA on the Trust and Safety Product Sprint (Sprint Lute (11th Dec. - 22nd Dec. 2023)) board.

@Dreamy_Jazz Get IP address works as designed as seen in the screenshots. The task will be moved to Done. Thanks for all your work!

Status: ✅PASS
Environment: Local: 1.42.0-alpha (a7690c5)14:05, 12 December 2023
OS: macOS Sonoma 14.2
Browser: Chrome 120, Firefox 119, Safari 17.0
Skins. Vector 2022, 2010, Minerva, Monobook, Timeless
Device: MBA M2
Emulated Device:: n/a
Test Links:
http://localhost:8080/wiki/Special:CheckUser

✅AC1: https://phabricator.wikimedia.org/T328998

Different IPs	Get Edit XFF	Temp User	Hebrew	Minerva- different size

GMikesell-WMF updated the task description. (Show Details)Dec 13 2023, 1:11 AM

GMikesell-WMF moved this task from Needs QA to Done on the Trust and Safety Product Sprint (Sprint Lute (11th Dec. - 22nd Dec. 2023)) board.

Thanks for the QA! Marking this as resolved as these changes are now used on all wikis.

Enable read new support in Special:CheckUser's 'Get IP Addresses' modeClosed, ResolvedPublicActions