Page MenuHomePhabricator
Create Task
Maniphest T328601

TypeError: Argument 2 passed to Parser::parse() must implement interface MediaWiki\Page\PageReference, null given, called in /srv/mediawiki/php-1.40.0-wmf.21/extensions/Wikibase/lib/includes/Formatters/CachingKartographerEmbedd
Closed, ResolvedPublicPRODUCTION ERROR
Actions

Description

Error
normalized_message
[{reqId}] {exception_url}   TypeError: Argument 2 passed to Parser::parse() must implement interface MediaWiki\Page\PageReference, null given, called in /srv/mediawiki/php-1.40.0-wmf.21/extensions/Wikibase/lib/includes/Formatters/CachingKartographerEmbedd
exception.trace
from /srv/mediawiki/php-1.40.0-wmf.21/includes/parser/Parser.php(689)
#0 /srv/mediawiki/php-1.40.0-wmf.21/extensions/Wikibase/lib/includes/Formatters/CachingKartographerEmbeddingHandler.php(122): Parser->parse(string, NULL, ParserOptions)
#1 /srv/mediawiki/php-1.40.0-wmf.21/extensions/Wikibase/repo/includes/ParserOutput/GlobeCoordinateKartographerDataUpdater.php(75): Wikibase\Lib\Formatters\CachingKartographerEmbeddingHandler->getParserOutput(array, LanguageEn)
#2 /srv/mediawiki/php-1.40.0-wmf.21/extensions/Wikibase/repo/includes/ParserOutput/CompositeStatementDataUpdater.php(32): Wikibase\Repo\ParserOutput\GlobeCoordinateKartographerDataUpdater->updateParserOutput(ParserOutput)
#3 /srv/mediawiki/php-1.40.0-wmf.21/extensions/Wikibase/repo/includes/ParserOutput/ItemParserOutputUpdater.php(34): Wikibase\Repo\ParserOutput\CompositeStatementDataUpdater->updateParserOutput(ParserOutput)
#4 /srv/mediawiki/php-1.40.0-wmf.21/extensions/Wikibase/repo/includes/ParserOutput/ItemParserOutputUpdater.php(25): Wikibase\Repo\ParserOutput\ItemParserOutputUpdater->updateParserOutputForItem(ParserOutput, Wikibase\DataModel\Entity\Item)
#5 /srv/mediawiki/php-1.40.0-wmf.21/extensions/Wikibase/repo/includes/ParserOutput/EntityParserOutputDataUpdaterCollection.php(44): Wikibase\Repo\ParserOutput\ItemParserOutputUpdater->updateParserOutput(ParserOutput, Wikibase\DataModel\Entity\Item)
#6 /srv/mediawiki/php-1.40.0-wmf.21/extensions/Wikibase/repo/includes/ParserOutput/FullEntityParserOutputGenerator.php(105): Wikibase\Repo\ParserOutput\EntityParserOutputDataUpdaterCollection->updateParserOutput(Wikibase\DataModel\Entity\Item)
#7 /srv/mediawiki/php-1.40.0-wmf.21/extensions/Wikibase/repo/includes/ParserOutput/StatsdTimeRecordingEntityParserOutputGenerator.php(53): Wikibase\Repo\ParserOutput\FullEntityParserOutputGenerator->getParserOutput(Wikibase\Lib\Store\EntityRevision, boolean)
#8 /srv/mediawiki/php-1.40.0-wmf.21/extensions/Wikibase/repo/includes/Content/EntityHandler.php(859): Wikibase\Repo\ParserOutput\StatsdTimeRecordingEntityParserOutputGenerator->getParserOutput(Wikibase\Lib\Store\EntityRevision, boolean)
#9 /srv/mediawiki/php-1.40.0-wmf.21/extensions/Wikibase/repo/includes/Content/ItemHandler.php(305): Wikibase\Repo\Content\EntityHandler->getParserOutputFromEntityView(Wikibase\Repo\Content\ItemContent, integer, ParserOptions, boolean)
#10 /srv/mediawiki/php-1.40.0-wmf.21/extensions/Wikibase/repo/includes/Content/EntityHandler.php(794): Wikibase\Repo\Content\ItemHandler->getParserOutputFromEntityView(Wikibase\Repo\Content\ItemContent, integer, ParserOptions, boolean)
#11 /srv/mediawiki/php-1.40.0-wmf.21/includes/content/ContentHandler.php(1747): Wikibase\Repo\Content\EntityHandler->fillParserOutput(Wikibase\Repo\Content\ItemContent, MediaWiki\Content\Renderer\ContentParseParams, ParserOutput)
#12 /srv/mediawiki/php-1.40.0-wmf.21/includes/content/Renderer/ContentRenderer.php(47): ContentHandler->getParserOutput(Wikibase\Repo\Content\ItemContent, MediaWiki\Content\Renderer\ContentParseParams)
#13 /srv/mediawiki/php-1.40.0-wmf.21/includes/Revision/RenderedRevision.php(260): MediaWiki\Content\Renderer\ContentRenderer->getParserOutput(Wikibase\Repo\Content\ItemContent, Title, integer, ParserOptions, boolean)
#14 /srv/mediawiki/php-1.40.0-wmf.21/includes/Revision/RenderedRevision.php(232): MediaWiki\Revision\RenderedRevision->getSlotParserOutputUncached(Wikibase\Repo\Content\ItemContent, boolean)
#15 /srv/mediawiki/php-1.40.0-wmf.21/includes/Revision/RevisionRenderer.php(227): MediaWiki\Revision\RenderedRevision->getSlotParserOutput(string, array)
#16 /srv/mediawiki/php-1.40.0-wmf.21/includes/Revision/RevisionRenderer.php(164): MediaWiki\Revision\RevisionRenderer->combineSlotOutput(MediaWiki\Revision\RenderedRevision, array)
#17 [internal function]: MediaWiki\Revision\RevisionRenderer->MediaWiki\Revision\{closure}(MediaWiki\Revision\RenderedRevision, array)
#18 /srv/mediawiki/php-1.40.0-wmf.21/includes/Revision/RenderedRevision.php(199): call_user_func(Closure, MediaWiki\Revision\RenderedRevision, array)
#19 /srv/mediawiki/php-1.40.0-wmf.21/extensions/Wikibase/repo/includes/Content/EntityHandler.php(739): MediaWiki\Revision\RenderedRevision->getRevisionParserOutput(array)
#20 /srv/mediawiki/php-1.40.0-wmf.21/extensions/CirrusSearch/includes/BuildDocument/ParserOutputPageProperties.php(89): Wikibase\Repo\Content\EntityHandler->getParserOutputForIndexing(WikiPage, ParserCache, MediaWiki\Revision\RevisionStoreRecord)
#21 /srv/mediawiki/php-1.40.0-wmf.21/extensions/CirrusSearch/includes/BuildDocument/ParserOutputPageProperties.php(64): CirrusSearch\BuildDocument\ParserOutputPageProperties->finalizeReal(Elastica\Document, WikiPage, ParserCache, CirrusSearch\CirrusSearch, MediaWiki\Revision\RevisionStoreRecord)
#22 /srv/mediawiki/php-1.40.0-wmf.21/extensions/CirrusSearch/includes/BuildDocument/BuildDocument.php(202): CirrusSearch\BuildDocument\ParserOutputPageProperties->finalize(Elastica\Document, Title, MediaWiki\Revision\RevisionStoreRecord)
#23 /srv/mediawiki/php-1.40.0-wmf.21/extensions/CirrusSearch/includes/DataSender.php(272): CirrusSearch\BuildDocument\BuildDocument->finalize(Elastica\Document)
#24 /srv/mediawiki/php-1.40.0-wmf.21/extensions/CirrusSearch/includes/Job/ElasticaWrite.php(160): CirrusSearch\DataSender->sendData(string, array)
#25 /srv/mediawiki/php-1.40.0-wmf.21/extensions/CirrusSearch/includes/Job/JobTraits.php(138): CirrusSearch\Job\ElasticaWrite->doJob()
#26 /srv/mediawiki/php-1.40.0-wmf.21/extensions/CirrusSearch/includes/Updater.php(452): CirrusSearch\Job\CirrusGenericJob->run()
#27 /srv/mediawiki/php-1.40.0-wmf.21/extensions/CirrusSearch/includes/Updater.php(227): CirrusSearch\Updater->pushElasticaWriteJobs(array, Closure)
#28 /srv/mediawiki/php-1.40.0-wmf.21/extensions/CirrusSearch/includes/Updater.php(81): CirrusSearch\Updater->updatePages(array, integer)
#29 /srv/mediawiki/php-1.40.0-wmf.21/extensions/CirrusSearch/includes/Job/LinksUpdate.php(51): CirrusSearch\Updater->updateFromTitle(Title)
#30 /srv/mediawiki/php-1.40.0-wmf.21/extensions/CirrusSearch/includes/Job/JobTraits.php(138): CirrusSearch\Job\LinksUpdate->doJob()
#31 /srv/mediawiki/php-1.40.0-wmf.21/extensions/EventBus/includes/JobExecutor.php(79): CirrusSearch\Job\CirrusTitleJob->run()
#32 /srv/mediawiki/rpc/RunSingleJob.php(77): MediaWiki\Extension\EventBus\JobExecutor->execute(array)
#33 {main}
Impact

781 previously unseen errors in the last 20 minutes.

Notes

This error started appearing at a rate of 717 in 15 minutes while rolling the 1.40.0-wmf.21 train (T325584) to group1. I rolled group1 back to 1.40.0-wmf.20.

Details

MediaWiki Version
1.40.0-wmf.21
Request URL
https://jobrunner.discovery.wmnet/rpc/RunSingleJob.php
SubjectRepoBranchLines +/-
CachingKartographerEmbeddingHandler: Fall back to Special:BlankPage titlemediawiki/extensions/Wikibasewmf/1.40.0-wmf.21+3 -2
CachingKartographerEmbeddingHandler: Fall back to Special:BlankPage titlemediawiki/extensions/Wikibasemaster+3 -2
Customize query in gerrit

Related Objects
Search...

Event Timeline

dancy created this task.Feb 1 2023, 7:44 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 1 2023, 7:44 PM
dancy added a parent task: T325584: 1.40.0-wmf.21 deployment blockers.Feb 1 2023, 7:44 PM
Stashbot added a comment.Feb 1 2023, 7:53 PM

Mentioned in SAL (#wikimedia-operations) [2023-02-01T19:53:17Z] <dancy> The train is blocked on T328601

kostajh added projects: MediaWiki-extensions-WikibaseRepository, Maps (Kartographer).Feb 1 2023, 7:54 PM
Agusbou2015 subscribed.Feb 1 2023, 7:59 PM
Jdforrester-WMF triaged this task as Unbreak Now! priority.Feb 1 2023, 8:18 PM
Jdforrester-WMF subscribed.

Train blockers are UBN.

DLynch subscribed.Feb 1 2023, 8:24 PM

I'm immediately suspicious of https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Wikibase/+/803578/ (T309695) mostly because it was 5 days ago and is touching the precise argument that's erroring.

gerritbot added a comment.Feb 1 2023, 8:27 PM

Change 885875 had a related patch set uploaded (by Kosta Harlan; author: Kosta Harlan):

[mediawiki/extensions/Wikibase@master] CachingKartographerEmbeddingHandler: Fall back to Special:BlankPage title

https://gerrit.wikimedia.org/r/885875

gerritbot added a project: Patch-For-Review.Feb 1 2023, 8:27 PM
Umherirrender added subscribers: Lucas_Werkmeister_WMDE, thiemowmde, awight and 2 others.EditedFeb 1 2023, 8:27 PM

It is https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Wikibase/+/803578 (T309695)

The global context (RequestContext::getMain()->getTitle()) has no title on the job runners (here by CirrusSearch)

Maintenance_bot added a project: Wikidata.Feb 1 2023, 8:29 PM
Restricted Application added a project: [DEPRECATED] wdwb-tech. · View Herald TranscriptFeb 1 2023, 8:29 PM
Zabe subscribed.Feb 1 2023, 10:16 PM
gerritbot added a comment.Feb 1 2023, 10:33 PM

Change 885875 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] CachingKartographerEmbeddingHandler: Fall back to Special:BlankPage title

https://gerrit.wikimedia.org/r/885875

gerritbot added a comment.Feb 1 2023, 10:34 PM

Change 885781 had a related patch set uploaded (by Zabe; author: Kosta Harlan):

[mediawiki/extensions/Wikibase@wmf/1.40.0-wmf.21] CachingKartographerEmbeddingHandler: Fall back to Special:BlankPage title

https://gerrit.wikimedia.org/r/885781

gerritbot added a comment.Feb 1 2023, 10:52 PM

Change 885781 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@wmf/1.40.0-wmf.21] CachingKartographerEmbeddingHandler: Fall back to Special:BlankPage title

https://gerrit.wikimedia.org/r/885781

Stashbot added a comment.Feb 1 2023, 10:53 PM

Mentioned in SAL (#wikimedia-operations) [2023-02-01T22:53:30Z] <zabe@deploy1002> Started scap: Backport for [[gerrit:885781|CachingKartographerEmbeddingHandler: Fall back to Special:BlankPage title (T328601)]]

Stashbot added a comment.Feb 1 2023, 10:55 PM

Mentioned in SAL (#wikimedia-operations) [2023-02-01T22:55:25Z] <zabe@deploy1002> zabe: Backport for [[gerrit:885781|CachingKartographerEmbeddingHandler: Fall back to Special:BlankPage title (T328601)]] synced to the testservers: mwdebug1002.eqiad.wmnet, mwdebug2002.codfw.wmnet, mwdebug1001.eqiad.wmnet, mwdebug2001.codfw.wmnet

ReleaseTaggerBot added a project: MW-1.40-notes (1.40.0-wmf.22; 2023-02-06).Feb 1 2023, 11:00 PM
Stashbot added a comment.Feb 1 2023, 11:01 PM

Mentioned in SAL (#wikimedia-operations) [2023-02-01T23:01:16Z] <zabe@deploy1002> Finished scap: Backport for [[gerrit:885781|CachingKartographerEmbeddingHandler: Fall back to Special:BlankPage title (T328601)]] (duration: 07m 45s)

Zabe closed this task as Resolved.Feb 1 2023, 11:01 PM
Zabe assigned this task to kostajh.

should be fixed

dancy added a comment.Feb 1 2023, 11:21 PM

Thanks everyone for jumping on this! The train has been rolled forward to group1 and everything looks good.

Maintenance_bot removed a project: Patch-For-Review.Feb 1 2023, 11:30 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits