Page MenuHomePhabricator
Create Task
Maniphest T327324

Display all preferences sections and content in mobile preferences when the user has javascript disabled
Closed, ResolvedPublicBUG REPORT
Actions

Description

At the moment, navigating to Special:Preferences with javascript disabled displays a non-interactive main menu; no sections will open and no preferences can be changed.

We should support a no-js solution for users with javascript turned off which enables all settings to be changed.

User story
As a Wikipedia user with javascript disabled, I want to change my preferences, so that I can customise my editing experience.

Specs

TBD

Technical information

TBD

Testing and QA steps

  • Disable Javascript in your browser
  • Open MediaWiki from a mobile device / in a mobile-emulated window
  • Navigate to Special:Preferences
  • Test that all settings sections display and preferences can be modified

Acceptance criteria

  • In the MinervaNeue skin on desktop and mobile, preferences can be changed with Javascript disabled.

Details

SubjectRepoBranchLines +/-
Make mobile preferences work with noscriptmediawiki/coremaster+37 -15
Customize query in gerrit

Related Objects
Search...

Event Timeline

jsn.sherman created this task.Jan 18 2023, 6:30 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 18 2023, 6:30 PM
jsn.sherman added a parent task: T311708: Implement MVP for new mobile Preferences interface.Jan 18 2023, 6:30 PM
Samwalton9-WMF moved this task from Inbox to To be estimated on the Moderator-Tools-Team board.Jan 19 2023, 10:44 AM
Samwalton9-WMF subscribed.Jan 19 2023, 3:42 PM

We discussed today that we should definitely support no-js, and display all the sections/content in the case that the user isn't using Javascript.

One possible approach: Create the sections as visible, then hide them with js. Instead of the other way around.

@jsn.sherman is going to spend a little time investigating further to figure out the best approach.

Samwalton9-WMF renamed this task from Mobile Preferences silently breaks without JavaScript to Display all preferences sections and content in mobile preferences when the user has javascript disabled.Jan 19 2023, 3:54 PM
Samwalton9-WMF updated the task description. (Show Details)
Restricted Application added a subscriber: Masumrezarock100. · View Herald TranscriptJan 19 2023, 3:54 PM
gerritbot added a comment.Jan 19 2023, 4:45 PM

Change 881668 had a related patch set uploaded (by Jsn.sherman; author: Jsn.sherman):

[mediawiki/core@master] WIP make mobile preferences work with noscript

https://gerrit.wikimedia.org/r/881668

gerritbot added a project: Patch-For-Review.Jan 19 2023, 4:45 PM
PatchDemoBot added a comment.Jan 19 2023, 4:47 PM

Test wiki created on Patch demo by JSherman (WMF) using patch(es) linked to this task:
https://patchdemo.wmflabs.org/wikis/fe288d63db/w

jsn.sherman added a comment.Jan 19 2023, 4:52 PM

Making the stacked layout work without javascript is a pretty light lift; I already have a patch with a demo up and running. I believe this would be good to go after some more styling and regression checks.

Samwalton9-WMF added a comment.Jan 19 2023, 5:21 PM

For some reason the two user mute boxes right at the end have a loading bar that never finishes:

Screenshot 2023-01-19 at 17.20.59.png (778×684 px, 40 KB)

In desktop no-js they show as boxes with no additional loading bar

Screenshot 2023-01-19 at 17.21.11.png (1×1 px, 459 KB)

jsn.sherman added a comment.Jan 19 2023, 5:41 PM

Yes, that's part of the styling I was referring to. I stopped coding at the point where the form was working and navigable.

Samwalton9-WMF added a comment.Jan 19 2023, 5:42 PM

Gotcha! Great work getting something so functional so quickly!

Samwalton9-WMF moved this task from To be estimated to Kanban on the Moderator-Tools-Team board.Jan 20 2023, 2:26 PM
Samwalton9-WMF edited projects, added Moderator-Tools-Team (Kanban); removed Moderator-Tools-Team.
jsn.sherman claimed this task.Jan 23 2023, 2:13 PM
jsn.sherman moved this task from Ready to In Progress on the Moderator-Tools-Team (Kanban) board.
PatchDemoBot added a comment.Jan 23 2023, 3:46 PM

Test wiki created on Patch demo by JSherman (WMF) using patch(es) linked to this task:
https://patchdemo.wmflabs.org/wikis/3aeeb1ed77/w

jsn.sherman added a comment.Jan 23 2023, 3:48 PM

It looks like the nojs style for that widget was not available on mobile, which looks like an oversight to me. Fixed now:
https://patchdemo.wmflabs.org/wikis/3aeeb1ed77/w/index.php?title=Special:Preferences&mobileaction=toggle_view_mobile

jsn.sherman moved this task from In Progress to Eng review on the Moderator-Tools-Team (Kanban) board.Jan 23 2023, 3:49 PM
Samwalton9-WMF added a comment.Jan 24 2023, 11:33 AM

Tested browsing the interface and changing/saving some settings:

  • Desktop, javascript
  • Desktop, no javascript
  • Mobile, javascript
  • Mobile, no javascript

All interfaces functioned as intended.

Is it intentional that we lost the horizontal line separators between preferences in the no-js version? I see they're still there between sections, which makes sense, but aren't present between individual settings.

gerritbot added a comment.Feb 2 2023, 4:07 PM

Change 881668 merged by jenkins-bot:

[mediawiki/core@master] Make mobile preferences work with noscript

https://gerrit.wikimedia.org/r/881668

Maintenance_bot removed a project: Patch-For-Review.Feb 2 2023, 4:29 PM
Scardenasmolinar moved this task from Eng review to Done on the Moderator-Tools-Team (Kanban) board.Feb 2 2023, 4:43 PM
Scardenasmolinar subscribed.

Merged!

ReleaseTaggerBot added a project: MW-1.40-notes (1.40.0-wmf.22; 2023-02-06).Feb 2 2023, 5:00 PM
Samwalton9-WMF merged a task: T328790: Special:Preferences mobile should have a no-JS mode.Feb 3 2023, 4:48 PM
Samwalton9-WMF added a subscriber: Esanders.
Samwalton9-WMF closed this task as Resolved.Feb 14 2023, 5:20 PM
PatchDemoBot added a comment.Jun 30 2023, 2:08 PM

Test wiki on Patch demo by JSherman (WMF) using patch(es) linked to this task was deleted:

https://patchdemo.wmflabs.org/wikis/fe288d63db/w/

PatchDemoBot added a comment.Jun 30 2023, 2:09 PM

Test wiki on Patch demo by JSherman (WMF) using patch(es) linked to this task was deleted:

https://patchdemo.wmflabs.org/wikis/3aeeb1ed77/w/

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits