Maniphest T326996

CU should canonicalize IPv6 addresses
Closed, ResolvedPublicBUG REPORT
Actions

Assigned To

Authored By

	RoySmith
	Jan 14 2023, 3:16 AM

Tags

Referenced Files

None

Subscribers

Description

From a check I just did:

User logs 23:03:43 2600:387:f:919::c talk block check Failed to log in to Wikipedia as XXX
IP: 2600:387:F:919:0:0:0:C <UA elided>

In one place it's got "2600:387:f:919::c", in another "2600:387:F:919:0:0:0:C", which is actually the same address. They should be canonicalized to the same string (including upper/lower case). If nothing else, it confuses scripts which try to aggregate entries. See for example, https://checkuser.wikimedia.org/w/index.php?curid=9878

Details

	Subject	Repo	Branch	Lines +/-
	CheckUserGetEdits: normalise IPs in 'get edits' tab	mediawiki/extensions/CheckUser	master	+44 -5

Customize query in gerrit

Related Objects

Mentioned In: T46800: IPv6 data loaded from recentchanges table is in compact instead of full address format
T351945: Standardise IP display formatting
T306291: InconsistentTitleError when calling isRedirectPage on IPv6 anon user talk pages

Event Timeline

RoySmith created this task.Jan 14 2023, 3:16 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 14 2023, 3:16 AM

Reedy renamed this task from CU should canonicalize IP addresses to CU should canonicalize IPv6 addresses.Jan 15 2023, 2:24 AM

Reedy added a project: IPv6.

Dreamy_Jazz triaged this task as Low priority.Jan 15 2023, 11:18 AM

RoySmith mentioned this in T306291: InconsistentTitleError when calling isRedirectPage on IPv6 anon user talk pages.Feb 15 2023, 5:39 PM

Change 976349 had a related patch set uploaded (by DatGuy; author: DatGuy):

[mediawiki/extensions/CheckUser@master] CheckUserGetEdits: normalise IPs in 'get edits' tab

https://gerrit.wikimedia.org/r/976349

gerritbot added a project: Patch-For-Review.Nov 21 2023, 11:22 PM

DatGuy subscribed.Nov 21 2023, 11:23 PM

Dreamy_Jazz assigned this task to DatGuy.Nov 22 2023, 10:26 AM

Change 976349 merged by jenkins-bot:

[mediawiki/extensions/CheckUser@master] CheckUserGetEdits: normalise IPs in 'get edits' tab

https://gerrit.wikimedia.org/r/976349

Maintenance_bot removed a project: Patch-For-Review.Nov 22 2023, 6:30 PM

ReleaseTaggerBot added a project: MW-1.42-notes (1.42.0-wmf.7; 2023-11-28).Nov 22 2023, 7:00 PM

DatGuy mentioned this in T351945: Standardise IP display formatting.Nov 24 2023, 8:29 PM

DatGuy closed this task as Resolved.Dec 3 2023, 1:07 PM

Dreamy_Jazz mentioned this in T46800: IPv6 data loaded from recentchanges table is in compact instead of full address format.Jan 3 2024, 10:55 AM