Page MenuHomePhabricator
Create Task
Maniphest T326681

axe-core 4.6 makes new-lexeme-special-page a11y tests fail
Closed, ResolvedPublic
Actions

Description

I ran the new-lexeme-special-page tests with axe-core 4.6.2 and ran into the following failure (excerpt from some add hoc debug logging):

{
  any: [ [Object] ],
  all: [],
  none: [],
  impact: 'critical',
  html: `<input type="text" class="wikit wikit-Input" placeholder="The Lexeme's language, e.g. 'English'" autocomplete="off" id="wikit-Lookup-695051" aria-owns="wikit-OptionsMenu-956787" aria-autocomplete="list" aria-haspopup="listbox" aria-expanded="true" aria-required="true" role="combobox">`,
  target: [ '#wikit-Lookup-695051' ],
  failureSummary: 'Fix any of the following:\n' +
    '  Required ARIA attribute not present: aria-controls'
}

These failures seem to be coming from wikit's LookupInput.

Details

SubjectRepoBranchLines +/-
Bump new-lexeme to pull in a11y improvementsmediawiki/extensions/WikibaseLexememaster+2 -2
Customize query in gerrit

Related Objects
Search...

Event Timeline

hoo created this task.Jan 10 2023, 9:38 PM
Maintenance_bot moved this task from Inbox to Sorted Team A on the [DEPRECATED] wdwb-tech board.Jan 10 2023, 10:15 PM
Lucas_Werkmeister_WMDE subscribed.Jan 11 2023, 3:40 PM

Hm, if I understand MDN: aria-controls correctly, Wikit should set the input’s aria-controls to the same ID as the aria-owns? (I.e., the input should both control and own the “combobox popup”.)

hoo added a comment.Jan 12 2023, 2:25 PM
In T326681#8516773, @Lucas_Werkmeister_WMDE wrote:

Hm, if I understand MDN: aria-controls correctly, Wikit should set the input’s aria-controls to the same ID as the aria-owns? (I.e., the input should both control and own the “combobox popup”.)

I think so, yes... although I'm not sure aria-owns is still needed in that case (although it doesn't seem like it would be wrong either).

hoo mentioned this in T326199: Chore: Update dependencies in new-lexeme-special-page.git.Jan 12 2023, 3:14 PM
Lucas_Werkmeister_WMDE added a comment.Jan 13 2023, 3:11 PM

Seems to work when I try it locally, at least. (Note: after editing Wikit, you not only have to copy the new dist files into node_modules/@wmde/wikit-vue-components/, you also have to remove node_modules/.vite/.)

Lucas_Werkmeister_WMDE claimed this task.EditedJan 13 2023, 3:16 PM
Lucas_Werkmeister_WMDE moved this task from Parents/Waiting to Peer Review on the Wikidata Dev Team (Sprint-∞) board.

https://github.com/wmde/wikit/pull/674

We might also want to propose this change to Codex, their Lookup currently also has aria-owns but not aria-controls. (Edit: done in Ia9207a6af5.)

Volker_E subscribed.Jan 16 2023, 1:47 AM

MDN describes the usefulness of aria-owns in our Lookup case very well:

An "owning element" is any DOM ancestor of an element. If an element visually, functionally, or contextually appears to "own" (be an ancestor of) an element, but isn't actually an ancestor the element in the DOM, include the aria-owns to create that relationship.

As the menu and the input are siblings, it's rightful to provide aria-owns as well. Mentioned on the patch, we should add the attribute to Combobox as well.

Volker_E added a project: Accessibility.Jan 16 2023, 1:47 AM
Lucas_Werkmeister_WMDE added a comment.Jan 16 2023, 4:30 PM

PR for Wikit pre-release: https://github.com/wmde/wikit/pull/676

Lucas_Werkmeister_WMDE added a comment.Jan 16 2023, 5:09 PM

PR for using the new Wikit version in new-lexeme-special-page: https://github.com/wmde/new-lexeme-special-page/pull/385

Lucas_Werkmeister_WMDE added a comment.Jan 16 2023, 5:12 PM

And when I locally update axe-core to 4.6, the tests pass now \o/ I’ll upload a PR for that once the Wikit upgrade is merged.

Lucas_Werkmeister_WMDE added a comment.Jan 17 2023, 4:05 PM

axe-core PR: https://github.com/wmde/new-lexeme-special-page/pull/386

gerritbot added a comment.Jan 18 2023, 11:36 AM

Change 881364 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/WikibaseLexeme@master] Bump new-lexeme to pull in a11y improvements

https://gerrit.wikimedia.org/r/881364

gerritbot added a project: Patch-For-Review.Jan 18 2023, 11:36 AM
gerritbot added a comment.Jan 18 2023, 2:50 PM

Change 881364 merged by jenkins-bot:

[mediawiki/extensions/WikibaseLexeme@master] Bump new-lexeme to pull in a11y improvements

https://gerrit.wikimedia.org/r/881364

Lucas_Werkmeister_WMDE closed this task as Resolved.Jan 18 2023, 2:57 PM
Lucas_Werkmeister_WMDE moved this task from Peer Review to Our work done on the Wikidata Dev Team (Sprint-∞) board.
karapayneWMDE moved this task from Our work done to 2023 completed tasks on the Wikidata Dev Team (Sprint-∞) board.Feb 6 2023, 4:23 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits