Maniphest T322689

Proper reconnection and error handling for Database::queryMulti()
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	aaron
	Nov 8 2022, 8:17 PM

Tags

Referenced Files

None

Subscribers

Description

This method should do several things that query() already does:

Handle retries if the first query failed due to prior connection loss
Set the transaction status field via setSessionError()/setTransactionError()

The exception documentation is also missing.

Details

	Subject	Repo	Branch	Lines +/-
	rdbms: improve Database::queryMulti() error handling	mediawiki/core	master	+216 -82

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Resolved		Ladsgroup	T314020 LoadMonitor connection weighting reimagined
		Resolved		aaron	T265386 Make LoadMonitor server states more up-to-date and respond to outages more quickly
		Resolved		aaron	T322689 Proper reconnection and error handling for Database::queryMulti()

Event Timeline

aaron created this task.Nov 8 2022, 8:17 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptNov 8 2022, 8:17 PM

larissagaulia moved this task from Inbox, needs triage to Doing: Prio Interrupt on the Performance-Team board.Nov 14 2022, 7:49 PM

aaron added a parent task: T265386: Make LoadMonitor server states more up-to-date and respond to outages more quickly.Nov 14 2022, 7:50 PM

aaron claimed this task.Nov 17 2022, 4:14 AM

Change 854953 had a related patch set uploaded (by Aaron Schulz; author: Aaron Schulz):

[mediawiki/core@master] rdbms: improve Database::queryMulti() error handling

https://gerrit.wikimedia.org/r/854953

gerritbot added a project: Patch-For-Review.Nov 17 2022, 4:17 AM

Change 854953 merged by jenkins-bot:

[mediawiki/core@master] rdbms: improve Database::queryMulti() error handling

https://gerrit.wikimedia.org/r/854953

ReleaseTaggerBot added a project: MW-1.40-notes (1.40.0-wmf.14; 2022-12-12).Dec 13 2022, 1:00 AM

Krinkle triaged this task as Medium priority.Dec 13 2022, 1:24 AM

Maintenance_bot removed a project: Patch-For-Review.Dec 13 2022, 1:30 AM

aaron closed this task as Resolved.Dec 13 2022, 11:27 PM