Page MenuHomePhabricator
Create Task
Maniphest T321501

Post-structured mentor list cleanup
Closed, ResolvedPublic
Actions

Description

After structured mentor list gets deployed (T310905), we should clean up a couple of things up:

  • Remove code supporting wikitext-based mentor lists
    • Remove GEMentorProvider and review&fix checks based on the variable
    • Delete MentorWeightManager service
    • Delete MentorProviderWikitext service
    • Rewrite GrowthExperimentsMentorProvider service wiring to only return $geServices->getMentorProviderStructured()
  • Remove config variables from operations/mediawiki-config
    • wgGEMentorProvider (patch)
    • Mentor list variables (wgGEHomepageMentorsList, wgGEHomepageManualAssignmentMentorsList; patch)

Details

SubjectRepoBranchLines +/-
[Growth] Remove mentor list variablesoperations/mediawiki-configmaster+0 -8
Remove GEMentorProvideroperations/mediawiki-configmaster+0 -4
Delete MentorWeightManagermediawiki/extensions/GrowthExperimentsmaster+48 -219
Remove wikitext mentor providermediawiki/extensions/GrowthExperimentsmaster+91 -1 K
Rename SpecialQuitMentorshipStructuredmediawiki/extensions/GrowthExperimentsmaster+6 -6
[tests] Rewrite MentorPageMentorManagerTest to not use wikitext providermediawiki/extensions/GrowthExperimentsmaster+9 -51
Set GEMentorProvider to "structured" by defaultmediawiki/extensions/GrowthExperimentsmaster+172 -74
Customize query in gerrit

Related Objects
Search...

Event Timeline

Urbanecm_WMF created this task.Oct 24 2022, 4:29 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 24 2022, 4:29 PM
Urbanecm_WMF moved this task from Inbox to Blocked on the Growth-Team board.Oct 24 2022, 4:29 PM

Blocked on T310905: Deploy structured wikitext mentor list to Wikimedia wikis.

Urbanecm_WMF removed a parent task: T264343: Have a special page for mentors to sign up.Oct 24 2022, 4:29 PM
Urbanecm_WMF added a subtask: T310905: Deploy structured wikitext mentor list to Wikimedia wikis.
Urbanecm_WMF moved this task from New Tasks to Needs Discussion on the GrowthExperiments-Mentorship board.
Urbanecm_WMF triaged this task as Low priority.Oct 24 2022, 4:39 PM
Urbanecm_WMF mentioned this in T321503: [structured mentor list] Replace action=growthsetmentorstatus with action=growthmanagementorlist.
Urbanecm_WMF added a subtask: T321503: [structured mentor list] Replace action=growthsetmentorstatus with action=growthmanagementorlist.
Urbanecm_WMF mentioned this in T310905: Deploy structured wikitext mentor list to Wikimedia wikis.Oct 31 2022, 6:52 AM
Urbanecm_WMF changed the status of subtask T310905: Deploy structured wikitext mentor list to Wikimedia wikis from In Progress to Open.Oct 31 2022, 6:55 AM
gerritbot added a comment.Oct 31 2022, 6:56 AM

Change 849545 had a related patch set uploaded (by Urbanecm; author: Urbanecm):

[mediawiki/extensions/GrowthExperiments@master] Set GEMentorProvider to "structured" by default

https://gerrit.wikimedia.org/r/849545

gerritbot added a project: Patch-For-Review.Oct 31 2022, 6:56 AM
Urbanecm_WMF closed subtask T310905: Deploy structured wikitext mentor list to Wikimedia wikis as Resolved.Nov 7 2022, 8:46 AM
gerritbot added a comment.Jan 23 2023, 10:21 PM

Change 849545 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] Set GEMentorProvider to "structured" by default

https://gerrit.wikimedia.org/r/849545

Maintenance_bot removed a project: Patch-For-Review.Jan 23 2023, 10:31 PM
ReleaseTaggerBot added a project: MW-1.40-notes (1.40.0-wmf.20; 2023-01-23).Jan 23 2023, 11:00 PM
gerritbot added a comment.Jan 24 2023, 11:38 AM

Change 883144 had a related patch set uploaded (by Urbanecm; author: Urbanecm):

[mediawiki/extensions/GrowthExperiments@master] [tests] Rewrite MentorPageMentorManagerTest to not use wikitext provider

https://gerrit.wikimedia.org/r/883144

gerritbot added a project: Patch-For-Review.Jan 24 2023, 11:38 AM
gerritbot added a comment.Jan 24 2023, 11:54 AM

Change 883153 had a related patch set uploaded (by Urbanecm; author: Urbanecm):

[operations/mediawiki-config@master] Remove GEMentorProvider

https://gerrit.wikimedia.org/r/883153

gerritbot added a comment.Jan 24 2023, 11:56 AM

Change 883154 had a related patch set uploaded (by Urbanecm; author: Urbanecm):

[mediawiki/extensions/GrowthExperiments@master] Remove wikitext mentor provider

https://gerrit.wikimedia.org/r/883154

gerritbot added a comment.Jan 24 2023, 4:53 PM

Change 883236 had a related patch set uploaded (by Urbanecm; author: Urbanecm):

[operations/mediawiki-config@master] [Growth] Remove mentor list variables

https://gerrit.wikimedia.org/r/883236

gerritbot added a comment.Jan 24 2023, 8:39 PM

Change 883144 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] [tests] Rewrite MentorPageMentorManagerTest to not use wikitext provider

https://gerrit.wikimedia.org/r/883144

ReleaseTaggerBot edited projects, added MW-1.40-notes (1.40.0-wmf.21; 2023-01-30); removed MW-1.40-notes (1.40.0-wmf.20; 2023-01-23).Jan 24 2023, 9:00 PM
gerritbot added a comment.Jan 25 2023, 9:16 AM

Change 883526 had a related patch set uploaded (by Urbanecm; author: Urbanecm):

[mediawiki/extensions/GrowthExperiments@master] Rename SpecialQuitMentorshipStructured

https://gerrit.wikimedia.org/r/883526

gerritbot added a comment.Jan 29 2023, 3:13 AM

Change 883154 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] Remove wikitext mentor provider

https://gerrit.wikimedia.org/r/883154

gerritbot added a comment.Jan 29 2023, 3:13 AM

Change 883526 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] Rename SpecialQuitMentorshipStructured

https://gerrit.wikimedia.org/r/883526

Urbanecm_WMF updated the task description. (Show Details)Jan 30 2023, 7:28 PM
gerritbot added a comment.Jan 30 2023, 7:30 PM

Change 884994 had a related patch set uploaded (by Urbanecm; author: Urbanecm):

[mediawiki/extensions/GrowthExperiments@master] Delete MentorWeightManager

https://gerrit.wikimedia.org/r/884994

Urbanecm_WMF updated the task description. (Show Details)Jan 30 2023, 7:38 PM
Urbanecm_WMF edited projects, added Growth-Team (Sprint 0 (Growth Team)); removed Growth-Team.Jan 30 2023, 7:41 PM
Urbanecm_WMF moved this task from Needs Discussion to In Progress on the GrowthExperiments-Mentorship board.
Urbanecm_WMF moved this task from Incoming to Code Review on the Growth-Team (Sprint 0 (Growth Team)) board.
Urbanecm_WMF added a comment.Feb 2 2023, 10:22 PM

This now needs r884994 merged. Next week, I'll also deploy the two config cleanups here.

gerritbot added a comment.Feb 3 2023, 12:27 AM

Change 884994 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] Delete MentorWeightManager

https://gerrit.wikimedia.org/r/884994

ReleaseTaggerBot edited projects, added MW-1.40-notes (1.40.0-wmf.22; 2023-02-06); removed MW-1.40-notes (1.40.0-wmf.21; 2023-01-30).Feb 3 2023, 1:00 AM
gerritbot added a comment.Feb 7 2023, 8:35 AM

Change 883153 merged by jenkins-bot:

[operations/mediawiki-config@master] Remove GEMentorProvider

https://gerrit.wikimedia.org/r/883153

gerritbot added a comment.Feb 7 2023, 8:35 AM

Change 883236 merged by jenkins-bot:

[operations/mediawiki-config@master] [Growth] Remove mentor list variables

https://gerrit.wikimedia.org/r/883236

Stashbot added a comment.Feb 7 2023, 8:35 AM

Mentioned in SAL (#wikimedia-operations) [2023-02-07T08:35:30Z] <kharlan@deploy1002> Started scap: Backport for [[gerrit:883236|[Growth] Remove mentor list variables (T321501)]], [[gerrit:883153|Remove GEMentorProvider (T321501)]]

Stashbot added a comment.Feb 7 2023, 8:37 AM

Mentioned in SAL (#wikimedia-operations) [2023-02-07T08:37:20Z] <kharlan@deploy1002> urbanecm and kharlan: Backport for [[gerrit:883236|[Growth] Remove mentor list variables (T321501)]], [[gerrit:883153|Remove GEMentorProvider (T321501)]] synced to the testservers: mwdebug1002.eqiad.wmnet, mwdebug2002.codfw.wmnet, mwdebug2001.codfw.wmnet, mwdebug1001.eqiad.wmnet

Stashbot added a comment.Feb 7 2023, 8:48 AM

Mentioned in SAL (#wikimedia-operations) [2023-02-07T08:48:18Z] <kharlan@deploy1002> Finished scap: Backport for [[gerrit:883236|[Growth] Remove mentor list variables (T321501)]], [[gerrit:883153|Remove GEMentorProvider (T321501)]] (duration: 12m 48s)

kostajh updated the task description. (Show Details)Feb 7 2023, 9:27 AM
kostajh moved this task from Code Review to QA on the Growth-Team (Sprint 0 (Growth Team)) board.
kostajh added subscribers: Etonkovidova, kostajh.

I think this is all done (cc @Etonkovidova), thank you @Urbanecm_WMF!

Maintenance_bot removed a project: Patch-For-Review.Feb 7 2023, 9:30 AM
Etonkovidova closed this task as Resolved.Mar 1 2023, 7:17 PM
Sgs changed the status of subtask T321503: [structured mentor list] Replace action=growthsetmentorstatus with action=growthmanagementorlist from Open to In Progress.Jul 7 2023, 12:21 PM
Urbanecm_WMF changed the status of subtask T321503: [structured mentor list] Replace action=growthsetmentorstatus with action=growthmanagementorlist from In Progress to Stalled.Jul 13 2023, 10:16 AM
Urbanecm_WMF changed the status of subtask T321503: [structured mentor list] Replace action=growthsetmentorstatus with action=growthmanagementorlist from Stalled to Open.Aug 2 2023, 4:29 PM
Urbanecm_WMF closed subtask T321503: [structured mentor list] Replace action=growthsetmentorstatus with action=growthmanagementorlist as Resolved.Aug 14 2023, 9:30 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits