Page MenuHomePhabricator

[Config Change] Add Clear Affordances to beta feature at Phase 1 wikis (desktop)
Closed, ResolvedPublic

Description

This task represents the work with enabling "Clear Affordances" as a feature within the existing Discussion tools Beta Feature at the Phase 1 Wikis.

BeforeAfter
image.png (239×1 px, 23 KB)
image.png (239×1 px, 25 KB)

Deployment Timing

Tuesday, 18 October

"Phase 1" Deployment Wikis

All Wikimedia wikis EXCEPT:

  • ar.wiki
  • de.wiki
  • en.wiki
  • fr.wiki
  • ja.wiki
  • yue.wiki
  • zh.wiki

Requirements

  • People who meet the criteria below will see the new Reply affordance styling when visiting any Article or User talk pages on desktop:
    • People who have the Discussion tools beta feature enabled
    • People who have the Show discussion activity setting within Special:Preferences#mw-prefsection-editing enabled
    • People accessing any one of the "Phase 1" Deployment Wikis using the desktop version of the site

Minimum test case

  1. At the wikis listed in Deployment wikis above, visit Special:Preferences#mw-prefsection-betafeatures
  2. Ensure the Discussion tools Beta Feature is enabled and the Show metadata about each discussion and enable a new page layout. list item appears within it
  3. Visit a User or Article talk page
  4. Verify that all Reply links/buttons appear in the way(s) we defined in T309904
  5. Visit a talk page that is NOT in the User or Article talk namespace and verify that Reply links appear as they did prior to this deployment and the Add topic button T267444 introduces is not visible. Read: talk page sections should continue being styled as they had before today's deployment.

Done

  • Requirements are implemented and verified as having been implemented

Event Timeline

Update
Per what @Whatamidoing-WMF and I talked about offline today, I've updated the task description with the date of this deployment and the wikis that will be included within it.

Change 843580 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[operations/mediawiki-config@master] Add "Clear Affordances" to DiscussionTools beta feature on most wikis

https://gerrit.wikimedia.org/r/843580

@matmarex @ppelberg I think people should be able to change the look of the button to the original one. Is there any CSS/JS to bring it back?

Change 843580 merged by jenkins-bot:

[operations/mediawiki-config@master] Add "Clear Affordances" to DiscussionTools beta feature on most wikis

https://gerrit.wikimedia.org/r/843580

Mentioned in SAL (#wikimedia-operations) [2022-10-18T13:06:53Z] <kharlan@deploy1002> Started scap: Backport for [[gerrit:843580|Add "Clear Affordances" to DiscussionTools beta feature on most wikis (T320683)]]

Mentioned in SAL (#wikimedia-operations) [2022-10-18T13:07:18Z] <kharlan@deploy1002> kharlan and matmarex: Backport for [[gerrit:843580|Add "Clear Affordances" to DiscussionTools beta feature on most wikis (T320683)]] synced to the testservers: mwdebug2001.codfw.wmnet, mwdebug1002.eqiad.wmnet, mwdebug1001.eqiad.wmnet, mwdebug2002.codfw.wmnet

@Patriccck You can turn this off, along with the other visual changes, by unchecking "Show discussion activity" ("Zobrazit diskusní aktivitu") on https://cs.wikipedia.org/wiki/Special:Preferences#mw-prefsection-editing. We don't have a separate option for just the styling of the reply button.

Just passing by to say that the vertical misalignment of the Reply button even on devs’ own screenshots should probably be fixed.