Page MenuHomePhabricator
Create Task
Maniphest T317907

[Config Change] Enable Page Frame as beta feature at partner wikis (desktop)
Closed, ResolvedPublic
Actions

Assigned To
matmarex
Authored By
ppelberg
Sep 15 2022, 5:54 PM
Tags
Referenced Files
F36340803: Screenshot 2023-01-20 at 07.31.52.png
Jan 20 2023, 7:42 AM
F36318971: Screenshot 2023-01-19 at 05.32.45.png
Jan 19 2023, 5:36 AM
F36318972: Screenshot 2023-01-19 at 05.32.28.png
Jan 19 2023, 5:36 AM
F36318973: Screenshot 2023-01-19 at 05.31.04.png
Jan 19 2023, 5:36 AM
F36318959: Screenshot 2023-01-19 at 05.27.27.png
Jan 19 2023, 5:36 AM
F36318953: Screenshot 2023-01-19 at 05.18.32.png
Jan 19 2023, 5:36 AM
F36318955: Screenshot 2023-01-19 at 05.22.43.png
Jan 19 2023, 5:36 AM
F36318965: Screenshot 2023-01-19 at 04.59.43.png
Jan 19 2023, 5:36 AM
View All 11 Files
Subscribers
Aklapper
Dyolf77_WMF
EAkinloose
matmarex
nayoub
ppelberg
• Whatamidoing-WMF

Description

This task represents the work with enabling the set of "Page Frame" enhancements as features within the existing Discussion tools Beta Feature.

Deployment Timing

Tuesday, 17 January 2023

Deployment wikis

  • ar.wiki
  • cs.wiki
  • hu.wiki

Requirements

Meta

  • People who meet the criteria below will see the "UX changes" listed below when visiting any Article or User talk pages on desktop:
    • People who have the Discussion tools beta feature enabled
    • People who have the Show discussion activity setting within Special:Preferences#mw-prefsection-editing enabled
    • People accessing ar.wiki, cs.wiki, or hu.wiki using the desktop version of the site

UX Changes

  1. A visual space between the "namespace" and "page" name portion of a talk page's title
  2. An indicator that describes, and links to, the latest comment published on a given talk page
  3. Information within the table of contents about the number of comments within each section

See more in T317907#8521159.

UX ChangesUX Changes (annotated)
Screen Shot 2023-01-12 at 11.29.09 AM.png (1×2 px, 348 KB)
Screen Shot 2023-01-12 at 11.29.09 AM copy.png (1×2 px, 354 KB)

Minimum test case

  1. At the wikis listed in Deployment wikis above, visit Special:Preferences#mw-prefsection-betafeatures
  2. Ensure the Discussion tools Beta Feature is enabled and the Show metadata about each discussion and enable a new page layout. list item appears within it
  3. Visit a User or Article talk page
  4. Notice the following changes:
    • A visual space between the "namespace" and "page" name portion of a talk page's title
    • An indicator that describes, and links to, the latest comment published on a given talk page
    • Information within the table of contents about the number of comments within each section

Done

  • Requirements are implemented and verified as having been implemented

Details

SubjectRepoBranchLines +/-
Add "Page Frame" to DiscussionTools beta feature on partner wikisoperations/mediawiki-configmaster+3 -0
Customize query in gerrit

Related Objects
Search...

StatusSubtypeAssignedTask
 OpenNoneT276497 Scale DiscussionTools to all projects
 OpenNoneT366095 Deploy comment thanking to all wikis
 OpenNoneT310959 Scale Usability Improvements to all projects
OpenTrizek-WMFT319146 [Release Ticket] Offer Usability Improvements as default-on feature at all projects (desktop)
 ResolvedppelbergT302547 [Usability Improvements] Deploy as Beta Feature at all wikis (desktop)
 OpenNoneT249579 [EPIC] Usability improvements: make the actions, activity and content within talk pages easier to understand
 OpenNoneT269963 [EPIC] Talk Page Frame
 ResolvedppelbergT304372 [Release ticket] Deploy Page Frame as Beta Feature at Partner Wikis
 ResolvedmatmarexT317907 [Config Change] Enable Page Frame as beta feature at partner wikis (desktop)
 ResolvedRyasmeenT303634 Adapt new ToC to help people understand and navigate pages that contain discussions
 DuplicateNoneT305663 [SPIKE] Determine what additional work (if any) is required to adapt ToC for use on discussion pages
 ResolvedBUG REPORT• nrayT305123 Showing Table of contents sometimes requires reload (Vector 22, wmf.5)
 ResolvedppelbergT305576 [SPIKE] Define work to be done before discussion-specific ToC is production ready
 ResolvedppelbergT306364 Define treatment for H3 and H4 topics in ToC on talk page
 ResolvedJdlrobsonT307251 [ToC] Show new/modified sections after publishing an edit (new floating ToC)
 ResolvedBUG REPORTmatmarexT307480 Modify VisualEditor to trigger a hook with sections data for table of contents re-rendering
 ResolvedmatmarexT307823 Improve how ToC is rendered to allow adding discussion enhancements
 ResolvedppelbergT313454 [SPIKE] Decide whether config is necessary to isolate Page Frame to desktop talk pages
 Resolved• Whatamidoing-WMFT323725 [Announcement] Make volunteers aware of Page Frame functionality being added to beta feature (desktop)

Event Timeline

ppelberg created this task.Sep 15 2022, 5:54 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 15 2022, 5:54 PM
ppelberg moved this task from Untriaged to Upcoming on the Editing-team board.Sep 15 2022, 5:54 PM
ppelberg moved this task from Backlog to Triaged on the DiscussionTools board.
ppelberg mentioned this in T302547: [Usability Improvements] Deploy as Beta Feature at all wikis (desktop).
VPuffetMichel added a project: TPP-Scaling.Oct 26 2022, 1:44 PM
VPuffetMichel moved this task from Scaling Epics to Scheduled Deployments on the TPP-Scaling board.Oct 26 2022, 1:47 PM
ppelberg added a subtask: T318021: Add way to change title of ToC in Vector (2022).Nov 23 2022, 5:23 PM
ppelberg added a subtask: T303634: Adapt new ToC to help people understand and navigate pages that contain discussions.
ppelberg added a subtask: T313454: [SPIKE] Decide whether config is necessary to isolate Page Frame to desktop talk pages.Nov 23 2022, 5:40 PM
ppelberg removed a subtask: T318021: Add way to change title of ToC in Vector (2022).Nov 29 2022, 11:58 PM
ppelberg mentioned this in T318021: Add way to change title of ToC in Vector (2022).
ppelberg closed subtask T303634: Adapt new ToC to help people understand and navigate pages that contain discussions as Resolved.Dec 2 2022, 12:32 AM
ppelberg closed subtask T313454: [SPIKE] Decide whether config is necessary to isolate Page Frame to desktop talk pages as Resolved.Dec 12 2022, 5:38 PM
ppelberg added a subtask: T267444: Make the affordance(s) for adding a new topic easier to identify and access (Vector 2022).Dec 12 2022, 5:43 PM
ppelberg edited projects, added Editing-team (Kanban Board); removed Editing-team.Jan 9 2023, 5:44 PM
ppelberg added a subtask: T326572: ULS sticky header should be added by ULS, not Vector.Jan 10 2023, 5:16 PM
ppelberg removed a subtask: T326572: ULS sticky header should be added by ULS, not Vector.
Dyolf77_WMF subscribed.Jan 10 2023, 5:33 PM
gerritbot added a comment.Jan 12 2023, 12:09 AM

Change 879159 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[operations/mediawiki-config@master] Add "Page Frame" to DiscussionTools beta feature on partner wikis

https://gerrit.wikimedia.org/r/879159

gerritbot added a project: Patch-For-Review.Jan 12 2023, 12:09 AM
matmarex subscribed.Jan 12 2023, 12:09 AM

Tentatively planned for 18th.

matmarex moved this task from Incoming to Doing on the Editing-team (Kanban Board) board.Jan 12 2023, 12:29 AM
ppelberg assigned this task to nayoub.EditedJan 12 2023, 7:36 PM
ppelberg moved this task from Doing to Design Review on the Editing-team (Kanban Board) board.
ppelberg added a subscriber: nayoub.

PROPOSED SCOPE REVISION
Per the conversation the Editing Team had offline today, we're considering [i] revising the scope of this initial Page Frame deployment to exclude the revised appearance and placement of the Add Topic button T267444 introduces.

We're considering revising the scope for two reasons:

  1. Implementing T267444 depends on T326572, the latter of which requires input from the Web Team who is not available within the next 1-2 weeks given all they are responsible for related to the deployment of Vector (2022) to en.wiki
  2. We do not currently think [i] the absence of T267444 will take away from the benefits we expect people to glean from the other three changes that this deployment will end up being made up of:
    • A) A visual space between the "namespace" and "page" name portion of a talk page's title
    • B) An indicator that describes, and links to, the latest comment published on a given talk page
    • C) Information within the table of contents about the number of comments within each section

The screenshot below illustrates the three features above; you can also experience the features live by visiting a wikitext talk page on mediawiki.org (e.g. https://www.mediawiki.org/wiki/Talk_pages_project/Usability#Phase_3:_Framing_context)

Revised scopeRevised scope (annotated)
Screen Shot 2023-01-12 at 11.29.09 AM.png (1×2 px, 348 KB)
Screen Shot 2023-01-12 at 11.29.09 AM copy.png (1×2 px, 354 KB)

i. The decision to finalize the scope changes described above depends on @nayoub reviewing them.

nayoub added a comment.Jan 12 2023, 11:38 PM

The revised scope looks great – I don't imagine the absence of T267444 having an impact on this initial deployment of Page Frame.

nayoub reassigned this task from nayoub to ppelberg.Jan 12 2023, 11:39 PM
ppelberg moved this task from Design Review to Code Review on the Editing-team (Kanban Board) board.Jan 12 2023, 11:41 PM
ppelberg added a comment.Jan 12 2023, 11:45 PM
In T317907#8522204, @nayoub wrote:

The revised scope looks great – I don't imagine the absence of T267444 having an impact on this initial deployment of Page Frame.

Excellent.

With @nayoub commenting the above, we can commit to a deployment date for next week: Tuesday, 17 January 2023.

ppelberg reassigned this task from ppelberg to matmarex.Jan 12 2023, 11:45 PM
ppelberg updated the task description. (Show Details)
gerritbot added a comment.Jan 17 2023, 6:14 PM

Change 879159 merged by jenkins-bot:

[operations/mediawiki-config@master] Add "Page Frame" to DiscussionTools beta feature on partner wikis

https://gerrit.wikimedia.org/r/879159

Stashbot added a comment.Jan 17 2023, 6:23 PM

Mentioned in SAL (#wikimedia-operations) [2023-01-17T18:23:01Z] <zabe@deploy1002> Started scap: Backport for [[gerrit:880908|objectcache: Fix DI for MultiWriteBagOStuff sub caches (T327158)]], [[gerrit:878169|Use new DiscussionTools heading markup on enwiki (T314714)]], [[gerrit:879158|Add "Clear Affordances" to DiscussionTools beta feature on remaining wikis (T321955)]], [[gerrit:879159|Add "Page Frame" to DiscussionTools beta feature on partner wikis (T317907)]], [[gerrit:879103|

Stashbot mentioned this in T314714: Metadata and buttons should be inserted after a heading, not inside of it.Jan 17 2023, 6:23 PM
Stashbot mentioned this in T321955: [Config Change] Add Clear Affordances to beta feature at Phase 3 wikis (desktop).
Stashbot mentioned this in T327158: ArgumentCountError: Too few arguments to function SqlBagOStuff::__construct(), 0 passed in /srv/mediawiki/php-1.40.0-wmf.19/vendor/wikimedia/object-factory/src/ObjectFactory.php on line 240 and exactly 1 expected.
Stashbot added a comment.Jan 17 2023, 6:25 PM

Mentioned in SAL (#wikimedia-operations) [2023-01-17T18:25:06Z] <zabe@deploy1002> zabe and matmarex and zabe: Backport for [[gerrit:880908|objectcache: Fix DI for MultiWriteBagOStuff sub caches (T327158)]], [[gerrit:878169|Use new DiscussionTools heading markup on enwiki (T314714)]], [[gerrit:879158|Add "Clear Affordances" to DiscussionTools beta feature on remaining wikis (T321955)]], [[gerrit:879159|Add "Page Frame" to DiscussionTools beta feature on partner wikis (T317907)]], [[

Maintenance_bot removed a project: Patch-For-Review.Jan 17 2023, 6:31 PM
matmarex moved this task from Code Review to QA on the Editing-team (Kanban Board) board.Jan 17 2023, 7:19 PM
matmarex added a project: Editing QA.
ppelberg updated the task description. (Show Details)Jan 17 2023, 10:05 PM
ppelberg updated the task description. (Show Details)
ppelberg moved this task from Inbox to High Priority on the Editing QA board.
ppelberg updated the task description. (Show Details)
EAkinloose subscribed.EditedJan 19 2023, 5:36 AM

ar.wiki

Screenshot 2023-01-19 at 04.59.43.png (900×2 px, 283 KB)

Screenshot 2023-01-20 at 07.31.52.png (1×2 px, 533 KB)

Screenshot 2023-01-19 at 05.04.45.png (1×2 px, 267 KB)

cs.wiki

Screenshot 2023-01-19 at 05.22.43.png (1×2 px, 752 KB)

Screenshot 2023-01-19 at 05.18.32.png (460×2 px, 91 KB)

Screenshot 2023-01-19 at 05.27.27.png (372×2 px, 65 KB)

hu.wiki

Screenshot 2023-01-19 at 05.31.04.png (1×1 px, 566 KB)

Screenshot 2023-01-19 at 05.32.28.png (360×1 px, 73 KB)

Screenshot 2023-01-19 at 05.32.45.png (636×2 px, 192 KB)

ppelberg mentioned this in T323727: [Config Change] Enable Page Frame as beta feature at Phase 1 wikis (desktop).Jan 19 2023, 11:55 PM
ppelberg mentioned this in T327456: [Config Change] Add Page Frame to beta feature at Phase 2 wikis (desktop).Jan 19 2023, 11:58 PM
ppelberg mentioned this in T327442: Announce addition of Page Frame features to beta feature (Phase 1 wikis, desktop).Jan 20 2023, 12:01 AM
EAkinloose edited projects, added Verified; removed Editing QA.Jan 20 2023, 7:42 AM
EAkinloose moved this task from QA to Ready for Sign Off on the Editing-team (Kanban Board) board.
ppelberg closed this task as Resolved.Jan 21 2023, 12:14 AM
EAkinloose attached a referenced file: F36340803: Screenshot 2023-01-20 at 07.31.52.png. (Show Details)Jan 25 2023, 7:59 PM
ppelberg removed a subtask: T267444: Make the affordance(s) for adding a new topic easier to identify and access (Vector 2022).Mar 6 2023, 5:00 PM
• Whatamidoing-WMF closed subtask T323725: [Announcement] Make volunteers aware of Page Frame functionality being added to beta feature (desktop) as Resolved.Apr 5 2023, 5:01 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits