In T307869, we temporarily only made the new profile parameter available in the wbsearchentities and query+wbsearch APIs if more than one profile is configured, so that we could roll out this feature with a single config setting. Now that the rollout is done, we want to remove this strange situation, and always make the API parameter itself available, even when only one profile (the default one) is configured.
Description
Description
Details
Details
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Resolved | Lydia_Pintscher | T298134 Input of data about the new Lexeme | |||
| Resolved | Lydia_Pintscher | T298138 Lexeme Language Lookup | |||
| Resolved | Lydia_Pintscher | T298140 Lexeme Language Lookup - Prioritize Items for languages in the Item lookup | |||
| Resolved | Lucas_Werkmeister_WMDE | T317317 Always make wbsearchentities profile parameter available |
Event Timeline
Comment Actions
Change 806927 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/Wikibase@master] Make profile search parameter available unconditionally
Comment Actions
I forgot that there was already a patch uploaded for this ^^ attached it to this task now.
Comment Actions
I would say this doesn’t need an extra announcement, the previous announcement about the profile parameter should cover it – but pinging @Mohammed_Sadat_WMDE for confirmation. (This change will make the parameter available on other Wikibases, though on most of them the only allowed value will be default.)
I also think we should backport this to REL1_39 – the code to make the parameter conditionally available is already part of that branch, and I don’t think we should release it in that form.
Comment Actions
Change 806927 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Make profile search parameter available unconditionally
Comment Actions
Change 838214 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/Wikibase@REL1_39] Make profile search parameter available unconditionally
Comment Actions
Moving to tech verification for now, since there’s an open question I think. On master, this is now merged and will roll out with the train. IMHO we should also backport this to REL1_39 – but REL1_39 CI is currently broken for Wikibase (T319390), and it doesn’t sound like another Wikibase team will be looking into that issue soon. Should we take over responsibility for fixing CI? Perhaps just force-merge the backport? Or leave it open until CI gets fixed by someone else? (And in that case, leave this task open as well, or close it?)
Comment Actions
Nevermind, I found a solution for the CI issue – if nobody objects, I think we can just pull that into the sprint for review.
Comment Actions
Change 838214 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@REL1_39] Make profile search parameter available unconditionally