Page MenuHomePhabricator
Create Task
Maniphest T314099

PHP 8.2: Dynamic property creation is deprecated
Open, Needs TriagePublic
Actions

Description

Per https://github.com/php/php-src/blob/107ad28350e76f40d6e65ceac4e45cbf8cc3dc75/UPGRADING#L138:

. Creation of dynamic properties is deprecated, unless the class opts in by
  using the #[AllowDynamicProperties] attribute. stdClass allows dynamic
  properties. Usage of __get()/__set() is not affected by this change. A
  dynamic properties deprecation warning can be addressed by:
   - Declaring the property (preferred).
   - Adding the #[AllowDynamicProperties] attribute to the class (which also
     applies to all child classes).
   - Using a WeakMap if you wish to associate additional data with an object
     you do not own.

Out of the three suggested migration paths, the third one (WeakMap) is not really an option as of now given that WeakMaps were added in PHP 8.

Details

SubjectRepoBranchLines +/-
Declare properties staticallymediawiki/extensions/MathREL1_40+7 -2
Declare properties staticallymediawiki/extensions/MathREL1_41+7 -2
Declare properties staticallymediawiki/extensions/MathREL1_39+9 K -0
Declare properties staticallymediawiki/extensions/Mathmaster+7 -2
Add AllowDynamicProperties to Wikimedia\Parsoid\DOM\Documentmediawiki/services/parsoidREL1_39+1 -0
Set default values explicit in Wikimedia\Parsoid\Ext\Gallery\Optsmediawiki/services/parsoidREL1_41+10 -3
Set default values explicit in Wikimedia\Parsoid\Ext\Gallery\Optsmediawiki/services/parsoidmaster+10 -3
Bump wikimedia/parsoid to 0.19.0-a9mediawiki/vendormaster+206 -96
Set default values explicit in Wikimedia\Parsoid\Ext\Gallery\Optsmediawiki/services/parsoidREL1_40+10 -3
Set default values explicit in Wikimedia\Parsoid\Ext\Gallery\Optsmediawiki/services/parsoidREL1_39+10 -3
tests: Declare class properties in test casesmediawiki/extensions/Wikibasemaster+28 -3
tests: Declare class properties in test casesmediawiki/extensions/WikibaseLexememaster+10 -0
tests: Declare class properties in MediaInfoRdfBuilderTestmediawiki/extensions/WikibaseMediaInfomaster+5 -0
Bump wikimedia/parsoid to 0.17.0-a21mediawiki/vendormaster+663 -180
Add AllowDynamicProperties to Wikimedia\Parsoid\DOM\Documentmediawiki/services/parsoidmaster+1 -0
tests: Suppress dynamic properties on PHP 8.2 for SerializationTestUtilsmediawiki/coremaster+3 -1
revisiondelete: Replace dynamic property Status::$itemStatusesmediawiki/coreREL1_38+4 -4
revisiondelete: Replace dynamic property Status::$itemStatusesmediawiki/coreREL1_35+4 -4
revisiondelete: Replace dynamic property Status::$itemStatusesmediawiki/coreREL1_39+4 -4
revisiondelete: Replace dynamic property Status::$itemStatusesmediawiki/coremaster+4 -4
tests: Handle dynamic created properties on test classesmediawiki/coreREL1_39+51 -15
tests: Handle dynamic created properties on test classesmediawiki/coremaster+51 -15
tests: Replace dynamic property MWCallableUpdate::$_namemediawiki/coreREL1_39+6 -10
Bump parsoid to 0.17.0-a10mediawiki/vendormaster+288 -112
tests: Replace dynamic property MWCallableUpdate::$_namemediawiki/coremaster+6 -10
libs\jsminplus: Declare JSNode::$expressionmediawiki/coreREL1_39+1 -1
libs\jsminplus: Declare JSNode::$expressionmediawiki/coremaster+1 -1
tests: Remove assertion of spec in ParamValidatorTest::testGetTypeDefmediawiki/coreREL1_39+0 -3
stream wrapper: Declare $context class propertymediawiki/coreREL1_39+6 -0
tests: Remove assertion of spec in ParamValidatorTest::testGetTypeDefmediawiki/coremaster+0 -3
stream wrapper: Declare $context class propertymediawiki/coremaster+6 -0
tests: Allow dynamic properties on PHP 8.2 for GhostFieldTestClassmediawiki/coreREL1_39+1 -0
tests: Allow dynamic properties on PHP 8.2 for GhostFieldTestClassmediawiki/coremaster+1 -0
tests: Declare GIFMetadataExtractorTest::$mediaPathmediawiki/coreREL1_39+3 -0
tests: Declare GIFMetadataExtractorTest::$mediaPathmediawiki/coremaster+3 -0
tests: Change assertion in AbstractSecondaryAuthenticationProviderTestmediawiki/coreREL1_39+1 -4
tests: Change assertion in AbstractSecondaryAuthenticationProviderTestmediawiki/coremaster+1 -4
NodeData: Allow dynamic properties on PHP 8.2mediawiki/services/parsoidmaster+9 -0
NodeData: Allow dynamic properties on PHP 8.2mediawiki/services/parsoidREL1_39+9 -0
api: Remove use of undeclared property in action=comparepagesmediawiki/coreREL1_39+1 -4
api: Remove use of undeclared property in action=comparepagesmediawiki/coremaster+1 -4
OutputPage: Remove unused dynamic property ParserOptions->isBogusmediawiki/coreREL1_39+0 -2
OutputPage: Remove unused dynamic property ParserOptions->isBogusmediawiki/coremaster+0 -2
phpunit: Fix trivial dynamic property usages in testsmediawiki/coreREL1_38+5 -1
phpunit: Fix trivial dynamic property usages in testsmediawiki/coreREL1_35+5 -0
phpunit: Fix trivial dynamic property usages in testsmediawiki/coreREL1_37+5 -1
User: Allow dynamic properties on PHP 8.2mediawiki/coreREL1_35+1 -0
User: Allow dynamic properties on PHP 8.2mediawiki/coreREL1_37+1 -0
User: Allow dynamic properties on PHP 8.2mediawiki/coreREL1_38+1 -0
User: Allow dynamic properties on PHP 8.2mediawiki/coremaster+1 -0
preprocessor: Add missing field declarationsmediawiki/coreREL1_35+21 -2
preprocessor: Add missing field declarationsmediawiki/coreREL1_37+20 -5
preprocessor: Add missing field declarationsmediawiki/coreREL1_38+20 -5
phpunit: Fix trivial dynamic property usages in testsmediawiki/coremaster+8 -4
preprocessor: Add missing field declarationsmediawiki/coremaster+20 -5
Show related patches Customize query in gerrit

Related Objects
Search...

StatusSubtypeAssignedTask
 OpenNoneT314099 PHP 8.2: Dynamic property creation is deprecated
 ResolvedReedyT324890 Deprecated: Creation of dynamic property Parser::$extTemplateStylesCache is deprecated in Hooks.php on line 208
 ResolvedReedyT324891 Deprecated: Creation of dynamic property Parser::$scribunto_engine is deprecated
 DuplicateNoneT324893 Deprecated: Creation of dynamic property TimedMediaTransformOutput::$tempFSFileReferences is deprecated in TempFSFile.php on line 135
 ResolvedTK-999T324894 Deprecated: Creation of dynamic property TransformTooBigImageAreaError::$tempFSFileReferences is deprecated in TempFSFile.php on line 135
 ResolvedReedyT324895 Deprecated: Creation of dynamic property MWCallbackStream::$stream is deprecated in MWCallbackStream.php on line 42
 ResolvedUmherirrenderT324896 Deprecated: Creation of dynamic property in oojs/oojs-ui
 ResolvedUmherirrenderT324897 Deprecated: Creation of dynamic property SpecialTrackingCategories::$categoryTreeCategories is deprecated in Hooks.php on line 312
 OpenNoneT324898 Deprecated: Creation of dynamic property in OAuth
 ResolvedReedyT324901 Deprecated: Creation of dynamic property Parser::$extCite is deprecated in CiteParserTagHooks.php on line 94
 ResolvedReedyT324902 Deprecated: Creation of dynamic property Wikimedia\Parsoid\DOM\Document::$body is deprecated in DOMCompat.php on line 88
 ResolvedNoneT324903 Deprecated: Creation of dynamic properties in FlaggedRevs
 ResolvedReedyT324904 Deprecated: Creation of dynamic property MediaWiki\Extension\OAuth\Backend\ConsumerAcceptance::$oauth_version is deprecated in MWOAuthDAO.php on line 354
 ResolvedTK-999T326466 Rework database setup in integration test to avoid dynamic properties under php8.2
 ResolvedUmherirrenderT326478 Rework auth/session related tests to avoid dynamic properties under php8.2
 ResolvedAmmarpadT326479 Replace dynamic property Status::$apiHookResult used by ApiEditPage and EditFilterMergedContentHook
 ResolvedTgrT330499 Deprecated: Creation of dynamic property MediaWiki\Minerva\Skins\SkinMinerva::$growthExperimentsHomepageDiscoveryNoticeSeen is deprecated includes/Homepage/SiteNoticeGenerator.php
 ResolvedPleaseStandT326454 Creation of dynamic property Mail_smtp::$greeting is deprecated
 ResolvedNoneT353644 PHP Deprecated: Creation of dynamic property Wikimedia\Parsoid\Html2Wt\SerializerState::$logType is deprecated
 Resolved• brookeT353163 Creation of dynamic property File_Ogg_Theora::$_firstGranulePos is deprecated
 ResolvedNoneT353161 [CLIENT] Creation of dynamic property MediaWiki\Title\Title::$wikibasePushedDeleteToRepo is deprecated
 ResolvedUmherirrenderT353184 Creation of dynamic property Wikibase\Lib\Store\EntityRevision::$user is deprecated
 OpenNoneT352679 HistoryBlobUtilsTest::testUnserializeBadEmbedded Creation of dynamic property HistoryBlobStub::$bad is deprecated
 ResolvedReedyT326182 Deprecated: Creation of dynamic property is deprecated
 ResolvedBUG REPORTAManWithNoPlanT352814 Undefined/unused variable $request->base_string
 OpenNoneT372356 LiquidThreads creates dynamic property OutputPage::mLqtReplacements

Event Timeline

There are a very large number of changes, so older changes are hidden. Show Older Changes
gerritbot added a comment.Jan 7 2023, 3:40 PM

Change 876307 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/core@master] tests: Handle dynamic created properties on test classes

https://gerrit.wikimedia.org/r/876307

gerritbot added a comment.Jan 7 2023, 5:11 PM

Change 876315 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/services/parsoid@master] Add AllowDynamicProperties to Wikimedia\Parsoid\DOM\Document

https://gerrit.wikimedia.org/r/876315

Umherirrender added a subtask: T326478: Rework auth/session related tests to avoid dynamic properties under php8.2.Jan 7 2023, 8:06 PM
Umherirrender added a subtask: T326479: Replace dynamic property Status::$apiHookResult used by ApiEditPage and EditFilterMergedContentHook.Jan 7 2023, 8:24 PM
gerritbot added a comment.Jan 7 2023, 8:38 PM

Change 876320 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/core@master] revisiondelete: Replace dynamic property Status::$itemStatuses

https://gerrit.wikimedia.org/r/876320

gerritbot added a comment.Jan 7 2023, 8:48 PM

Change 876321 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/core@master] tests: Replace dynamic property MWCallableUpdate::$_name

https://gerrit.wikimedia.org/r/876321

Reedy moved this task from Backlog to Other on the PHP 8.2 support board.Jan 8 2023, 11:42 PM
gerritbot added a comment.Jan 9 2023, 4:36 PM

Change 876321 merged by jenkins-bot:

[mediawiki/core@master] tests: Replace dynamic property MWCallableUpdate::$_name

https://gerrit.wikimedia.org/r/876321

gerritbot added a comment.Jan 9 2023, 4:37 PM

Change 877145 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/core@REL1_39] tests: Replace dynamic property MWCallableUpdate::$_name

https://gerrit.wikimedia.org/r/877145

gerritbot added a comment.Jan 9 2023, 8:43 PM

Change 877256 had a related patch set uploaded (by C. Scott Ananian; author: C. Scott Ananian):

[mediawiki/vendor@master] Bump parsoid to 0.17.0-a10

https://gerrit.wikimedia.org/r/877256

gerritbot added a comment.Jan 9 2023, 9:37 PM

Change 877256 merged by jenkins-bot:

[mediawiki/vendor@master] Bump parsoid to 0.17.0-a10

https://gerrit.wikimedia.org/r/877256

Reedy subscribed.Jan 9 2023, 10:50 PM
In T314099#8506437, @Umherirrender wrote:

The lib wikimedia/less.php has also some dynamic properties, which are fixed with https://github.com/wikimedia/less.php/commit/a93b0827b650a347f7c694e1e234f8c86efa8812, no new release yet.

v3.2.0 is out - https://gerrit.wikimedia.org/r/877264 and https://gerrit.wikimedia.org/r/877266 to get that into master

gerritbot added a comment.Jan 9 2023, 11:01 PM

Change 877145 merged by jenkins-bot:

[mediawiki/core@REL1_39] tests: Replace dynamic property MWCallableUpdate::$_name

https://gerrit.wikimedia.org/r/877145

Reedy added a comment.Jan 10 2023, 2:03 AM

Noticed in T324898: Deprecated: Creation of dynamic property in OAuth that phan's PhanUndeclaredProperty can pick this up, if it's not suppressed...

Definitely various inline suppressions, which is probably another good way to hunt for usages that potentially need addressing - https://codesearch.wmcloud.org/search/?q=PhanUndeclaredProperty&i=nope&files=&excludeFiles=&repos=

Umherirrender added a comment.Jan 10 2023, 4:42 PM
In T314099#8511621, @Reedy wrote:

Noticed in T324898: Deprecated: Creation of dynamic property in OAuth that phan's PhanUndeclaredProperty can pick this up, if it's not suppressed...

Definitely various inline suppressions, which is probably another good way to hunt for usages that potentially need addressing - https://codesearch.wmcloud.org/search/?q=PhanUndeclaredProperty&i=nope&files=&excludeFiles=&repos=

Not in tests, phan runs only for production code. And not for classes implements __get/__set (directly or with trait), that makes it also harder for static analyzer to see correct or incorrect usages (T326479 for example was not picked up by phan, while it shows up when there is no get/set in Status)

Reedy added a comment.Jan 10 2023, 4:44 PM
In T314099#8513226, @Umherirrender wrote:
In T314099#8511621, @Reedy wrote:

Noticed in T324898: Deprecated: Creation of dynamic property in OAuth that phan's PhanUndeclaredProperty can pick this up, if it's not suppressed...

Definitely various inline suppressions, which is probably another good way to hunt for usages that potentially need addressing - https://codesearch.wmcloud.org/search/?q=PhanUndeclaredProperty&i=nope&files=&excludeFiles=&repos=

Not in tests, phan runs only for production code. And not for classes implements __get/__set (directly or with trait), that makes it also harder for static analyzer to see correct or incorrect usages (T326479 for example was not picked up by phan, while it shows up when there is no get/set in Status)

Well, sure... But it's a reference to find some of them, rather than waiting for code execution to hit them later :)

gerritbot added a comment.Jan 13 2023, 9:50 PM

Change 876307 merged by jenkins-bot:

[mediawiki/core@master] tests: Handle dynamic created properties on test classes

https://gerrit.wikimedia.org/r/876307

gerritbot added a comment.Jan 13 2023, 9:59 PM

Change 879794 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/core@REL1_39] tests: Handle dynamic created properties on test classes

https://gerrit.wikimedia.org/r/879794

ReleaseTaggerBot edited projects, added MW-1.40-notes (1.40.0-wmf.19; 2023-01-16); removed MW-1.40-notes (1.40.0-wmf.18; 2023-01-09).Jan 13 2023, 10:00 PM
gerritbot added a comment.Jan 13 2023, 10:23 PM

Change 879794 merged by jenkins-bot:

[mediawiki/core@REL1_39] tests: Handle dynamic created properties on test classes

https://gerrit.wikimedia.org/r/879794

Umherirrender closed subtask T324897: Deprecated: Creation of dynamic property SpecialTrackingCategories::$categoryTreeCategories is deprecated in Hooks.php on line 312 as Resolved.Jan 27 2023, 12:58 PM
gerritbot added a comment.Feb 4 2023, 8:47 PM

Change 876320 merged by jenkins-bot:

[mediawiki/core@master] revisiondelete: Replace dynamic property Status::$itemStatuses

https://gerrit.wikimedia.org/r/876320

gerritbot added a comment.Feb 4 2023, 8:57 PM

Change 886413 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/core@REL1_39] revisiondelete: Replace dynamic property Status::$itemStatuses

https://gerrit.wikimedia.org/r/886413

Umherirrender closed this task as Resolved.Feb 4 2023, 8:57 PM
Umherirrender reopened this task as Open.
Umherirrender claimed this task.
Umherirrender removed Umherirrender as the assignee of this task.

[Assumed this was a specific sub task for the Status::$itemStatuses issue ..., reopened]

ReleaseTaggerBot edited projects, added MW-1.40-notes (1.40.0-wmf.22; 2023-02-06); removed MW-1.40-notes (1.40.0-wmf.19; 2023-01-16).Feb 4 2023, 9:00 PM
gerritbot added a comment.Feb 4 2023, 9:12 PM

Change 886414 had a related patch set uploaded (by Reedy; author: Umherirrender):

[mediawiki/core@REL1_38] revisiondelete: Replace dynamic property Status::$itemStatuses

https://gerrit.wikimedia.org/r/886414

gerritbot added a comment.Feb 4 2023, 9:12 PM

Change 886415 had a related patch set uploaded (by Reedy; author: Umherirrender):

[mediawiki/core@REL1_35] revisiondelete: Replace dynamic property Status::$itemStatuses

https://gerrit.wikimedia.org/r/886415

gerritbot added a comment.Feb 4 2023, 9:22 PM

Change 886413 merged by jenkins-bot:

[mediawiki/core@REL1_39] revisiondelete: Replace dynamic property Status::$itemStatuses

https://gerrit.wikimedia.org/r/886413

gerritbot added a comment.Feb 4 2023, 9:33 PM

Change 886415 merged by jenkins-bot:

[mediawiki/core@REL1_35] revisiondelete: Replace dynamic property Status::$itemStatuses

https://gerrit.wikimedia.org/r/886415

gerritbot added a comment.Feb 4 2023, 9:37 PM

Change 886414 merged by jenkins-bot:

[mediawiki/core@REL1_38] revisiondelete: Replace dynamic property Status::$itemStatuses

https://gerrit.wikimedia.org/r/886414

Reedy closed subtask T324894: Deprecated: Creation of dynamic property TransformTooBigImageAreaError::$tempFSFileReferences is deprecated in TempFSFile.php on line 135 as Resolved.Feb 21 2023, 9:49 PM
kostajh added a subtask: T330499: Deprecated: Creation of dynamic property MediaWiki\Minerva\Skins\SkinMinerva::$growthExperimentsHomepageDiscoveryNoticeSeen is deprecated includes/Homepage/SiteNoticeGenerator.php.Feb 24 2023, 1:29 PM
gerritbot added a comment.Mar 10 2023, 7:10 PM

Change 876281 abandoned by Umherirrender:

[mediawiki/core@master] tests: Suppress dynamic properties on PHP 8.2 for SerializationTestUtils

Reason:

Needs another approach

https://gerrit.wikimedia.org/r/876281

gerritbot added a comment.Mar 10 2023, 7:31 PM

Change 876315 merged by jenkins-bot:

[mediawiki/services/parsoid@master] Add AllowDynamicProperties to Wikimedia\Parsoid\DOM\Document

https://gerrit.wikimedia.org/r/876315

gerritbot added a comment.Mar 13 2023, 7:51 PM

Change 897971 had a related patch set uploaded (by Subramanya Sastry; author: Subramanya Sastry):

[mediawiki/vendor@master] Bump wikimedia/parsoid to 0.17.0-a21

https://gerrit.wikimedia.org/r/897971

Umherirrender unsubscribed.Mar 13 2023, 7:53 PM
gerritbot added a comment.Mar 13 2023, 8:13 PM

Change 897971 merged by jenkins-bot:

[mediawiki/vendor@master] Bump wikimedia/parsoid to 0.17.0-a21

https://gerrit.wikimedia.org/r/897971

Etonkovidova closed subtask T330499: Deprecated: Creation of dynamic property MediaWiki\Minerva\Skins\SkinMinerva::$growthExperimentsHomepageDiscoveryNoticeSeen is deprecated includes/Homepage/SiteNoticeGenerator.php as Resolved.Mar 21 2023, 9:21 PM
Maintenance_bot removed a project: Patch-For-Review.Mar 21 2023, 9:29 PM
Reedy added a subtask: T326454: Creation of dynamic property Mail_smtp::$greeting is deprecated.Oct 7 2023, 6:29 PM
Jdforrester-WMF closed subtask T326466: Rework database setup in integration test to avoid dynamic properties under php8.2 as Resolved.Nov 20 2023, 2:32 PM
Jdforrester-WMF mentioned this in T352085: Make PHP 8.2 voting on development (master) branch of MW ecosystem (core, vendor, extensions, skins, libraries).Nov 27 2023, 7:36 PM
Umherirrender closed subtask T326478: Rework auth/session related tests to avoid dynamic properties under php8.2 as Resolved.Nov 27 2023, 10:51 PM
Ammarpad closed subtask T326479: Replace dynamic property Status::$apiHookResult used by ApiEditPage and EditFilterMergedContentHook as Resolved.Nov 28 2023, 10:48 AM
Ammarpad reopened subtask T326479: Replace dynamic property Status::$apiHookResult used by ApiEditPage and EditFilterMergedContentHook as In Progress.
Ammarpad closed subtask T326479: Replace dynamic property Status::$apiHookResult used by ApiEditPage and EditFilterMergedContentHook as Resolved.Nov 28 2023, 2:45 PM
gerritbot added a comment.Dec 11 2023, 2:10 PM

Change 982092 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/services/parsoid@master] Add AllowDynamicProperties to Wikimedia\Parsoid\Ext\Gallery\Opts

https://gerrit.wikimedia.org/r/982092

gerritbot added a project: Patch-For-Review.Dec 11 2023, 2:10 PM
gerritbot added a comment.Dec 11 2023, 4:51 PM

Change 982123 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/WikibaseLexeme@master] tests: Declare class properties in test cases

https://gerrit.wikimedia.org/r/982123

gerritbot added a comment.Dec 11 2023, 4:51 PM

Change 982120 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/Wikibase@master] tests: Declare class properties in test cases

https://gerrit.wikimedia.org/r/982120

gerritbot added a comment.Dec 11 2023, 4:51 PM

Change 982126 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/WikibaseMediaInfo@master] tests: Declare class properties in MediaInfoRdfBuilderTest

https://gerrit.wikimedia.org/r/982126

gerritbot added a comment.Dec 11 2023, 6:02 PM

Change 982126 merged by jenkins-bot:

[mediawiki/extensions/WikibaseMediaInfo@master] tests: Declare class properties in MediaInfoRdfBuilderTest

https://gerrit.wikimedia.org/r/982126

gerritbot added a comment.Dec 11 2023, 6:02 PM

Change 982123 merged by jenkins-bot:

[mediawiki/extensions/WikibaseLexeme@master] tests: Declare class properties in test cases

https://gerrit.wikimedia.org/r/982123

ReleaseTaggerBot added a project: MW-1.42-notes (1.42.0-wmf.9; 2023-12-12).Dec 11 2023, 7:00 PM
gerritbot added a comment.Dec 11 2023, 9:30 PM

Change 982120 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] tests: Declare class properties in test cases

https://gerrit.wikimedia.org/r/982120

gerritbot added a comment.Dec 15 2023, 9:49 PM

Change 982092 merged by jenkins-bot:

[mediawiki/services/parsoid@master] Set default values explicit in Wikimedia\Parsoid\Ext\Gallery\Opts

https://gerrit.wikimedia.org/r/982092

Umherirrender mentioned this in T353570: Clean up old ParserCache serialization test cases.Dec 16 2023, 9:00 PM
gerritbot added a comment.Dec 18 2023, 6:51 PM

Change 983902 had a related patch set uploaded (by Subramanya Sastry; author: Subramanya Sastry):

[mediawiki/vendor@master] Bump wikimedia/parsoid to 0.19.0-a9

https://gerrit.wikimedia.org/r/983902

gerritbot added a comment.Dec 18 2023, 7:03 PM

Change 983907 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/services/parsoid@REL1_41] Set default values explicit in Wikimedia\Parsoid\Ext\Gallery\Opts

https://gerrit.wikimedia.org/r/983907

gerritbot added a comment.Dec 18 2023, 7:03 PM

Change 983908 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/services/parsoid@REL1_40] Set default values explicit in Wikimedia\Parsoid\Ext\Gallery\Opts

https://gerrit.wikimedia.org/r/983908

gerritbot added a comment.Dec 18 2023, 7:03 PM

Change 983909 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/services/parsoid@REL1_39] Set default values explicit in Wikimedia\Parsoid\Ext\Gallery\Opts

https://gerrit.wikimedia.org/r/983909

gerritbot added a comment.Dec 18 2023, 7:20 PM

Change 983909 merged by jenkins-bot:

[mediawiki/services/parsoid@REL1_39] Set default values explicit in Wikimedia\Parsoid\Ext\Gallery\Opts

https://gerrit.wikimedia.org/r/983909

gerritbot added a comment.Dec 18 2023, 7:21 PM

Change 983908 merged by jenkins-bot:

[mediawiki/services/parsoid@REL1_40] Set default values explicit in Wikimedia\Parsoid\Ext\Gallery\Opts

https://gerrit.wikimedia.org/r/983908

gerritbot added a comment.Dec 18 2023, 7:32 PM

Change 983907 merged by jenkins-bot:

[mediawiki/services/parsoid@REL1_41] Set default values explicit in Wikimedia\Parsoid\Ext\Gallery\Opts

https://gerrit.wikimedia.org/r/983907

gerritbot added a comment.Dec 18 2023, 9:17 PM

Change 983902 merged by jenkins-bot:

[mediawiki/vendor@master] Bump wikimedia/parsoid to 0.19.0-a9

https://gerrit.wikimedia.org/r/983902

Reedy added a subtask: T353644: PHP Deprecated: Creation of dynamic property Wikimedia\Parsoid\Html2Wt\SerializerState::$logType is deprecated.Dec 18 2023, 10:44 PM
Reedy added a subtask: T353163: Creation of dynamic property File_Ogg_Theora::$_firstGranulePos is deprecated.
Reedy added a subtask: T353161: [CLIENT] Creation of dynamic property MediaWiki\Title\Title::$wikibasePushedDeleteToRepo is deprecated.
Reedy added a subtask: T353184: Creation of dynamic property Wikibase\Lib\Store\EntityRevision::$user is deprecated.
Reedy added a subtask: T352679: HistoryBlobUtilsTest::testUnserializeBadEmbedded Creation of dynamic property HistoryBlobStub::$bad is deprecated.
Reedy added a subtask: T326182: Deprecated: Creation of dynamic property is deprecated.
Umherirrender closed subtask T353644: PHP Deprecated: Creation of dynamic property Wikimedia\Parsoid\Html2Wt\SerializerState::$logType is deprecated as Resolved.Jan 12 2024, 9:27 PM
Jdforrester-WMF closed subtask T353163: Creation of dynamic property File_Ogg_Theora::$_firstGranulePos is deprecated as Resolved.Jan 18 2024, 8:48 PM
Umherirrender closed subtask T353184: Creation of dynamic property Wikibase\Lib\Store\EntityRevision::$user is deprecated as Resolved.Jan 19 2024, 10:31 PM
cscott mentioned this in T272941: Make TemplateStyles extension compatible with Parsoid.Mar 1 2024, 10:35 PM
matmarex closed subtask T324903: Deprecated: Creation of dynamic properties in FlaggedRevs as Resolved.Mar 28 2024, 3:30 AM
gerritbot added a comment.Apr 6 2024, 1:32 AM

Change #1017468 had a related patch set uploaded (by Reedy; author: Umherirrender):

[mediawiki/services/parsoid@REL1_39] Add AllowDynamicProperties to Wikimedia\Parsoid\DOM\Document

https://gerrit.wikimedia.org/r/1017468

gerritbot added a comment.Apr 6 2024, 1:44 AM

Change #1017468 merged by jenkins-bot:

[mediawiki/services/parsoid@REL1_39] Add AllowDynamicProperties to Wikimedia\Parsoid\DOM\Document

https://gerrit.wikimedia.org/r/1017468

Physikerwelt mentioned this in T360709: Make PHP 8.2 voting on development (master) branch of Math extension.Apr 6 2024, 7:46 AM
gerritbot added a comment.Apr 6 2024, 7:57 AM

Change #1017425 had a related patch set uploaded (by Physikerwelt; author: Physikerwelt):

[mediawiki/extensions/Math@master] Declare properties statically

https://gerrit.wikimedia.org/r/1017425

gerritbot added a comment.Apr 6 2024, 9:29 PM

Change #1017425 merged by jenkins-bot:

[mediawiki/extensions/Math@master] Declare properties statically

https://gerrit.wikimedia.org/r/1017425

gerritbot added a comment.Apr 6 2024, 9:31 PM

Change #1017474 had a related patch set uploaded (by Reedy; author: Physikerwelt):

[mediawiki/extensions/Math@REL1_41] Declare properties statically

https://gerrit.wikimedia.org/r/1017474

gerritbot added a comment.Apr 6 2024, 9:33 PM

Change #1017475 had a related patch set uploaded (by Reedy; author: Physikerwelt):

[mediawiki/extensions/Math@REL1_40] Declare properties statically

https://gerrit.wikimedia.org/r/1017475

gerritbot added a comment.Apr 6 2024, 9:33 PM

Change #1017476 had a related patch set uploaded (by Reedy; author: Physikerwelt):

[mediawiki/extensions/Math@REL1_39] Declare properties statically

https://gerrit.wikimedia.org/r/1017476

gerritbot added a comment.Apr 6 2024, 9:34 PM

Change #1017476 abandoned by Reedy:

[mediawiki/extensions/Math@REL1_39] Declare properties statically

Reason:

https://gerrit.wikimedia.org/r/1017476

gerritbot added a comment.Apr 6 2024, 9:59 PM

Change #1017474 merged by jenkins-bot:

[mediawiki/extensions/Math@REL1_41] Declare properties statically

https://gerrit.wikimedia.org/r/1017474

gerritbot added a comment.Apr 6 2024, 10:03 PM

Change #1017475 merged by jenkins-bot:

[mediawiki/extensions/Math@REL1_40] Declare properties statically

https://gerrit.wikimedia.org/r/1017475

Jdforrester-WMF closed subtask T353161: [CLIENT] Creation of dynamic property MediaWiki\Title\Title::$wikibasePushedDeleteToRepo is deprecated as Resolved.Apr 26 2024, 6:19 PM
Maintenance_bot removed a project: Patch-For-Review.Apr 26 2024, 6:31 PM
Umherirrender added a subtask: T352814: Undefined/unused variable $request->base_string.Jun 30 2024, 7:14 PM
Tgr closed subtask T352814: Undefined/unused variable $request->base_string as Resolved.Jul 1 2024, 12:28 PM
Umherirrender added a subtask: T372356: LiquidThreads creates dynamic property OutputPage::mLqtReplacements.Aug 12 2024, 9:03 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits