Page MenuHomePhabricator

Move MessageCache::get hook to a separate hook handler
Closed, ResolvedPublic

Description

Hooks that might be called early in the request lifecycle (MessageCache::get is invoked whenever a message is parsed) should avoid dependencies on other services as much as possible, to reduce the risk of dependency cycles. Hence, moving onMessageCache__get away from HomepageHooks which has a ton of dependencies.

Event Timeline

kostajh triaged this task as Medium priority.Jul 28 2022, 7:57 PM
kostajh created this task.

Change 815687 had a related patch set uploaded (by Kosta Harlan; author: Gergő Tisza):

[mediawiki/extensions/GrowthExperiments@master] Move MessageCache::get hook to a separate hook handler

https://gerrit.wikimedia.org/r/815687

Change 815687 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] Move MessageCache::get hook to a separate hook handler

https://gerrit.wikimedia.org/r/815687

Change 825455 had a related patch set uploaded (by Gergő Tisza; author: Gergő Tisza):

[mediawiki/extensions/GrowthExperiments@master] Remove MessageCache::get hook handler from HomepageHooks

https://gerrit.wikimedia.org/r/825455

Tgr moved this task from QA to Code Review on the Growth-Team (Sprint 0 (Growth Team)) board.

Oops, I messed the patch a little.

Change 825455 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] Remove MessageCache::get hook handler from HomepageHooks

https://gerrit.wikimedia.org/r/825455