Page MenuHomePhabricator
Create Task
Maniphest T312922

🟥️ Create a new middleware to handle If-Match and If-Unmodified-Since headers
Closed, ResolvedPublic
Actions

Description

This will be similar to the middleware created for the corresponding if-none-match etc headers, and will respond with a 412 response if precondition fails.

Details

SubjectRepoBranchLines +/-
REST: Combine precondition middlewares into onemediawiki/extensions/Wikibasemaster+99 -190
REST: DRY up using PreconditionMiddlewareFactorymediawiki/extensions/Wikibasemaster+150 -85
REST: Use ModifiedPreconditionMiddlewaremediawiki/extensions/Wikibasemaster+178 -6
REST: Introduce ModifiedPreconditionMiddlewaremediawiki/extensions/Wikibasemaster+446 -162
Customize query in gerrit

Related Objects
Search...

Event Timeline

Jakob_WMDE created this task.Jul 13 2022, 10:26 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 13 2022, 10:26 AM
Jakob_WMDE claimed this task.Jul 25 2022, 8:16 AM
Jakob_WMDE moved this task from To Do to Doing on the Wikibase Product Platform (v1) (Sprint 10) board.
gerritbot added a comment.Jul 26 2022, 8:38 AM

Change 816809 had a related patch set uploaded (by Jakob; author: Jakob):

[mediawiki/extensions/Wikibase@master] REST: Introduce ModifiedPreconditionMiddleware

https://gerrit.wikimedia.org/r/816809

gerritbot added a project: Patch-For-Review.Jul 26 2022, 8:38 AM
gerritbot added a comment.Jul 27 2022, 8:42 AM

Change 817720 had a related patch set uploaded (by Jakob; author: Jakob):

[mediawiki/extensions/Wikibase@master] REST: Use ModifiedPreconditionMiddleware

https://gerrit.wikimedia.org/r/817720

Jakob_WMDE moved this task from Doing to Peer Review on the Wikibase Product Platform (v1) (Sprint 10) board.Jul 27 2022, 9:01 AM
WMDE-leszek edited projects, added Wikibase Product Platform (v1) (Sprint 11); removed Wikibase Product Platform (v1) (Sprint 10).Jul 27 2022, 9:17 AM
WMDE-leszek moved this task from To Do to Peer Review on the Wikibase Product Platform (v1) (Sprint 11) board.
gerritbot added a comment.Jul 27 2022, 10:15 AM

Change 817743 had a related patch set uploaded (by Jakob; author: Jakob):

[mediawiki/extensions/Wikibase@master] REST: DRY up using PreconditionMiddlewareFactory

https://gerrit.wikimedia.org/r/817743

gerritbot added a comment.Jul 28 2022, 2:00 PM

Change 816809 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] REST: Introduce ModifiedPreconditionMiddleware

https://gerrit.wikimedia.org/r/816809

ReleaseTaggerBot added a project: MW-1.39-notes (1.39.0-wmf.23; 2022-08-01).Jul 28 2022, 3:00 PM
gerritbot added a comment.Jul 29 2022, 8:15 AM

Change 817720 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] REST: Use ModifiedPreconditionMiddleware

https://gerrit.wikimedia.org/r/817720

gerritbot added a comment.Aug 1 2022, 11:03 AM

Change 819018 had a related patch set uploaded (by Jakob; author: Jakob):

[mediawiki/extensions/Wikibase@master] REST: Combine precondition middlewares into one

https://gerrit.wikimedia.org/r/819018

gerritbot added a comment.Aug 1 2022, 4:53 PM

Change 817743 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] REST: DRY up using PreconditionMiddlewareFactory

https://gerrit.wikimedia.org/r/817743

gerritbot added a comment.Aug 2 2022, 3:48 PM

Change 819018 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] REST: Combine precondition middlewares into one

https://gerrit.wikimedia.org/r/819018

ReleaseTaggerBot edited projects, added MW-1.39-notes (1.39.0-wmf.25; 2022-08-15); removed MW-1.39-notes (1.39.0-wmf.23; 2022-08-01).Aug 2 2022, 4:00 PM
Jakob_WMDE moved this task from Peer Review to Done on the Wikibase Product Platform (v1) (Sprint 11) board.Aug 2 2022, 4:06 PM
Maintenance_bot removed a project: Patch-For-Review.Aug 2 2022, 4:30 PM
Aklapper closed this task as Resolved.Oct 10 2022, 9:55 AM

@Jakob_WMDE: Assuming this task is resolved. Thus setting resolved task status. Please reopen and add an active project tag if that is not the case. Thanks.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits