| tstarling | |
| Apr 28 2022, 12:29 AM |
| F34933178: image.png | |
| Apr 28 2022, 12:29 AM |
| F34933175: image.png | |
| Apr 28 2022, 12:29 AM |
Update VisualEditor by analogy with the core EditPage changes for IP masking. When IP masking is enabled:
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| ApiEditPage: Create temporary account on edit attempt if enabled | mediawiki/core | master | +1 -0 |
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Restricted Task | |||||
| Resolved | kostajh | T294511 2021 Security Team wikireplicas audit | |||
| Declined | None | T284948 Raw IPs of logged-out users disclosed in wiki-replicas | |||
| In Progress | Niharika | T324492 Temporary accounts - MVP | |||
| Open | None | T326816 [Epic] Update features for temporary accounts | |||
| Resolved | ppelberg | T326876 Update Editing Team-owned products that may be affected by temporary users | |||
| Resolved | matmarex | T332435 Update VisualEditor for IP masking | |||
| Resolved | • lbowmaker | T262321 IP Masking | |||
| Resolved | tstarling | T300263 [IP Masking] Create temporary account on first edit | |||
| Duplicate | None | T307056 [IP Masking] Temporary account VisualEditor support |
Change 837131 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):
[mediawiki/core@master] ApiEditPage: Create temporary account on edit attempt if enabled
@Ladsgroup asked me to figure out why the minimal IP masking functionality wasn't working in VE (edits would still be attributed to your IP address rather than a temporary account). I found that the function implementing this was not called when saving using the API. This patch seems to work for me, but I wonder if this is the approach you intended @tstarling? You wrote "Acquire a temporary name…" and I'm wondering if you meant to add a separate API module for "logging into" a temporary account or something.
(I'm not currently working on any of the interface changes required for this, just this tiny patch.)
Change 837131 merged by jenkins-bot:
[mediawiki/core@master] ApiEditPage: Create temporary account on edit attempt if enabled
The basic issue (edits being saved under IP when edits are done with VE) is now fixed: https://de.wikipedia.beta.wmflabs.org/w/index.php?title=Dreimal_Lorem_ipsum_(indicator)&diff=30316&oldid=14515
The rest is needed but I think it's pretty good already ^_^
I'll merge this into T332435, where I've started working on updating VisualEditor for IP masking.