Page MenuHomePhabricator
Create Task
Maniphest T305066

Make extended annotation ranges uneditable
Closed, ResolvedPublicFeature
Actions

Description

When an annotation range is extended, the corresponding range should not be editable in VisualEditor.

Details

SubjectRepoBranchLines +/-
Making Translate extended ranges uneditablemediawiki/services/parsoidmaster+200 -123
Bump wikimedia/parsoid to 0.16.0-a5mediawiki/vendormaster+556 -2 K
Making Translate extended ranges uneditable - fixing bugsmediawiki/services/parsoidREL1_38+76 -70
Making Translate extended ranges uneditablemediawiki/services/parsoidREL1_38+247 -100
Making Translate extended ranges uneditable - fixing bugsmediawiki/services/parsoidmaster+76 -70
Customize query in gerrit

Related Objects
Search...

StatusSubtypeAssignedTask
 OpenReleaseNoneT84936 Release VisualEditor-MediaWiki as "1.0"
 OpenNoneT50429 [Epic] Support editing parts of a page in VisualEditor-MediaWiki
 OpenNoneT54365 Explore performance gains from progressive (JIT?) de-alienation in VisualEditor
 OpenNoneT174303 Copy-pasting linked ISBN numbers from view mode HTML into VisualEditor inserts wikitext links to Special:BookSources (it should turn them into magic links?)
 OpenFeatureNoneT54091 The read HTML should have hinting to allow full DOM copying (as opposed to just rich copying) from read mode into VE surfaces
 OpenNoneT55784 [EPIC] Use Parsoid HTML for all page views
 OpenNoneT258838 [EPIC] Ensure all extensions on the Wikimedia cluster that use Parser hooks or implement tag hooks are retargeted for Parsoid
 OpenNoneT351374 Improve Translatable Pages based on research input
 OpenNoneT131516 Reduce or eliminate the need for the user to touch <translate> tags and unit markers
 OpenNoneT143327 Make the Translate extension be based on DOM, not strings
 ResolvedEsandersT73730 VisualEditor: Content inside templates for translation of templates does not render in friendly ways
 OpenFeatureNoneT55974 Create a VisualEditor plugin tool to add/edit translations and translation variables (Translate extension)
 ResolvedihurbainT261172 Much content is missing when editing a translatable page
 ResolvedihurbainT261181 Make Translate extension compatible with Parsoid
 ResolvedFeatureihurbainT305066 Make extended annotation ranges uneditable
 ResolvedBUG REPORTmatmarexT303298 mw:Placeholder elements are editable in VE

Event Timeline

ihurbain created this task.Mar 30 2022, 1:56 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 30 2022, 1:56 PM
ihurbain added a parent task: T261181: Make Translate extension compatible with Parsoid.Mar 30 2022, 1:56 PM
ihurbain added a subtask: T303298: mw:Placeholder elements are editable in VE.
ihurbain added a project: MW-1.38-release.
gerritbot added a comment.Mar 30 2022, 1:59 PM

Change 769071 had a related patch set uploaded (by Isabelle Hurbain-Palatin; author: Isabelle Hurbain-Palatin):

[mediawiki/services/parsoid@master] Making Translate extended ranges uneditable

https://gerrit.wikimedia.org/r/769071

gerritbot added a project: Patch-For-Review.Mar 30 2022, 1:59 PM
gerritbot added a comment.Apr 1 2022, 5:14 PM

Change 769071 merged by jenkins-bot:

[mediawiki/services/parsoid@master] Making Translate extended ranges uneditable

https://gerrit.wikimedia.org/r/769071

Maintenance_bot removed a project: Patch-For-Review.Apr 1 2022, 6:10 PM
ppelberg closed subtask T303298: mw:Placeholder elements are editable in VE as Resolved.Apr 2 2022, 12:57 AM
gerritbot added a comment.Apr 4 2022, 5:15 PM

Change 776976 had a related patch set uploaded (by Isabelle Hurbain-Palatin; author: Isabelle Hurbain-Palatin):

[mediawiki/services/parsoid@master] WIP - Making Translate extended ranges uneditable

https://gerrit.wikimedia.org/r/776976

gerritbot added a project: Patch-For-Review.Apr 4 2022, 5:15 PM
MarkAHershberger removed a project: MW-1.38-release.Apr 7 2022, 12:24 PM
MarkAHershberger subscribed.Apr 7 2022, 12:29 PM

Removing from 1.38 since

  • we've already forked,
  • this isn't done yet, and
  • this should not block the release of 1.38.
ssastry subscribed.Apr 7 2022, 2:19 PM

@MarkAHershberger, @ihurbain is working hard to wrap up these final pieces that would improve VE support for translate tags and we hope to have this final piece done next week. If possible, we would still like to have those fixes be backported to 1.38 but agree that we shouldn't make these a blocker. It is not the end of the world to have the fixes go in 1.39. But, if we aren't doing a final release next week, is it okay to try and target these fixes for 1.38?

MarkAHershberger added a project: MW-1.38-release.Apr 7 2022, 2:22 PM
MarkAHershberger moved this task from Blocker to Not a blocker on the MW-1.38-release board.

@ssastry ok, I've replaced the tag but moved it to not a blocker.

ssastry added a comment.Apr 7 2022, 2:25 PM

Perfect! Thanks!

gerritbot added a comment.Apr 7 2022, 5:35 PM

Change 776976 merged by jenkins-bot:

[mediawiki/services/parsoid@master] Making Translate extended ranges uneditable - fixing bugs

https://gerrit.wikimedia.org/r/776976

Maintenance_bot removed a project: Patch-For-Review.Apr 7 2022, 6:30 PM
gerritbot added a comment.Apr 8 2022, 10:09 AM

Change 778482 had a related patch set uploaded (by Isabelle Hurbain-Palatin; author: Isabelle Hurbain-Palatin):

[mediawiki/services/parsoid@REL1_38] Making Translate extended ranges uneditable

https://gerrit.wikimedia.org/r/778482

gerritbot added a project: Patch-For-Review.Apr 8 2022, 10:09 AM

Change 778483 had a related patch set uploaded (by Isabelle Hurbain-Palatin; author: Isabelle Hurbain-Palatin):

[mediawiki/services/parsoid@REL1_38] Making Translate extended ranges uneditable - fixing bugs

https://gerrit.wikimedia.org/r/778483

gerritbot added a comment.Apr 9 2022, 6:09 AM

Change 778482 merged by jenkins-bot:

[mediawiki/services/parsoid@REL1_38] Making Translate extended ranges uneditable

https://gerrit.wikimedia.org/r/778482

gerritbot added a comment.Apr 9 2022, 6:15 AM

Change 778483 merged by jenkins-bot:

[mediawiki/services/parsoid@REL1_38] Making Translate extended ranges uneditable - fixing bugs

https://gerrit.wikimedia.org/r/778483

Maintenance_bot removed a project: Patch-For-Review.Apr 9 2022, 6:30 AM
gerritbot added a comment.Apr 11 2022, 6:17 PM

Change 779085 had a related patch set uploaded (by Subramanya Sastry; author: Subramanya Sastry):

[mediawiki/vendor@master] Bump wikimedia/parsoid to 0.16.0-a5

https://gerrit.wikimedia.org/r/779085

gerritbot added a project: Patch-For-Review.Apr 11 2022, 6:17 PM
gerritbot added a comment.Apr 11 2022, 7:06 PM

Change 779085 merged by jenkins-bot:

[mediawiki/vendor@master] Bump wikimedia/parsoid to 0.16.0-a5

https://gerrit.wikimedia.org/r/779085

Maintenance_bot removed a project: Patch-For-Review.Apr 11 2022, 7:31 PM
ssastry closed this task as Resolved.Apr 22 2022, 5:23 AM
ssastry assigned this task to ihurbain.
ssastry triaged this task as Medium priority.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits