Page MenuHomePhabricator
Create Task
Maniphest T304168

Allow ToC to appear on all namespaces for testing purposes
Closed, ResolvedPublic2 Estimated Story Points
Actions

Assigned To
ovasileva
Authored By
ovasileva
Mar 18 2022, 3:23 PM
Tags
Referenced Files
F35047064: Screen Shot 2022-04-11 at 9.57.13 AM.png
Apr 11 2022, 5:01 PM
F35047068: Screen Shot 2022-04-11 at 9.57.58 AM.png
Apr 11 2022, 5:01 PM
F35047066: Screen Shot 2022-04-11 at 9.57.41 AM.png
Apr 11 2022, 5:01 PM
F35038460: Screen Recording 2022-04-04 at 3.54.06 PM.mov.gif
Apr 4 2022, 10:57 PM
F35038465: Screen Recording 2022-04-04 at 3.54.58 PM.mov.gif
Apr 4 2022, 10:57 PM
F35038462: Screen Recording 2022-04-04 at 3.54.25 PM.mov.gif
Apr 4 2022, 10:57 PM
F35037746: Screen Shot 2022-04-04 at 12.19.05 PM.png
Apr 4 2022, 10:20 AM
Subscribers
Aklapper
cjming
Edtadros
Jdlrobson
ovasileva

Description

Background

We would like to test the table of contents across all namespaces so that we can determine what specific use cases we need to account for across namespaces and projects

Acceptance criteria

  • Turn on ToC across all namespaces so that we can QA in production using the url parameter

QA steps

QA Results - Beta

ACStatusDetails
1✅T304168#7830273

QA Results - Prod

ACStatusDetails
1✅T304168#7845777

Details

SubjectRepoBranchLines +/-
Enable table of contents on all namespacesmediawiki/skins/Vectormaster+1 -2
Customize query in gerrit

Related Objects
Search...

Event Timeline

ovasileva created this task.Mar 18 2022, 3:23 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 18 2022, 3:23 PM
ovasileva triaged this task as High priority.Mar 18 2022, 3:23 PM
ovasileva moved this task from Incoming to Table of Contents on the Desktop Improvements (Vector 2022) board.
ovasileva added a parent task: T273473: [Epic] Improve the table of contents.
ovasileva added a parent task: T304169: [Goal] Begin table of contents A/B test.Mar 18 2022, 3:28 PM
Jdlrobson moved this task from Needs Analysis to Upcoming on the Web-Team-Backlog (Kanbanana-FY-2021-22) board.Mar 23 2022, 12:16 AM
Jdlrobson subscribed.

Relaxing the logic in SkinVector22:isTableOfContentsVisibleInSidebar is all that's needed here.

gerritbot added a comment.Mar 24 2022, 3:57 PM

Change 773575 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/skins/Vector@master] Enable table of contents on all namespaces

https://gerrit.wikimedia.org/r/773575

gerritbot added a project: Patch-For-Review.Mar 24 2022, 3:57 PM
LGoto moved this task from Upcoming to Ready for Development on the Web-Team-Backlog (Kanbanana-FY-2021-22) board.Mar 28 2022, 5:48 PM
LGoto set the point value for this task to 2.
Jdlrobson moved this task from Ready for Development to Code Review on the Web-Team-Backlog (Kanbanana-FY-2021-22) board.Mar 28 2022, 5:48 PM
LGoto assigned this task to cjming.Mar 29 2022, 5:07 PM
cjming reassigned this task from cjming to Edtadros.Mar 29 2022, 9:17 PM
cjming moved this task from Code Review to QA on the Web-Team-Backlog (Kanbanana-FY-2021-22) board.
cjming subscribed.
gerritbot added a comment.Mar 29 2022, 9:34 PM

Change 773575 merged by jenkins-bot:

[mediawiki/skins/Vector@master] Enable table of contents on all namespaces

https://gerrit.wikimedia.org/r/773575

ReleaseTaggerBot added a project: MW-1.39-notes (1.39.0-wmf.6; 2022-04-04).Mar 29 2022, 10:00 PM
Maintenance_bot removed a project: Patch-For-Review.Mar 29 2022, 10:10 PM
cjming added a comment.Mar 29 2022, 10:50 PM

hi @Jdlrobson -- I didn't test this thoroughly enough before my trigger-happy merging. I am trying to verify on beta cluster that this is working properly but I haven't yet encountered a non-main namespace page where I can see the new TOC. Is there something I'm missing in terms of config or page content to see it?

ovasileva added a comment.Mar 30 2022, 7:28 AM

Can confirm it's there on https://en.wikipedia.beta.wmflabs.org/wiki/Talk:Dog.

cjming added a comment.Mar 30 2022, 3:06 PM
In T304168#7817086, @ovasileva wrote:

Can confirm it's there on https://en.wikipedia.beta.wmflabs.org/wiki/Talk:Dog.

thanks for confirming @ovasileva !

cjming updated the task description. (Show Details)Mar 30 2022, 3:08 PM
Jdlrobson added a comment.Mar 30 2022, 3:37 PM

Also on https://en.wikipedia.beta.wmflabs.org/wiki/Talk:Cats if you are a cat person.

ovasileva added a comment.Apr 4 2022, 10:20 AM

Screen Shot 2022-04-04 at 12.19.05 PM.png (1×1 px, 360 KB)
huh, oddly enough I don't see it on https://en.wikipedia.beta.wmflabs.org/wiki/Talk:Cats

Edtadros moved this task from QA to QA in Prod on the Web-Team-Backlog (Kanbanana-FY-2021-22) board.Apr 4 2022, 10:57 PM

Test Result - Beta

Status: ✅ PASS
Environment: beta
OS: macOS Monterey
Browser: Chrome
Device: MBP
Emulated Device:NA

Test Artifact(s):

QA Steps

✅ AC1: Navigate to a special page on beta cluster to see new sticky TOC in sidebar (click on hamburger menu to toggle menus)
https://en.wikipedia.beta.wmflabs.org/wiki/Talk:Albert_Einstein

Screen Recording 2022-04-04 at 3.54.06 PM.mov.gif (1×1 px, 247 KB)

https://en.wikipedia.beta.wmflabs.org/wiki/Talk:Dog
Screen Recording 2022-04-04 at 3.54.25 PM.mov.gif (1×1 px, 336 KB)

https://en.wikipedia.beta.wmflabs.org/wiki/Talk:Cats
@ovasileva, it showed up for me.
Screen Recording 2022-04-04 at 3.54.58 PM.mov.gif (1×1 px, 442 KB)

Edtadros reassigned this task from Edtadros to ovasileva.Apr 11 2022, 5:01 PM
Edtadros moved this task from QA in Prod to Ready for Signoff on the Web-Team-Backlog (Kanbanana-FY-2021-22) board.
Edtadros subscribed.

Test Result - Prod

Status: ✅ PASS
Environment: enwiki
OS: macOS Monterey
Browser: Chrome
Device: MBP
Emulated Device:NA

Test Artifact(s):

QA Steps

✅ AC1: Navigate to a special page on beta cluster to see new sticky TOC in sidebar (click on hamburger menu to toggle menus)
https://en.wikipedia.org/wiki/Talk:Albert_Einstein?tableofcontents=1

Screen Shot 2022-04-11 at 9.57.13 AM.png (491×863 px, 106 KB)

https://en.wikipedia.org/wiki/Talk:Dog?tableofcontents=1
Screen Shot 2022-04-11 at 9.57.41 AM.png (638×707 px, 121 KB)

https://en.wikipedia.org/wiki/Talk:Cats?tableofcontents=1
Screen Shot 2022-04-11 at 9.57.58 AM.png (565×747 px, 117 KB)

Edtadros updated the task description. (Show Details)Apr 11 2022, 5:02 PM
ovasileva closed this task as Resolved.Apr 12 2022, 9:34 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits