Page MenuHomePhabricator
Create Task
Maniphest T295605

Documentation: Designing tokens
Closed, ResolvedPublic
Actions

Description

Background

We need to document the process to design system tokens. This documentation will be added in the "Contributing" section of the Codex demo.

Previous documentation
  • Designing Tokens in this doc
  • Please note that the "Designing components" documentation in T312023 also contains a section describing how to use tokens for the component's specification.
User stories
  • As a designer I need to know how to design tokens for Codex.
  • As a designer I need to understand the difference between option and decision tokens.
Documentation
Documentation in this Notion page

Acceptance criteria (or Done)

Details

SubjectRepoBranchLines +/-
Update Codex from v0.4.0 to v0.4.2mediawiki/coremaster+72 -72
docs: Add “Designing tokens” documentationdesign/codexmain+107 -0
docs: Restructure tokens overview documentation and inter-linkdesign/codexmain+51 -23
tokens: Refactor and structure design tokensdesign/codexmain+891 -238
Customize query in gerrit

Related Objects
Search...

Event Timeline

• iamjessklein created this task.Nov 12 2021, 2:43 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptNov 12 2021, 2:43 PM
• iamjessklein mentioned this in T293127: [EPIC] Design System Foundation: Design and define design tokens.Nov 12 2021, 2:46 PM
• iamjessklein added a parent task: T293127: [EPIC] Design System Foundation: Design and define design tokens.Nov 12 2021, 3:29 PM
• Sarai-WMDE updated the task description. (Show Details)Nov 12 2021, 6:28 PM
• iamjessklein updated the task description. (Show Details)Nov 18 2021, 6:17 PM
• Sarai-WMDE renamed this task from Draft documentation on design tokens to Create documentation on design tokens.Nov 22 2021, 7:24 PM
gerritbot added a comment.Dec 7 2021, 2:03 AM

Change 739394 had a related patch set uploaded (by VolkerE; author: VolkerE):

[design/codex@main] tokens: Refactor and structure design tokens

https://gerrit.wikimedia.org/r/739394

gerritbot added a project: Patch-For-Review.Dec 7 2021, 2:03 AM
gerritbot added a comment.Dec 15 2021, 11:45 PM

Change 739394 merged by jenkins-bot:

[design/codex@main] tokens: Refactor and structure design tokens

https://gerrit.wikimedia.org/r/739394

Volker_E mentioned this in rDCOD1a3b12451036: tokens: Refactor and structure design tokens.Dec 15 2021, 11:45 PM
Maintenance_bot removed a project: Patch-For-Review.Dec 16 2021, 12:11 AM
Volker_E added a project: Documentation.Mar 12 2022, 7:43 PM
Aklapper added a project: Design-System-Team.Apr 25 2022, 11:30 AM

Adding Design-System-Team because Design-Systems-team-20200324-20220422 got archived though this open task has no other active project tags associated, so it cannot be found on boards.

• STH moved this task from Inbox to Backlog on the Design-System-Team board.Apr 30 2022, 4:36 PM
• STH mentioned this in T295603: Define and document protocol – for designing future tokens .
• STH triaged this task as Medium priority.May 1 2022, 1:21 PM
• iamjessklein added a comment.May 2 2022, 4:56 PM

This documentation should include some instructive documentation about what to do if you are a designer and want to fix or make a new token.

gerritbot added a comment.May 26 2022, 1:58 AM

Change 799434 had a related patch set uploaded (by VolkerE; author: VolkerE):

[design/codex@main] docs: Restructure tokens overview documentation and inter-link

https://gerrit.wikimedia.org/r/799434

gerritbot added a project: Patch-For-Review.May 26 2022, 1:58 AM
gerritbot added a comment.May 26 2022, 10:23 PM

Change 799434 merged by jenkins-bot:

[design/codex@main] docs: Restructure tokens overview documentation and inter-link

https://gerrit.wikimedia.org/r/799434

Volker_E mentioned this in T297003: Define the system's box shadow styles.Aug 2 2022, 10:21 AM
• Sarai-WMDE mentioned this in T313905: Governance & Guidelines: Publish Guidelines & Documentation required for Design System Contribution V1.Sep 6 2022, 5:17 PM
bmartinezcalvo renamed this task from Create documentation on design tokens to [DESIGN] Documentation: Designing tokens.Oct 26 2022, 9:48 AM
bmartinezcalvo claimed this task.
bmartinezcalvo removed a project: Design-Systems-team-20200324-20220422 (Design Systems Team FY2021-22 Kanban Board).
bmartinezcalvo updated the task description. (Show Details)
bmartinezcalvo edited projects, added Design, Design-System-Team (Design-System-Sprint); removed Design-System-Team.
bmartinezcalvo edited subscribers, added: Volker_E, bmartinezcalvo; removed: • iamjessklein, Aklapper.

Moving to the sprint since I'm working on it.

bmartinezcalvo moved this task from Committed to Design Review on the Design-System-Team (Design-System-Sprint) board.Oct 26 2022, 9:51 AM

The "Designing Tokens" process has been documented in this Notion and is pending from feedback @Volker_E @Sarai-WMDE

bmartinezcalvo updated the task description. (Show Details)Oct 26 2022, 9:52 AM
Volker_E moved this task from Design Review to Ready for Development on the Design-System-Team (Design-System-Sprint) board.Dec 7 2022, 2:26 AM
Volker_E removed a project: Patch-For-Review.Dec 7 2022, 11:02 AM
gerritbot added a comment.Dec 7 2022, 12:10 PM

Change 865616 had a related patch set uploaded (by VolkerE; author: VolkerE):

[design/codex@main] docs: Add “Designing tokens documentation

https://gerrit.wikimedia.org/r/865616

gerritbot added a project: Patch-For-Review.Dec 7 2022, 12:10 PM
Volker_E moved this task from Ready for Development to Code Review on the Design-System-Team (Design-System-Sprint) board.Dec 7 2022, 12:39 PM
Volker_E renamed this task from [DESIGN] Documentation: Designing tokens to Documentation: Designing tokens.Dec 8 2022, 9:46 PM
Volker_E removed a project: Patch-For-Review.Dec 13 2022, 7:45 PM
Volker_E updated the task description. (Show Details)
Volker_E moved this task from Code Review to Design Sign-Off on the Design-System-Team (Design-System-Sprint) board.
gerritbot added a comment.Dec 13 2022, 7:49 PM

Change 865616 merged by jenkins-bot:

[design/codex@main] docs: Add “Designing tokens” documentation

https://gerrit.wikimedia.org/r/865616

gerritbot added a comment.Dec 13 2022, 10:53 PM

Change 867727 had a related patch set uploaded (by Anne Tomasevich; author: Anne Tomasevich):

[mediawiki/core@master] Update Codex from v0.4.0 to v0.4.1

https://gerrit.wikimedia.org/r/867727

gerritbot added a project: Patch-For-Review.Dec 13 2022, 10:53 PM
PatchDemoBot added a comment.Dec 13 2022, 10:55 PM

Test wiki created on Patch demo by ATomasevich (WMF) using patch(es) linked to this task:
https://patchdemo.wmflabs.org/wikis/cb9ffaffec/w

gerritbot added a comment.Dec 14 2022, 12:11 AM

Change 867727 merged by jenkins-bot:

[mediawiki/core@master] Update Codex from v0.4.0 to v0.4.2

https://gerrit.wikimedia.org/r/867727

bmartinezcalvo moved this task from Design Sign-Off to QTE Sign-off on the Design-System-Team (Design-System-Sprint) board.Dec 14 2022, 10:54 AM

Design sign-off done. All looks good to me.

PatchDemoBot added a comment.Dec 14 2022, 6:04 PM

Test wiki on Patch demo by ATomasevich (WMF) using patch(es) linked to this task was deleted:

https://patchdemo.wmflabs.org/wikis/cb9ffaffec/w/

• EUdoh-WMF moved this task from QTE Sign-off to Product Sign-Off on the Design-System-Team (Design-System-Sprint) board.Dec 15 2022, 8:54 PM
• EUdoh-WMF subscribed.

Hi @bmartinezcalvo, a question - there are still some open comments on the Notion Doc. Would they be resolved or are still waiting for some action to be taken?

I will move this now for sign-off.

• EUdoh-WMF reassigned this task from bmartinezcalvo to • DAbad.Dec 15 2022, 9:14 PM
bmartinezcalvo added a comment.Dec 16 2022, 9:15 AM
In T295605#8472116, @EUdoh-WMF wrote:

Hi @bmartinezcalvo, a question - there are still some open comments on the Notion Doc. Would they be resolved or are still waiting for some action to be taken?

@EUdoh-WMF checked comments, they were old so I've solved them.

ldelench_wmf closed this task as Resolved.Jan 27 2023, 4:08 PM
ldelench_wmf subscribed.

https://doc.wikimedia.org/codex/latest/contributing/designing-tokens.html

Maintenance_bot removed a project: Patch-For-Review.Jan 27 2023, 4:31 PM
bmartinezcalvo mentioned this in T312019: Document all our contribution flows.Feb 14 2024, 10:59 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits