Page MenuHomePhabricator
Create Task
Maniphest T286611

TypeError: Return value of JsonSchemaHooks::onEditFilterMergedContent() must be of the type boolean, none returned
Closed, ResolvedPublicPRODUCTION ERROR
Actions

Description

Error
normalized_message
[{reqId}] {exception_url}   TypeError: Return value of JsonSchemaHooks::onEditFilterMergedContent() must be of the type boolean, none returned
exception.trace
from /srv/mediawiki/php-1.37.0-wmf.12/extensions/EventLogging/includes/JsonSchemaHooks.php(104)
#0 /srv/mediawiki/php-1.37.0-wmf.12/includes/HookContainer/HookContainer.php(338): JsonSchemaHooks::onEditFilterMergedContent(DerivativeContext, JsonSchemaContent, Status, string, User, boolean)
#1 /srv/mediawiki/php-1.37.0-wmf.12/includes/HookContainer/HookContainer.php(137): MediaWiki\HookContainer\HookContainer->callLegacyHook(string, array, array, array)
#2 /srv/mediawiki/php-1.37.0-wmf.12/includes/HookContainer/HookRunner.php(1495): MediaWiki\HookContainer\HookContainer->run(string, array)
#3 /srv/mediawiki/php-1.37.0-wmf.12/includes/editpage/Constraint/EditFilterMergedContentHookConstraint.php(90): MediaWiki\HookContainer\HookRunner->onEditFilterMergedContent(DerivativeContext, JsonSchemaContent, Status, string, User, boolean)
#4 /srv/mediawiki/php-1.37.0-wmf.12/includes/editpage/Constraint/EditConstraintRunner.php(88): MediaWiki\EditPage\Constraint\EditFilterMergedContentHookConstraint->checkConstraint()
#5 /srv/mediawiki/php-1.37.0-wmf.12/includes/EditPage.php(2270): MediaWiki\EditPage\Constraint\EditConstraintRunner->checkConstraints()
#6 /srv/mediawiki/php-1.37.0-wmf.12/includes/EditPage.php(1689): EditPage->internalAttemptSave(NULL, boolean)
#7 /srv/mediawiki/php-1.37.0-wmf.12/includes/EditPage.php(665): EditPage->attemptSave(NULL)
#8 /srv/mediawiki/php-1.37.0-wmf.12/includes/actions/EditAction.php(71): EditPage->edit()
#9 /srv/mediawiki/php-1.37.0-wmf.12/includes/actions/SubmitAction.php(38): EditAction->show()
#10 /srv/mediawiki/php-1.37.0-wmf.12/includes/MediaWiki.php(536): SubmitAction->show()
#11 /srv/mediawiki/php-1.37.0-wmf.12/includes/MediaWiki.php(320): MediaWiki->performAction(Article, Title)
#12 /srv/mediawiki/php-1.37.0-wmf.12/includes/MediaWiki.php(917): MediaWiki->performRequest()
#13 /srv/mediawiki/php-1.37.0-wmf.12/includes/MediaWiki.php(551): MediaWiki->main()
#14 /srv/mediawiki/php-1.37.0-wmf.12/index.php(53): MediaWiki->run()
#15 /srv/mediawiki/php-1.37.0-wmf.12/index.php(46): wfIndexMain()
#16 /srv/mediawiki/w/index.php(3): require(string)
#17 {main}
Impact
Notes

Details

Request URL
https://meta.wikimedia.org/w/index.php?title=*&action=submit
SubjectRepoBranchLines +/-
Add return value for the case of no exceptionmediawiki/extensions/EventLoggingwmf/1.37.0-wmf.14+1 -0
Add return value for the case of no exceptionmediawiki/extensions/EventLoggingwmf/1.37.0-wmf.12+1 -0
Add return value for the case of no exceptionmediawiki/extensions/EventLoggingmaster+1 -0
Customize query in gerrit

Related Objects

Event Timeline

dancy created this task.Jul 13 2021, 8:37 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 13 2021, 8:37 PM
Aklapper added a project: MediaWiki-extensions-EventLogging.Jul 13 2021, 9:13 PM

Assuming this is about MediaWiki-extensions-EventLogging

Restricted Application added a project: Analytics. · View Herald TranscriptJul 13 2021, 9:13 PM
Ammarpad subscribed.Jul 14 2021, 9:59 AM

Caused by https://gerrit.wikimedia.org/r/c/mediawiki/extensions/EventLogging/+/680364

Krinkle moved this task from Untriaged to July 2021 on the Wikimedia-production-error board.Jul 14 2021, 6:39 PM
Krinkle added subscribers: Func, matmarex, Krinkle.Jul 14 2021, 6:43 PM

Fall out from T280312. \cc @Func, @matmarex

gerritbot added a comment.Jul 14 2021, 10:08 PM

Change 704635 had a related patch set uploaded (by Zabe; author: Zabe):

[mediawiki/extensions/EventLogging@master] Add return value for the case of no exception

https://gerrit.wikimedia.org/r/704635

gerritbot added a project: Patch-For-Review.Jul 14 2021, 10:08 PM
Zabe subscribed.Jul 14 2021, 10:08 PM
gerritbot added a comment.Jul 15 2021, 1:30 PM

Change 704635 merged by jenkins-bot:

[mediawiki/extensions/EventLogging@master] Add return value for the case of no exception

https://gerrit.wikimedia.org/r/704635

ReleaseTaggerBot added a project: MW-1.37-notes (1.37.0-wmf.15; 2021-07-19).Jul 15 2021, 2:00 PM
Maintenance_bot removed a project: Patch-For-Review.Jul 15 2021, 2:10 PM
Zabe closed this task as Resolved.Jul 15 2021, 2:12 PM
Zabe claimed this task.
Zabe added a project: User-Zabe.

This should be fixed in wmf.15.

matmarex added a comment.Jul 15 2021, 4:21 PM

I'll backport it today, this bug is causing some pages to be impossible to edit (e.g. the entire 'Schema' namespace on meta.wikimedia.org).

gerritbot added a comment.Jul 15 2021, 4:23 PM

Change 704811 had a related patch set uploaded (by Zabe; author: Zabe):

[mediawiki/extensions/EventLogging@wmf/1.37.0-wmf.12] Add return value for the case of no exception

https://gerrit.wikimedia.org/r/704811

gerritbot added a project: Patch-For-Review.Jul 15 2021, 4:23 PM

Change 704812 had a related patch set uploaded (by Zabe; author: Zabe):

[mediawiki/extensions/EventLogging@wmf/1.37.0-wmf.14] Add return value for the case of no exception

https://gerrit.wikimedia.org/r/704812

matmarex added a comment.Jul 15 2021, 5:00 PM

THanks for preparing these, scheduled: https://wikitech.wikimedia.org/wiki/Deployments#deploycal-item-20210715T1800

gerritbot added a comment.Jul 15 2021, 6:27 PM

Change 704811 merged by jenkins-bot:

[mediawiki/extensions/EventLogging@wmf/1.37.0-wmf.12] Add return value for the case of no exception

https://gerrit.wikimedia.org/r/704811

gerritbot added a comment.Jul 15 2021, 6:27 PM

Change 704812 merged by jenkins-bot:

[mediawiki/extensions/EventLogging@wmf/1.37.0-wmf.14] Add return value for the case of no exception

https://gerrit.wikimedia.org/r/704812

Stashbot added a comment.Jul 15 2021, 6:34 PM

Mentioned in SAL (#wikimedia-operations) [2021-07-15T18:34:13Z] <reedy@deploy1002> Synchronized php-1.37.0-wmf.12/extensions/EventLogging/includes/JsonSchemaHooks.php: T286611 (duration: 01m 07s)

Stashbot added a comment.Jul 15 2021, 6:35 PM

Mentioned in SAL (#wikimedia-operations) [2021-07-15T18:35:26Z] <reedy@deploy1002> Synchronized php-1.37.0-wmf.14/extensions/EventLogging/includes/JsonSchemaHooks.php: T286611 (duration: 01m 06s)

ReleaseTaggerBot edited projects, added MW-1.37-notes (1.37.0-wmf.14; 2021-07-12); removed MW-1.37-notes (1.37.0-wmf.15; 2021-07-19).Jul 15 2021, 7:00 PM
Maintenance_bot removed a project: Patch-For-Review.Jul 15 2021, 7:10 PM
Zabe removed a project: User-Zabe.Apr 13 2022, 12:48 AM
Restricted Application added a project: Data-Engineering. · View Herald TranscriptApr 13 2022, 12:48 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits