Seems we forgot this. when writing about T230786, I noticed that this didn't actually show the language name in English. Similarly the language name on items is in Spanish, not English, despite uselang=en .
It's the addition of a name for a termbox language, accordingly langcom review isn't needed.
Proposed fix:
Thus, please create patch for adding:
Tentative fix (July 19):
add "es-419" to "LocalNamesDe" with German name
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| Add es-419 for German | mediawiki/extensions/cldr | master | +2 -0 | |
| Add missing language name for es-419 | mediawiki/extensions/cldr | master | +1 -0 |
There is already an English name, as you can see in the language list on https://www.wikidata.org/wiki/Special:NewItem
It's not just in edit summaries, also items don't display the language name: see https://www.wikidata.org/wiki/Q56649449?uselang=en currently reads "español de América Latina"
It's actually missing in LocalNamesEn which probably explains why we get the Spanish version.
Change 705158 had a related patch set uploaded (by Mbch331; author: Mbch331):
[mediawiki/extensions/cldr@master] Add missing language name for es-419
Change 705158 abandoned by Mbch331:
[mediawiki/extensions/cldr@master] Add missing language name for es-419
Reason:
Not needed as it already is in CldrNamesEn
It's not there as it is in CldrNamesEn.php
So the cause must be something different. Maybe from the Wikidata team can figure this out? @Lydia_Pintscher
I don't see the problem. https://test.wikidata.org/wiki/Q149653 , latest entry, is shown in English: "test (Latin American Spanish)"
@Raymond That's the language name for monolingual text, a slightly different usecase than the two presented above. Can we try to add the patch to see if it would solve it for these?
Change 705196 had a related patch set uploaded (by Raimond Spekking; author: Raimond Spekking):
[mediawiki/extensions/cldr@master] Add es-419 for German
Instead of trying (IMO a useless) test for English I added above patch for German. If this does not work too we know that there could be an issue with numeric language codes in Wikikbase.
I don't think it's useless and, even if it is, I don't think it's going to break anything.
It may be a problem with languages accepted for Wikidata labels that aren't MW interface languages.
This is patch in cldr and not Wikibase. Not for the team to review in the standard process.
Yes I understand. But if it's a patch in cldr then there are other people to review those or if my team is supposed to review it then it needs to go through a process and can't bypass it like the regular language code patches. Those get fast-tracked because they are very small and predictable and don't need internal discussion anymore at that point.
I see, even though the patch is to LocalNames file, not the CLDR import file directly. As other language code patches, it is small, predictable (at least from my POV) and similar to the usual patches.
es-419 is an accepted MW interface language, see https://gerrit.wikimedia.org/r/plugins/gitiles/mediawiki/core/+/refs/heads/master/languages/data/Names.php#152 but it cannot be selected on [[Special:Preferences]] in a wiki. Reason: see https://gerrit.wikimedia.org/r/plugins/gitiles/mediawiki/core/+/a19320bf90b58437020a4bd50803e0d29a8a9269%5E%21/languages/data/Names.php
All the linked patches I am seeing here are in the cldr extension. Am I missing one?
- Do we know who at WMF is to review these? one or the other of these patches seemed to linger for years.
There are several reviewers already added to the patches, so yeah that should be fine. If not we'll have a look.
- Is there a way to grant @Mbch331 the necessary rights ?
Yes. The process is explained at https://www.mediawiki.org/wiki/Gerrit/Privilege_policy#Requesting_Gerrit_privileges
But it won't change anything really because self-merging patches is generally a no-no.
The patch to be reviewed now is by Raymond.
Interesting. Seems to be another point to check.
Interesting fact: on https://test.wikidata.org/wiki/Q149653 it works well.
And on my test page https://test.wikidata.org/wiki/User:Raymond/es-419 too.
I get "español de América Latina" with https://test.wikidata.org/wiki/Q149653?uselang=de or uselang=en
Funny... as anon user I get the same (wrong) output as you. The difference is maybe my Babel boxes on https://test.wikidata.org/wiki/User:Raymond ?
Actually, it wont fix it for labels, as "en-us" doesn't work despite being defined in LocalNamesDe.
Which gets us back to T261851 about something similar.
Change 705196 merged by jenkins-bot:
[mediawiki/extensions/cldr@master] Add es-419 for German
I added the info from here there. I think we can close this once LocalNamesDe is live.
It works for de (for monolingual text): https://www.wikidata.org/wiki/Q56649449?uselang=de