Page MenuHomePhabricator
Create Task
Maniphest T285447

Deprecate WikiPage::prepareContentForEdit() fallback to $wgUser
Closed, ResolvedPublic
Actions

Description

The overall method is soft deprecated, but we should separate deprecate calling without a User object, since that falls back to $wgUser. Thankfully most deployed callers already provide a User object

Steps

Details

SubjectRepoBranchLines +/-
Hard deprecate WikiPage::prepareContentForEdit() without a UserIdentitymediawiki/coremaster+6 -2
WikiImporter: Pass a user to WikiPage::prepareContentForEdit()mediawiki/coremaster+3 -1
Pass a user to WikiPage::prepareContentForEdit()mediawiki/extensions/AbuseFiltermaster+11 -3
Pass a user to WikiPage::prepareContentForEdit()mediawiki/extensions/SpamBlacklistmaster+1 -1
Pass a user to WikiPage::prepareContentForEdit()mediawiki/extensions/ConfirmEditmaster+1 -1
Customize query in gerrit

Related Objects
Search...

Event Timeline

DannyS712 triaged this task as Medium priority.Jun 24 2021, 3:28 AM
DannyS712 created this task.
DannyS712 moved this task from Untriaged to 2021 | MW 1.36 / 1.37 on the Technical-Debt (Deprecation process) board.
DannyS712 moved this task from Unsorted to In progress on the User-DannyS712 board.
gerritbot added a comment.Jun 24 2021, 3:28 AM

Change 701198 had a related patch set uploaded (by DannyS712; author: DannyS712):

[mediawiki/extensions/SpamBlacklist@master] Pass a user to WikiPage::prepareContentForEdit()

https://gerrit.wikimedia.org/r/701198

gerritbot added a project: Patch-For-Review.Jun 24 2021, 3:28 AM

Change 701199 had a related patch set uploaded (by DannyS712; author: DannyS712):

[mediawiki/extensions/ConfirmEdit@master] Pass a user to WikiPage::prepareContentForEdit()

https://gerrit.wikimedia.org/r/701199

gerritbot added a comment.Jun 24 2021, 3:30 AM

Change 701200 had a related patch set uploaded (by DannyS712; author: DannyS712):

[mediawiki/extensions/AbuseFilter@master] Pass a user to WikiPage::prepareContentForEdit()

https://gerrit.wikimedia.org/r/701200

gerritbot added a comment.Jun 24 2021, 7:23 PM

Change 701199 merged by jenkins-bot:

[mediawiki/extensions/ConfirmEdit@master] Pass a user to WikiPage::prepareContentForEdit()

https://gerrit.wikimedia.org/r/701199

gerritbot added a comment.Jun 24 2021, 7:27 PM

Change 701198 merged by jenkins-bot:

[mediawiki/extensions/SpamBlacklist@master] Pass a user to WikiPage::prepareContentForEdit()

https://gerrit.wikimedia.org/r/701198

ReleaseTaggerBot added a project: MW-1.37-notes (1.37.0-wmf.12; 2021-06-28).Jun 24 2021, 8:00 PM
gerritbot added a comment.Jun 27 2021, 1:00 AM

Change 701638 had a related patch set uploaded (by DannyS712; author: DannyS712):

[mediawiki/core@master] WikiImporter: Pass a user to WikiPage::prepareContentForEdit()

https://gerrit.wikimedia.org/r/701638

DannyS712 updated the task description. (Show Details)Jun 27 2021, 1:01 AM
DannyS712 mentioned this in T159299: Deprecate and remove $wgUser.Jun 27 2021, 4:11 AM
gerritbot added a comment.Jun 28 2021, 10:50 PM

Change 701200 merged by jenkins-bot:

[mediawiki/extensions/AbuseFilter@master] Pass a user to WikiPage::prepareContentForEdit()

https://gerrit.wikimedia.org/r/701200

gerritbot added a comment.Jun 28 2021, 11:03 PM

Change 701638 merged by jenkins-bot:

[mediawiki/core@master] WikiImporter: Pass a user to WikiPage::prepareContentForEdit()

https://gerrit.wikimedia.org/r/701638

gerritbot added a comment.Jun 28 2021, 11:12 PM

Change 702006 had a related patch set uploaded (by DannyS712; author: DannyS712):

[mediawiki/core@master] Hard deprecate WikiPage::prepareContentForEdit() without a User

https://gerrit.wikimedia.org/r/702006

DannyS712 updated the task description. (Show Details)Jun 28 2021, 11:17 PM
DannyS712 moved this task from In progress to Awaiting review and deployment on the User-DannyS712 board.
gerritbot added a comment.Jun 29 2021, 1:41 AM

Change 702006 merged by jenkins-bot:

[mediawiki/core@master] Hard deprecate WikiPage::prepareContentForEdit() without a UserIdentity

https://gerrit.wikimedia.org/r/702006

DannyS712 closed this task as Resolved.Jun 29 2021, 1:44 AM
DannyS712 mentioned this in T285732: Remove $wgUser fallback in WikiPage::prepareContentForEdit().
DannyS712 updated the task description. (Show Details)
DannyS712 removed a project: Patch-For-Review.
ReleaseTaggerBot edited projects, added MW-1.37-notes (1.37.0-wmf.14; 2021-07-12); removed MW-1.37-notes (1.37.0-wmf.12; 2021-06-28).Jun 29 2021, 2:00 AM
DannyS712 reopened this task as Open.Jul 4 2021, 6:03 AM

Filled that the AbuseFilterConsequencesTest manually specifies parameters and doesn't always include the user that is needed, causing tests to fail

DannyS712 closed this task as Resolved.Jul 4 2021, 6:13 AM
In T285447#7196307, @DannyS712 wrote:

Filled that the AbuseFilterConsequencesTest manually specifies parameters and doesn't always include the user that is needed, causing tests to fail

No, sorry, ignore me - caused by the patch I was testing not being on top of the change to pass the user

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits