Maniphest T284950

Remove deprecated hooks with no usages
Closed, ResolvedPublic2 Estimated Story Points
Actions

Description

The following hooks are deprecated and match no results on a codesearch. Let's remove them.

TODO

SkinTemplatePreventOtherActiveTabs https://codesearch.wmcloud.org/search/?q=SkinTemplatePreventOtherActiveTabs&i=nope&files=&excludeFiles=&repos=
SkinTemplateTabAction https://codesearch.wmcloud.org/search/?q=SkinTemplateTabAction&i=nope&files=&excludeFiles=&repos=
SkinTemplateBuildNavUrlsNav_urlsAfterPermalink (https://codesearch.wmcloud.org/search/?q=SkinTemplateBuildNavUrlsNav_urlsAfterPermalink&i=nope&files=&excludeFiles=&repos=, has one usage in Collection but that's a 3rd party extension and issue has been filed )

Details

Other Assignee: phuedx

	Subject	Repo	Branch	Lines +/-
	hooks: Remove deprecated SkinTemplateTabAction hook	mediawiki/core	master	+1 -57
	hooks: Remove deprecated SkinTemplateBuildNavUrlsNav_urlsAfterPermalink hook	mediawiki/core	master	+2 -69
	hooks: Remove deprecated SkinTemplatePreventOtherActiveTabs hook	mediawiki/core	master	+4 -40

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Resolved		Jdlrobson	T282045 [GOAL] Deprecate and remove skin code in preparation for 1.37
		Resolved		phuedx	T284950 Remove deprecated hooks with no usages

Event Timeline

Jdlrobson created this task.Jun 14 2021, 6:08 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 14 2021, 6:08 PM

Jdlrobson triaged this task as High priority.Jun 14 2021, 9:59 PM

Jdlrobson added a project: Web-Team-Backlog.

Jdlrobson updated the task description. (Show Details)

Jdlrobson added a parent task: T282045: [GOAL] Deprecate and remove skin code in preparation for 1.37.

Jdlrobson moved this task from Incoming to unsed on the Web-Team-Backlog board.

DannyS712 added a project: Technical-Debt (Deprecation process).Jun 14 2021, 10:51 PM

Jdlrobson moved this task from unsed to Kanbanana-FY-2020-21 on the Web-Team-Backlog board.Jun 21 2021, 2:21 PM

Jdlrobson edited projects, added Web-Team-Backlog (Kanbanana-FY-2020-21); removed Web-Team-Backlog.

Jdlrobson moved this task from Needs Analysis to Upcoming on the Web-Team-Backlog (Kanbanana-FY-2020-21) board.Jun 21 2021, 3:35 PM

Jdlrobson updated the task description. (Show Details)Jun 21 2021, 3:37 PM

LGoto set the point value for this task to 2.Jun 21 2021, 5:41 PM

LGoto moved this task from Upcoming to Ready for Development on the Web-Team-Backlog (Kanbanana-FY-2020-21) board.

phuedx claimed this task.Jun 23 2021, 11:07 AM

phuedx moved this task from Ready for Development to Doing on the Web-Team-Backlog (Kanbanana-FY-2020-21) board.

Change 701108 had a related patch set uploaded (by Phuedx; author: Phuedx):

[mediawiki/core@master] hooks: Remove deprecated SkinTemplatePreventOtherActiveTabs hook

https://gerrit.wikimedia.org/r/701108

Change 701109 had a related patch set uploaded (by Phuedx; author: Phuedx):

[mediawiki/core@master] hooks: Remove deprecated SkinTemplateTabAction hook

https://gerrit.wikimedia.org/r/701109

Change 701110 had a related patch set uploaded (by Phuedx; author: Phuedx):

[mediawiki/core@master] hooks: Remove deprecated SkinTemplateBuildNavUrlsNav_urlsAfterPermalink hook

https://gerrit.wikimedia.org/r/701110

and issue has been filed

@Jdlrobson: Do you have a link to that issue handy? Thanks!

phuedx removed phuedx as the assignee of this task.Jun 23 2021, 2:09 PM

phuedx moved this task from Doing to Design Review on the Web-Team-Backlog (Kanbanana-FY-2020-21) board.

phuedx moved this task from Design Review to Code Review on the Web-Team-Backlog (Kanbanana-FY-2020-21) board.

phuedx subscribed.

Jdlrobson claimed this task.Jun 23 2021, 3:30 PM

Jdlrobson updated Other Assignee, added: phuedx.

Jdlrobson removed Jdlrobson as the assignee of this task.Jun 24 2021, 2:38 PM

Jdlrobson moved this task from Code Review to Ready for Signoff on the Web-Team-Backlog (Kanbanana-FY-2020-21) board.

Jdlrobson moved this task from Ready for Signoff to Needs More Work on the Web-Team-Backlog (Kanbanana-FY-2020-21) board.Jun 24 2021, 3:28 PM

phuedx moved this task from Needs More Work to Code Review on the Web-Team-Backlog (Kanbanana-FY-2020-21) board.Jun 24 2021, 5:13 PM

LGoto assigned this task to Jdlrobson.Jun 24 2021, 5:15 PM

Change 701108 merged by jenkins-bot:

[mediawiki/core@master] hooks: Remove deprecated SkinTemplatePreventOtherActiveTabs hook

https://gerrit.wikimedia.org/r/701108

Change 701109 merged by jenkins-bot:

[mediawiki/core@master] hooks: Remove deprecated SkinTemplateTabAction hook

https://gerrit.wikimedia.org/r/701109

Change 701110 merged by jenkins-bot:

[mediawiki/core@master] hooks: Remove deprecated SkinTemplateBuildNavUrlsNav_urlsAfterPermalink hook

https://gerrit.wikimedia.org/r/701110

ReleaseTaggerBot added a project: MW-1.37-notes (1.37.0-wmf.12; 2021-06-28).Jun 24 2021, 6:00 PM

Maintenance_bot removed a project: Patch-For-Review.Jun 24 2021, 6:10 PM

Jdlrobson removed Jdlrobson as the assignee of this task.Jun 24 2021, 6:20 PM

Jdlrobson moved this task from Code Review to Ready for Signoff on the Web-Team-Backlog (Kanbanana-FY-2020-21) board.

LGoto assigned this task to • nray.Jun 29 2021, 5:05 PM

• nray closed this task as Resolved.Jul 2 2021, 4:36 PM

• nray reassigned this task from • nray to phuedx.

• nray updated the task description. (Show Details)

• nray subscribed.