Page MenuHomePhabricator

rename *-blacklist to *-disallowed-list in .stylelintrc.json and .eslintrc.json
Closed, ResolvedPublic

Description

Deprecation Warning: 'property-blacklist' has been deprecated. Instead use 'property-disallowed-list'. See: https://github.com/stylelint/stylelint/blob/13.7.0/lib/rules/property-blacklist/README.md

Not sure which stylelint version the new property are part of

https://codesearch.wmcloud.org/search/?q=(black%7Cwhite)list&i=nope&files=%5C.(style%7Ces)lintrc&excludeFiles=node_modules&repos=

stylelint:

property-blacklist
declaration-property-value-blacklist
unit-blacklist
function-blacklist

eslint:

id-blacklist

Maybe libup can assist here.
Duplicate keys should be removeed, because an extension can have both properties


Event Timeline

Change 683247 had a related patch set uploaded (by VolkerE; author: VolkerE):

[mediawiki/extensions/RevisionSlider@master] build: Change 'stylelint' config rule to '*disallowed-list'

https://gerrit.wikimedia.org/r/683247

Change 683250 had a related patch set uploaded (by VolkerE; author: VolkerE):

[mediawiki/extensions/CirrusSearch@master] build: Change 'stylelint' config rule to '*disallowed-list'

https://gerrit.wikimedia.org/r/683250

Change 683252 had a related patch set uploaded (by VolkerE; author: VolkerE):

[wikimedia/portals@master] build: Update 'stylelint' & change config rule to '*disallowed-list'

https://gerrit.wikimedia.org/r/683252

Change 683247 merged by jenkins-bot:

[mediawiki/extensions/RevisionSlider@master] build: Change 'stylelint' config rule to '*disallowed-list'

https://gerrit.wikimedia.org/r/683247

Change 683252 merged by jenkins-bot:

[wikimedia/portals@master] build: Update 'stylelint' & change config rule to '*disallowed-list'

https://gerrit.wikimedia.org/r/683252

Change 683250 merged by jenkins-bot:

[mediawiki/extensions/CirrusSearch@master] build: Change 'stylelint' config rule to '*disallowed-list'

https://gerrit.wikimedia.org/r/683250

Change 785400 had a related patch set uploaded (by VolkerE; author: VolkerE):

[mediawiki/extensions/MediaSearch@master] build: Remove obsolete 'stylelint' config rule

https://gerrit.wikimedia.org/r/785400

Change 785400 merged by jenkins-bot:

[mediawiki/extensions/MediaSearch@master] build: Remove obsolete 'stylelint' config rule

https://gerrit.wikimedia.org/r/785400

Hi @Umherirrender! I see that the patch has been merged, does this mean we can change this task's status as resolved? Or what else would be needed to complete the task? Thanks!

Jdforrester-WMF subscribed.

Hi @Umherirrender! I see that the patch has been merged, does this mean we can change this task's status as resolved? Or what else would be needed to complete the task? Thanks!

There are still outstanding repos that need fixing (I've adjusted the link to make it clearer):

Wikimedia production:

  • extensions/CentralNotice
  • extensions/WikibaseLexeme

Non-Wikimedia production:

  • extensions/Cargo
  • extensions/CreateAPage
  • extensions/HeaderTabs
  • extensions/TimelineTable
  • Liquipedia/TrendingMenu

Change 849701 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/CodeMirror@master] build: Disable rule unit-disallowed-list inline

https://gerrit.wikimedia.org/r/849701

Change 849705 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/CentralNotice@master] Build: Use new unit-disallowed-list rule

https://gerrit.wikimedia.org/r/849705

Change 849706 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/CreateAPage@master] Build: Use new declaration-property-value-disallowed-list rule

https://gerrit.wikimedia.org/r/849706

Change 849707 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/Cargo@master] Build: Use new declaration-property-value-disallowed-list rule

https://gerrit.wikimedia.org/r/849707

Change 849708 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/HeaderTabs@master] Build: Use new declaration-property-value-disallowed-list rule

https://gerrit.wikimedia.org/r/849708

Change 849709 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/TimelineTable@master] build: Remove duplicate function-disallowed-list rule

https://gerrit.wikimedia.org/r/849709

Change 849710 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/WikibaseLexeme@master] build: Remove duplicate unit-disallowed-list rule

https://gerrit.wikimedia.org/r/849710

Change 849710 merged by jenkins-bot:

[mediawiki/extensions/WikibaseLexeme@master] build: Remove duplicate unit-disallowed-list rule

https://gerrit.wikimedia.org/r/849710

Change 849706 merged by jenkins-bot:

[mediawiki/extensions/CreateAPage@master] Build: Use new declaration-property-value-disallowed-list rule

https://gerrit.wikimedia.org/r/849706

Change 849707 merged by jenkins-bot:

[mediawiki/extensions/Cargo@master] Build: Use new declaration-property-value-disallowed-list rule

https://gerrit.wikimedia.org/r/849707

Change 849708 merged by jenkins-bot:

[mediawiki/extensions/HeaderTabs@master] Build: Use new declaration-property-value-disallowed-list rule

https://gerrit.wikimedia.org/r/849708

Change 849709 merged by jenkins-bot:

[mediawiki/extensions/TimelineTable@master] build: Remove duplicate function-disallowed-list rule

https://gerrit.wikimedia.org/r/849709

Jdforrester-WMF assigned this task to Umherirrender.
Jdforrester-WMF added a subscriber: FO-nTTaX.

OK, this is all done except for Liquipedia/TrendingMenu which we can't fix locally (ping @FO-nTTaX for that work). I'll declare this Resolved.

I'll look into updating the Liquipedia extension next week, thanks for the ping.

Change 849705 merged by jenkins-bot:

[mediawiki/extensions/CentralNotice@master] Build: Use new unit-disallowed-list rule

https://gerrit.wikimedia.org/r/849705

Change 849701 merged by jenkins-bot:

[mediawiki/extensions/CodeMirror@master] build: Disable rule unit-disallowed-list inline

https://gerrit.wikimedia.org/r/849701