Page MenuHomePhabricator
Create Task
Maniphest T273976

Create 'action type' checkbox filters for Special:SecurePollLog form
Closed, ResolvedPublic
Actions

Description

See the parent task T271279 for how the final form should look.

This task is for creating the 'action type' filters.

Form fields are specified using an array, as documented in HTMLForm.php

The 'Action type' fields should have the following:

  • Should have type 'check', which maps to HTMLCheckField (see HTMLForm::typeMappings)
  • Should become disabled if Voter log is selected in the dropdown at the top of the form, and enabled otherwise

The values of these fields should be passed through to the SecurePollLogPager. The pager's query, built in SecurePollLogPager::getFilterConds, should be updated.

Details

SubjectRepoBranchLines +/-
Add action type filter to Special:SecurePollLog pagemediawiki/extensions/SecurePollmaster+51 -10
Customize query in gerrit

Related Objects
Search...

Event Timeline

Tchanders created this task.Feb 5 2021, 2:00 PM
Restricted Application added a project: Platform Engineering. · View Herald TranscriptFeb 5 2021, 2:00 PM
STran claimed this task.Feb 8 2021, 3:08 PM
STran moved this task from Ready 🎬 (ONLY IF YOU HAVE NO MORE CODE TO REVIEW) to In Progress 💪 on the Anti-Harassment (The Letter Song) board.
ArielGlenn moved this task from Inbox to Tracking/Watching on the Platform Engineering board.Feb 9 2021, 12:27 PM
gerritbot added a comment.Feb 11 2021, 2:47 PM

Change 663587 had a related patch set uploaded (by STran; owner: STran):
[mediawiki/extensions/SecurePoll@master] Add action type filter to Special:SecurePollLog page

https://gerrit.wikimedia.org/r/663587

gerritbot added a project: Patch-For-Review.Feb 11 2021, 2:47 PM
STran moved this task from In Progress 💪 to Code Review 🔍 on the Anti-Harassment (The Letter Song) board.Feb 11 2021, 3:30 PM
STran moved this task from Code Review 🔍 to In Progress 💪 on the Anti-Harassment (The Letter Song) board.Feb 11 2021, 4:37 PM
STran moved this task from In Progress 💪 to Code Review 🔍 on the Anti-Harassment (The Letter Song) board.Feb 11 2021, 9:25 PM
Tchanders added a comment.Feb 12 2021, 6:07 PM

@Prtksxna What should happen if 'Admin log' is selected and neither of the 'Admin type' checkboxes are checked?

image.png (414×730 px, 21 KB)

A related question: what should be the default state of those checkboxes when 'Admin log' is selected at the top?

Tchanders moved this task from Code Review 🔍 to Needs Design/Product 🎨 on the Anti-Harassment (The Letter Song) board.Feb 12 2021, 6:08 PM
• Prtksxna added a comment.Feb 16 2021, 5:26 AM
In T273976#6827016, @Tchanders wrote:

@Prtksxna What should happen if 'Admin log' is selected and neither of the 'Admin type' checkboxes are checked?

Is there a third action type that is always shown? If not, do you think it'd make sense to turn these into Radios:

  • Admin added
  • Admin removed
  • Both

A related question: what should be the default state of those checkboxes when 'Admin log' is selected at the top?

Both checkboxes should be checked. If we go with radios, then Both to be selected.

STran moved this task from Needs Design/Product 🎨 to In Progress 💪 on the Anti-Harassment (The Letter Song) board.Feb 16 2021, 5:16 PM
STran added a comment.Feb 16 2021, 8:15 PM

Should this filter be disabled if "All SecurePoll logs" is selected? Right now we only disable it when "Voter log" is selected but we don't filter on the action type if "All" is selected either. We could but then that's essentially "Admin log" isn't it?

STran moved this task from In Progress 💪 to Needs Design/Product 🎨 on the Anti-Harassment (The Letter Song) board.Feb 16 2021, 8:27 PM
• Prtksxna added a comment.Feb 17 2021, 5:07 PM
In T273976#6835112, @STran wrote:

Should this filter be disabled if "All SecurePoll logs" is selected?

Yep, we should do that.

Right now we only disable it when "Voter log" is selected but we don't filter on the action type if "All" is selected either. We could but then that's essentially "Admin log" isn't it?

You're right. It could be slightly different if the radios apply only to the Admin logs while still showing all the Voter logs. But I think disabling seems more straightforward.

STran moved this task from Needs Design/Product 🎨 to In Progress 💪 on the Anti-Harassment (The Letter Song) board.Feb 17 2021, 5:27 PM
STran moved this task from In Progress 💪 to Code Review 🔍 on the Anti-Harassment (The Letter Song) board.Feb 17 2021, 7:03 PM
Tchanders moved this task from Code Review 🔍 to Done: Q3 (2020-2021) on the Anti-Harassment (The Letter Song) board.Feb 22 2021, 8:04 PM
gerritbot added a comment.Feb 22 2021, 8:14 PM

Change 663587 merged by jenkins-bot:
[mediawiki/extensions/SecurePoll@master] Add action type filter to Special:SecurePollLog page

https://gerrit.wikimedia.org/r/663587

ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.32; 2021-02-23).Feb 22 2021, 9:00 PM
Maintenance_bot removed a project: Patch-For-Review.Feb 22 2021, 9:10 PM
Niharika closed this task as Resolved.Feb 24 2021, 2:52 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits