Page MenuHomePhabricator
Create Task
Maniphest T270846

Update CentralAuth to use the new HookContainer/HookRunner system
Closed, ResolvedPublic
Actions

Details

SubjectRepoBranchLines +/-
Migrate remaining CentralAuth hooks to the new hook systemmediawiki/extensions/CentralAuthmaster+273 -17
AntiSpoof: migrate to new Hook systemmediawiki/extensions/CentralAuthmaster+66 -35
Inject MainConfig into Hooksmediawiki/extensions/CentralAuthmaster+913 -522
Use hook handlers for SecurePoll hooksmediawiki/extensions/CentralAuthmaster+27 -9
Inject services into Hook Handlersmediawiki/extensions/CentralAuthmaster+595 -261
Use the new Hook systemmediawiki/extensions/CentralAuthmaster+360 -257
Customize query in gerrit

Related Objects
Search...

Event Timeline

taavi created this task.Dec 27 2020, 8:58 AM
Restricted Application added a project: User-Majavah. · View Herald TranscriptDec 27 2020, 8:58 AM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
taavi mentioned this in T270852: Dashes in AbuseFilter hook names cause issues with interfaces .Dec 27 2020, 12:28 PM
taavi moved this task from Unsorted to Working on on the User-Majavah board.Dec 27 2020, 1:42 PM
gerritbot added a comment.Feb 17 2021, 7:38 PM

Change 664895 had a related patch set uploaded (by Majavah; owner: Majavah):
[mediawiki/extensions/CentralAuth@master] Move CentralAuthWikiList hook to the new hook runner system

https://gerrit.wikimedia.org/r/664895

gerritbot added a project: Patch-For-Review.Feb 17 2021, 7:38 PM
gerritbot added a comment.Feb 17 2021, 7:45 PM

Change 664895 abandoned by Majavah:
[mediawiki/extensions/CentralAuth@master] Move CentralAuthWikiList hook to the new hook runner system

Reason:
messed up with Git somehow, will redo

https://gerrit.wikimedia.org/r/664895

gerritbot added a comment.Aug 5 2021, 4:46 PM

Change 664895 restored by Majavah:

[mediawiki/extensions/CentralAuth@master] Move CentralAuthWikiList hook to the new hook runner system

https://gerrit.wikimedia.org/r/664895

gerritbot added a comment.Aug 29 2021, 11:09 AM

Change 715326 had a related patch set uploaded (by Zabe; author: Zabe):

[mediawiki/extensions/CentralAuth@master] Use the new Hook system

https://gerrit.wikimedia.org/r/715326

gerritbot added a comment.Aug 29 2021, 1:22 PM

Change 715331 had a related patch set uploaded (by Zabe; author: Zabe):

[mediawiki/extensions/CentralAuth@master] CentralAuthHooks: inject UserNameUtils and Config

https://gerrit.wikimedia.org/r/715331

gerritbot added a comment.Sep 2 2021, 6:10 PM

Change 715326 merged by jenkins-bot:

[mediawiki/extensions/CentralAuth@master] Use the new Hook system

https://gerrit.wikimedia.org/r/715326

gerritbot added a comment.Sep 10 2021, 7:31 PM

Change 720383 had a related patch set uploaded (by Zabe; author: Zabe):

[mediawiki/extensions/CentralAuth@master] Inject MainConfig into Hooks

https://gerrit.wikimedia.org/r/720383

gerritbot added a comment.Sep 15 2021, 8:47 AM

Change 715331 merged by jenkins-bot:

[mediawiki/extensions/CentralAuth@master] Inject services into Hook Handlers

https://gerrit.wikimedia.org/r/715331

gerritbot added a comment.Nov 1 2021, 11:47 AM

Change 735956 had a related patch set uploaded (by Majavah; author: Majavah):

[mediawiki/extensions/CentralAuth@master] Use hook handlers for SecurePoll hooks

https://gerrit.wikimedia.org/r/735956

gerritbot added a comment.Nov 25 2021, 9:10 PM

Change 735956 merged by jenkins-bot:

[mediawiki/extensions/CentralAuth@master] Use hook handlers for SecurePoll hooks

https://gerrit.wikimedia.org/r/735956

ReleaseTaggerBot added a project: MW-1.38-notes (1.38.0-wmf.12; 2021-12-06).Nov 25 2021, 10:00 PM
gerritbot added a comment.Dec 4 2021, 1:11 PM

Change 720383 merged by jenkins-bot:

[mediawiki/extensions/CentralAuth@master] Inject MainConfig into Hooks

https://gerrit.wikimedia.org/r/720383

Zabe removed a project: Patch-For-Review.Dec 18 2021, 9:53 PM
Zabe subscribed.Jan 8 2022, 10:06 PM
taavi added a comment.Jan 26 2022, 6:47 PM

Anything left to do here?

Zabe closed this task as Resolved.Jan 26 2022, 6:49 PM
In T270846#7653994, @Majavah wrote:

Anything left to do here?

nope

Zabe reopened this task as Open.EditedMar 20 2022, 8:31 PM
Zabe claimed this task.
In T270846#7654002, @Zabe wrote:
In T270846#7653994, @Majavah wrote:

Anything left to do here?

nope

Actually. I forgot AntiSpoof.

gerritbot added a comment.Mar 21 2022, 3:50 PM

Change 772429 had a related patch set uploaded (by Majavah; author: Majavah):

[mediawiki/extensions/CentralAuth@master] Migrate remaining CentralAuth hooks to the new hook system

https://gerrit.wikimedia.org/r/772429

gerritbot added a project: Patch-For-Review.Mar 21 2022, 3:50 PM
gerritbot added a comment.Mar 22 2022, 2:26 PM

Change 772837 had a related patch set uploaded (by Zabe; author: Zabe):

[mediawiki/extensions/CentralAuth@master] AntiSpoof: migrate to new Hook system

https://gerrit.wikimedia.org/r/772837

gerritbot added a comment.Mar 24 2022, 12:22 PM

Change 772429 merged by jenkins-bot:

[mediawiki/extensions/CentralAuth@master] Migrate remaining CentralAuth hooks to the new hook system

https://gerrit.wikimedia.org/r/772429

ReleaseTaggerBot added a project: MW-1.39-notes (1.39.0-wmf.5; 2022-03-28).Mar 24 2022, 1:00 PM
gerritbot added a comment.Mar 26 2022, 7:49 PM

Change 772837 abandoned by Zabe:

[mediawiki/extensions/CentralAuth@master] AntiSpoof: migrate to new Hook system

Reason:

Let's go with https://gerrit.wikimedia.org/r/c/mediawiki/extensions/CentralAuth/+/773945/ instead

https://gerrit.wikimedia.org/r/772837

Zabe removed a project: Patch-For-Review.Apr 10 2022, 10:35 PM
Umherirrender mentioned this in T338449: Update MobileFrontend to use the new HookContainer/HookRunner system.Jun 10 2023, 7:32 AM
Zabe removed Zabe as the assignee of this task.Aug 18 2023, 3:15 PM
Restricted Application added a project: MediaWiki-Platform-Team. · View Herald TranscriptAug 18 2023, 3:15 PM
larissagaulia moved this task from Inbox, needs triage to Radar on the MediaWiki-Platform-Team board.Aug 22 2023, 11:08 AM
larissagaulia edited projects, added MediaWiki-Platform-Team (Radar); removed MediaWiki-Platform-Team.
taavi closed this task as Resolved.Aug 22 2023, 11:17 AM

Last bits fixed in https://gerrit.wikimedia.org/r/plugins/gitiles/mediawiki/extensions/CentralAuth/+/62d4e995a634deae0098b2a66b31d985ff486a8a%5E%21 I believe.

Umherirrender mentioned this in T315908: Update OAuth to use the new HookContainer/HookRunner system.Sep 17 2023, 12:07 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits