Maniphest T261984

Folder structure for assets built by Webpack should be separated from standard ResourceLoader assets
Closed, DeclinedPublic2 Estimated Story Points
Actions

Description

This follows up the conversation in T257647#6431761

The folder structure is very confusing. The resources folder is typically used for assets directly shipped to the end user, however resources/skins.vector.search/App.vue and resources/skins.vector.search/index.js are assets that are built via webpack and shipped via a file in resources/dist.

In other repos where we've mixed webpack and ResourceLoader (e.g. MobileFrontend and Popups) we use a src folder to distinguish these files from the rest of Vector.

Having the resources and source files mixed can be confusing to developers not familiar with using webpack and is inconsistent with our other repos

suggested layout

resources/skins.vector.search moved to src/skins.vector.search
webpack configuration updated

acceptance criteria

It should be logical from the names of dist which ResourceLoader module name they are shipped with (this appears to currently be the case)
JS built via webpack should be clearly separated from JS that is not
The resources folder should only contain files that are shipped via ResourceLoader and listed in skin.json

Related Objects
Search...

Status	Assigned	Task
Open	None	T49145 Formally deprecate jQuery UI after we've stopped using jQuery UI in extensions and core
Open	None	T100270 Replace use of jQuery UI and MW UI with OOUI across all Wikimedia-deployed extensions and core
Open	None	T85394 Use OOUI suggestions/autocompletion components only (instead of jquery.suggestions, jquery.ui.autocomplete)
Open	None	T125725 [epic] Update autocomplete search box with metadata and remove and delete the old searchSuggest system
Resolved	ovasileva	T244392 [GOAL] Deploy the new Vue.js search experience
Resolved	ovasileva	T275200 Analyze results of A/B test for new search widget
Resolved	ovasileva	T249297 Deploy the new Vue.js search experience
Resolved	Edtadros	T259798 Deploy the new Vue.js search experience to the Beta-Cluster and Test Wikipedia
Declined	None	T257865 Merge feat/search to master for Vue.js search deployment
Declined	None	T261984 Folder structure for assets built by Webpack should be separated from standard ResourceLoader assets

Event Timeline

Jdlrobson created this task.Sep 3 2020, 7:40 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 3 2020, 7:40 PM

Jdlrobson mentioned this in T257647: Integrate WVUI into Vector for Vue.js search.Sep 3 2020, 7:41 PM

• Niedzielski moved this task from Backlog to Epics on the Design-Systems-team-20200324-20220422 (Vue.js Search Experience (Vector modern)) board.Sep 14 2020, 6:21 PM

Jdlrobson moved this task from Needs Analysis to Upcoming on the Web-Team-Backlog (Kanbanana-FY-2020-21) board.Sep 17 2020, 1:14 AM

DannyS712 updated the task description. (Show Details)Sep 17 2020, 1:15 AM

DannyS712 subscribed.

Jdlrobson triaged this task as Medium priority.Sep 17 2020, 11:06 PM

ovasileva set the point value for this task to 2.Sep 28 2020, 5:15 PM

This task is medium priority but seems smallish and mostly independent of the other work. It would be a good starter task.

Jdlrobson added a parent task: T257865: Merge feat/search to master for Vue.js search deployment.Oct 30 2020, 5:42 PM

ovasileva moved this task from Upcoming to Ready for Development on the Web-Team-Backlog (Kanbanana-FY-2020-21) board.Nov 2 2020, 6:21 PM

Blocked on the decision of the working group meeting this week.

The current recommendation of the working group that met last week is to not use a build step in Vector so this task is not necessary any more. We will be deleting the search feature branch.

Folder structure for assets built by Webpack should be separated from standard ResourceLoader assetsClosed, DeclinedPublic2 Estimated Story PointsActions