Page MenuHomePhabricator
Create Task
Maniphest T251395

Wire up the "login" button in dedicated error component
Closed, ResolvedPublic
Actions

Description

  • create new message to show on login page
  • register this message to be white listed for this purpose
  • link to login page in new tab
    • add warning parameter with name of the message to display there
  • make user return to the state before save was clicked

Details

SubjectRepoBranchLines +/-
bridge: add login warning messagemediawiki/extensions/Wikibasemaster+104 -0
bridge: wire up “login” button for assertuser errormediawiki/extensions/Wikibasemaster+7 -2
Customize query in gerrit

Related Objects
Search...

Event Timeline

• Pablo-WMDE created this task.Apr 29 2020, 10:52 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 29 2020, 10:52 AM
Lucas_Werkmeister_WMDE claimed this task.May 13 2020, 7:22 AM
Lucas_Werkmeister_WMDE moved this task from To do to Doing on the Wikidata-Bridge-Sprint-19 board.
gerritbot added a comment.May 13 2020, 7:29 AM

Change 596144 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/Wikibase@master] bridge: wire up “login” button for assertuser error

https://gerrit.wikimedia.org/r/596144

gerritbot added a project: Patch-For-Review.May 13 2020, 7:29 AM
Lucas_Werkmeister_WMDE moved this task from Doing to Peer Review on the Wikidata-Bridge-Sprint-19 board.May 13 2020, 10:02 AM
darthmon_wmde added a project: Wikidata-Bridge-Sprint-20.May 13 2020, 10:50 AM
darthmon_wmde moved this task from To do to Peer Review on the Wikidata-Bridge-Sprint-20 board.
• Pablo-WMDE added a comment.May 13 2020, 10:52 AM

Decided in the latest task break-down today (again) to go with the warning parameter (which will yield a yellow box around the message) and see what UX says.

gerritbot added a comment.May 13 2020, 1:20 PM

Change 596210 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/Wikibase@master] bridge: add login warning message

https://gerrit.wikimedia.org/r/596210

gerritbot added a comment.May 14 2020, 10:54 AM

Change 596144 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] bridge: wire up “login” button for assertuser error

https://gerrit.wikimedia.org/r/596144

gerritbot added a comment.May 14 2020, 10:54 AM

Change 596210 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] bridge: add login warning message

https://gerrit.wikimedia.org/r/596210

ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.34; 2020-05-26).May 14 2020, 11:00 AM
Lucas_Werkmeister_WMDE closed this task as Resolved.May 14 2020, 11:00 AM
Lucas_Werkmeister_WMDE moved this task from Peer Review to Done on the Wikidata-Bridge-Sprint-20 board.
Maintenance_bot removed a project: Patch-For-Review.May 14 2020, 11:10 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits