⚓ T250714 Hard deprecate Revision::getVisibility

Subject	Repo	Branch	Lines +/-
Hard deprecate Revision::getParentId and ::getVisibility	mediawiki/core	master	+20 -1
Remove DifferenceEngine::$mNewRev and $mOldRev	mediawiki/core	master	+163 -125
Replace Article::$mRevision with RevisionRecord	mediawiki/core	master	+86 -61
Replace various uses of Revision objects	mediawiki/core	master	+174 -115
Remove use of InlineDifferenceEngine Revision variables	mediawiki/extensions/MobileFrontend	master	+11 -8
Add ContribsPager::tryCreatingRevisionRecord	mediawiki/core	master	+80 -15

Status	Assigned	Task
Open	None	T11968 Reduce use of global and public variables
Open	None	T159283 Deprecate non-configuration globals
Open	DannyS712	T159299 Deprecate and remove $wgUser
Resolved	DannyS712	T267861 [GOAL] Emit deprecation warnings reading from $wgUser
Open	DannyS712	T243708 Mediawiki core needs uses of global $wgUser removed
Resolved	DannyS712	T246284 Hard deprecate the Revision class
Resolved	DannyS712	T251067 Hard deprecate individual Revision class methods [tracking]
Resolved	DannyS712	T250714 Hard deprecate Revision::getVisibility

DannyS712 triaged this task as Medium priority.Apr 20 2020, 4:11 PM

DannyS712 created this task.

DannyS712 moved this task from Untriaged to 2020 | MW 1.35 on the Technical-Debt (Deprecation process) board.

DannyS712 moved this task from Unsorted to Next on the User-DannyS712 board.

DannyS712 updated the task description. (Show Details)

DannyS712 mentioned this in T251067: Hard deprecate individual Revision class methods [tracking].Apr 26 2020, 11:37 PM

DannyS712 removed a parent task: T246284: Hard deprecate the Revision class.Apr 26 2020, 11:39 PM

DannyS712 added a parent task: T251067: Hard deprecate individual Revision class methods [tracking].

Change 592513 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/core@master] Add ContribsPager::tryCreatingRevisionRecord

https://gerrit.wikimedia.org/r/592513

gerritbot added a project: Patch-For-Review.Apr 27 2020, 5:07 AM

DannyS712 moved this task from Next to In progress on the User-DannyS712 board.Apr 27 2020, 7:13 AM

Change 592513 merged by jenkins-bot:
[mediawiki/core@master] Add ContribsPager::tryCreatingRevisionRecord

https://gerrit.wikimedia.org/r/592513

Maintenance_bot removed a project: Patch-For-Review.Apr 27 2020, 11:11 PM

Change 591201 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/MobileFrontend@master] Remove use of InlineDifferenceEngine Revision variables

https://gerrit.wikimedia.org/r/591201

gerritbot added a project: Patch-For-Review.Apr 28 2020, 1:57 AM

ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.30; 2020-04-28).Apr 28 2020, 8:00 AM

Change 593620 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/core@master] Replace uses and hard deprecate Revision::getVisibility

https://gerrit.wikimedia.org/r/593620

In T250714#6098844, @gerritbot wrote:

Change 593620 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/core@master] Replace uses and hard deprecate Revision::getVisibility

https://gerrit.wikimedia.org/r/593620

A lot of uses remaining including some addressed by other pending patches - patch now just cleans up a bunch of different places Revision is still used

Change 591201 merged by jenkins-bot:
[mediawiki/extensions/MobileFrontend@master] Remove use of InlineDifferenceEngine Revision variables

https://gerrit.wikimedia.org/r/591201

ReleaseTaggerBot edited projects, added MW-1.35-notes (1.35.0-wmf.31; 2020-05-05); removed MW-1.35-notes (1.35.0-wmf.30; 2020-04-28).Apr 30 2020, 11:00 PM

DannyS712 updated the task description. (Show Details)May 1 2020, 5:05 AM

Change 593272 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/core@master] Remove DifferenceEngine::$mNewRev and $mOldRev

https://gerrit.wikimedia.org/r/593272

Current uses in core, excluding tests

~~Revision::userCan~~ entire method is hard deprecated
HistoryPager - https://gerrit.wikimedia.org/r/#/c/mediawiki/core/+/593620/
DifferenceEngine - https://gerrit.wikimedia.org/r/#/c/mediawiki/core/+/593272/
Article::fetchRevisionRecord
Article::showDeletedRevisionHeader
RevDelRevisionItem - https://gerrit.wikimedia.org/r/#/c/mediawiki/core/+/593620/
RevisionItem - https://gerrit.wikimedia.org/r/#/c/mediawiki/core/+/593620/
SpecialMergeHistory::formatRevisionRow - https://gerrit.wikimedia.org/r/#/c/mediawiki/core/+/593620/
SpecialUndelete - https://gerrit.wikimedia.org/r/#/c/mediawiki/core/+/593620/
DeletedContribsPager::formatRevisionRow - https://gerrit.wikimedia.org/r/#/c/mediawiki/core/+/593620/

Jdlrobson added a project: Web-Team-Backlog (Tracking).May 1 2020, 5:51 PM

Change 593620 merged by jenkins-bot:
[mediawiki/core@master] Replace various uses of Revision objects

https://gerrit.wikimedia.org/r/593620

Change 593826 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/core@master] Replace Article::$mRevision with RevisionRecord

https://gerrit.wikimedia.org/r/593826

Change 593826 merged by jenkins-bot:
[mediawiki/core@master] Replace Article::$mRevision with RevisionRecord

https://gerrit.wikimedia.org/r/593826

Change 593272 merged by jenkins-bot:
[mediawiki/core@master] Remove DifferenceEngine::$mNewRev and $mOldRev

https://gerrit.wikimedia.org/r/593272

Maintenance_bot removed a project: Patch-For-Review.May 26 2020, 10:11 PM

Change 599135 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/core@master] Hard deprecate Revision::getParentId and ::getVisibility

https://gerrit.wikimedia.org/r/599135

gerritbot added a project: Patch-For-Review.May 27 2020, 11:15 PM

DannyS712 moved this task from In progress to Awaiting review and deployment on the User-DannyS712 board.May 27 2020, 11:15 PM

DannyS712 updated the task description. (Show Details)

Change 599135 merged by jenkins-bot:
[mediawiki/core@master] Hard deprecate Revision::getParentId and ::getVisibility

https://gerrit.wikimedia.org/r/599135

ReleaseTaggerBot edited projects, added MW-1.35-notes (1.35.0-wmf.35; 2020-06-02); removed MW-1.35-notes (1.35.0-wmf.31; 2020-05-05).May 28 2020, 1:00 AM

Maintenance_bot removed a project: Patch-For-Review.May 28 2020, 1:10 AM

DannyS712 closed this task as Resolved.May 28 2020, 2:32 AM

DannyS712 moved this task from Awaiting review and deployment to Resolved (deprecation) on the User-DannyS712 board.Jul 9 2020, 11:15 PM