Page MenuHomePhabricator
Create Task
Maniphest T250327

Newcomer tasks: clean up help panel EventLogging
Closed, ResolvedPublic
Actions

Description

As part of rearranging the help panel for guidance, we have some EventLogging issues we would like to clean up. @Catrope says:

However, I also noticed that there is no action logged for moving to some of the newer panels (general-help and suggested-edits). Instead, we log a link-click for clicks on the buttons on the home screen, which is duplicative for the button taking you to the ask-question panel (that logs an action, named review for historical reasons) but it's the only way that we track the state change for moving to the general-help or suggested-edits panels (those don't log actions). When moving back from those panels to the home panel (using the back icon at the top left), we do log that as a navigation action (back-home), not as a link-click.

The changes are pretty clear to me:

  • Rename the review action to ask-help
  • Add actions called general-help and suggested-edits , and start logging them
  • Stop logging link-click events for navigation actions, since they're now redundant

Details

SubjectRepoBranchLines +/-
Help panel: Clean up navigation loggingmediawiki/extensions/GrowthExperimentsmaster+4 -5
Customize query in gerrit

Related Objects
Search...

Event Timeline

MMiller_WMF created this task.Apr 15 2020, 10:48 PM
MMiller_WMF moved this task from Incoming to Ready for Development on the Growth-Team (Sprint 0 (Growth Team)) board.
gerritbot added a comment.May 2 2020, 2:50 AM

Change 593878 had a related patch set uploaded (by Catrope; owner: Catrope):
[mediawiki/extensions/GrowthExperiments@master] Help panel: Clean up navigation logging

https://gerrit.wikimedia.org/r/593878

gerritbot added a project: Patch-For-Review.May 2 2020, 2:50 AM
• Catrope claimed this task.May 2 2020, 2:51 AM
• Catrope moved this task from Ready for Development to Code Review on the Growth-Team (Sprint 0 (Growth Team)) board.

Corresponding schema edit: https://meta.wikimedia.org/w/index.php?title=Schema:HelpPanel&diff=next&oldid=20029266

Tgr mentioned this in T246919: Newcomer tasks: guidance instrumentation.May 15 2020, 6:15 PM
gerritbot added a comment.May 19 2020, 2:01 PM

Change 593878 merged by jenkins-bot:
[mediawiki/extensions/GrowthExperiments@master] Help panel: Clean up navigation logging

https://gerrit.wikimedia.org/r/593878

kostajh moved this task from Code Review to QA on the Growth-Team (Sprint 0 (Growth Team)) board.May 19 2020, 2:06 PM
Maintenance_bot removed a project: Patch-For-Review.May 19 2020, 2:10 PM
ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.34; 2020-05-26).May 19 2020, 3:00 PM
Etonkovidova moved this task from QA to Needs PM Review on the Growth-Team (Sprint 0 (Growth Team)) board.Jun 17 2020, 12:25 AM

Checked in testwiki wmf.37 - no issues are found.

(1)

  • Rename the review action to ask-help

No more review action.
(2)

  • Add actions called general-help and suggested-edits , and start logging them

ask-help action is for "Ask the help desk"
general-help action is for "General editing help"
suggested-edits action is for Suggested edits guidance screen
(3)

  • Stop logging link-click events for navigation actions, since they're now redundant

There are postedit-link-click action in the following context:

{"dt": "2020-06-17T00:00:17Z", "event": {"action": "postedit-link-click", "action_data": "homepage", "context": "postedit", "editor_interface": "visualeditor", "help_panel_session_id": "cb6b5fb17ea87a5e32fc", "is_mobile": false, "is_suggested_task": true, "page_id": 0, "page_ns": 0, "page_protection": "", "page_title": "",[...]
MMiller_WMF closed this task as Resolved.Feb 28 2021, 11:50 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits