The Watchstar confusingly is not an Icon - it contains logic for handling clicks to the watchstar.
We also have an icons.watchIcon helper class which is uses.
The icons.watchIcon helper should accept parameters, and the entire Watchstar class should become a function that creates and manages a watchIcon and watchedIcon.
Experimented with this here: https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/MobileFrontend/+/535671 WIP: Replace Watchstar class with an icon helper
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Resolved | Jdlrobson | T195473 [GOAL] Invest in the MobileFrontend & MinervaNeue frontend architecture | |||
| Resolved | Jdlrobson | T195478 [EPIC] Speed up unit test execution and increase code coverage | |||
| Resolved | Jdlrobson | T195482 [EPIC] Review and refactor MobileFrontend components used by Minerva | |||
| Open | None | T281930 [EPIC] Migrate MobileFrontend's code to Vue.js and Codex | |||
| Declined | None | T212465 [EPIC] None of our View's should exhibit 2 levels of inheritance | |||
| Resolved | Jdlrobson | T232517 Watchstar should not extend the Icon class |