| stjn | |
| May 28 2019, 9:43 PM |
| F29325503: Screenshot Suche 20190603.jpg | |
| Jun 3 2019, 5:29 AM |
Autocomplete on MediaWiki.org and other sites with future MediaWiki version deployed shows without prompt on initial page load. In MediaWiki version deployed in other projects, it only shows when user starts typing in the field.
Tested in Firefox 67, Windows 8.1, and Chrome 74, Windows 10.
Bug present in future MediaWiki alpha:
Not present in current alpha:
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Resolved | Release | zeljkofilipin | T220732 1.34.0-wmf.7 deployment blockers | ||
| Resolved | Fomafix | T224524 Various pages (Special:Contributions, Special:WhatLinksHere) shows autocomplete / search suggestions dropdown on page load |
Regression caused by rMW72f61f7a5930: jquery.suggestions: Trigger keypress on initializing.
Change 513064 had a related patch set uploaded (by Fomafix; owner: Fomafix):
[mediawiki/core@master] jquery.suggestions: Do not show suggestions on prefilled values
Change 513064 merged by jenkins-bot:
[mediawiki/core@master] jquery.suggestions: Do not show suggestions on prefilled values
Change 513237 had a related patch set uploaded (by Fomafix; owner: Fomafix):
[mediawiki/core@wmf/1.34.0-wmf.7] jquery.suggestions: Do not show suggestions on prefilled values
Yes, that’s the only patch that’s needed. Could you merge it before rolling out the train?
Change 513237 merged by jenkins-bot:
[mediawiki/core@wmf/1.34.0-wmf.7] jquery.suggestions: Do not show suggestions on prefilled values
Mentioned in SAL (#wikimedia-operations) [2019-05-30T13:22:00Z] <zfilipin@deploy1001> Synchronized php-1.34.0-wmf.7/resources/src/jquery/jquery.suggestions.js: SWAT: [[gerrit:513237|jquery.suggestions: Do not show suggestions on prefilled values ([T224524])]] (duration: 00m 58s)
@matmarex I've merged and deployed the patch. I will continue with the train. Please check if the problem is resolved, and if so, please resolve this task.
It still happens when i use the general search field, enter something, select one of the suggestions, goto the page, then select the browsers back button et voila the suggestion window opens again. Firefox 60.7.0esr (32-Bit)
I can confirm the problem and it happens since rMW72f61f7a5930: jquery.suggestions: Trigger keypress on initializing and rMWfd5733830383: jquery.suggestions: Do not show suggestions on prefilled values. But it happens only on the general search field on Special:Search, not with the same general search field on other pages and not on other input fields with suggestions. This is strange.
Another strange behaviour in https://de.wiktionary.org/wiki/Spezial:Suche is, that the cursor is blinking in the big input field in the middle, but input appears in the field on the upper right.
On https://de.wiktionary.org/wiki/Spezial:Suche the focus behavior is caused by the JavaScript in https://de.wiktionary.org/wiki/MediaWiki:Common.js.
The problem T224524#5228179 gets triggered by
OO.ui.infuse( $( '#searchText' ) )
I don't know what happens here.
The problem T224524#5228179 happens on all special pages using OOUI. This issue should tracked on a separate task.