Page MenuHomePhabricator
Create Task
Maniphest T223372

Constraint was removed from property but still displayed on Lexeme
Closed, ResolvedPublic
Actions

Description

The value requires statement constraint (Q21510864) on item for this sense was removed almost a month ago, but I still see a violation for it e. g. on L46038-S1. Purging the page didn't help.

Screenshot from 2019-05-15 12-51-12.png (357×802 px, 29 KB)

Bug reported on 15.5. by user:Galaktos on Contact the dev team page

Details

SubjectRepoBranchLines +/-
Track revision ID in constraints update jobmediawiki/extensions/WikibaseQualityConstraintsmaster+26 -4
Load property for update from master databasemediawiki/extensions/WikibaseQualityConstraintsmaster+26 -15
Customize query in gerrit

Related Objects

Event Timeline

Lea_Lacroix_WMDE created this task.May 15 2019, 10:52 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 15 2019, 10:52 AM
Lucas_Werkmeister_WMDE subscribed.May 15 2019, 12:45 PM

The constraint is still in the wbqc_constraints table (Quarry). My best guess is that, when the constraints table update job ran (triggered by the edit removing the constraint), it fetched the property from a replica that hadn’t seen the constraint removal yet. Let’s try making that fetch from the master instead.

gerritbot added a comment.May 15 2019, 12:48 PM

Change 510498 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/WikibaseQualityConstraints@master] Load property for update from master database

https://gerrit.wikimedia.org/r/510498

gerritbot added a project: Patch-For-Review.May 15 2019, 12:48 PM

Change 510499 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/WikibaseQualityConstraints@master] Track revision ID in constraints update job

https://gerrit.wikimedia.org/r/510499

Lydia_Pintscher added a project: Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)).Jun 11 2019, 9:51 AM
Lydia_Pintscher moved this task from To Do (prioritised from top to bottom) to Peer Review on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.
Michael subscribed.Jun 12 2019, 2:13 PM
Ladsgroup moved this task from Peer Review to Test (Verification) on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Jun 20 2019, 9:57 AM
gerritbot added a comment.Jun 20 2019, 10:20 AM

Change 510498 merged by jenkins-bot:
[mediawiki/extensions/WikibaseQualityConstraints@master] Load property for update from master database

https://gerrit.wikimedia.org/r/510498

ReleaseTaggerBot added a project: MW-1.34-notes (1.34.0-wmf.11; 2019-06-26).Jun 20 2019, 11:00 AM
Lucas_Werkmeister_WMDE added a comment.Jun 21 2019, 10:29 AM

Note: after the fix is deployed, we should also run extensions/WikibaseQualityConstraints/maintenance/ImportConstraintStatements.php to fix the constraints for all current properties without having to wait for the next constraint statements edit.

Addshore moved this task from incoming to in progress on the Wikidata board.Jun 21 2019, 11:25 PM
Lydia_Pintscher moved this task from Test (Verification) to To Do (prioritised from top to bottom) on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Jun 26 2019, 10:39 AM

Yeah let's run the script to get it completely fixed. We have too many properties to rely on all of them being edited.

Lucas_Werkmeister_WMDE claimed this task.Jun 26 2019, 1:15 PM
Lucas_Werkmeister_WMDE moved this task from To Do (prioritised from top to bottom) to Doing on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.
Stashbot added a comment.Jun 26 2019, 1:16 PM

Mentioned in SAL (#wikimedia-operations) [2019-06-26T13:16:04Z] <Lucas_WMDE> begin lucaswerkmeister-wmde@mwmaint1002:~$ mwscript extensions/WikibaseQualityConstraints/maintenance/ImportConstraintStatements.php wikidatawiki # T223372

Stashbot added a comment.Jun 26 2019, 1:17 PM

Mentioned in SAL (#wikimedia-operations) [2019-06-26T13:17:03Z] <Lucas_WMDE> end (success) lucaswerkmeister-wmde@mwmaint1002:~$ mwscript extensions/WikibaseQualityConstraints/maintenance/ImportConstraintStatements.php wikidatawiki # T223372

Lucas_Werkmeister_WMDE moved this task from Doing to Test (Verification) on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Jun 26 2019, 1:18 PM
Lucas_Werkmeister_WMDE mentioned this in T226635: Reduce potential load caused by ImportConstraintStatements.php maintenance script.Jun 26 2019, 1:37 PM
Lydia_Pintscher closed this task as Resolved.Jul 1 2019, 11:01 AM
Lydia_Pintscher moved this task from Test (Verification) to Done on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.
gerritbot added a comment.Jul 8 2019, 5:00 PM

Change 510499 merged by jenkins-bot:
[mediawiki/extensions/WikibaseQualityConstraints@master] Track revision ID in constraints update job

https://gerrit.wikimedia.org/r/510499

Maintenance_bot removed a project: Patch-For-Review.Jul 8 2019, 5:10 PM
ReleaseTaggerBot edited projects, added MW-1.34-notes (1.34.0-wmf.13; 2019-07-09); removed MW-1.34-notes (1.34.0-wmf.11; 2019-06-26).Jul 8 2019, 6:00 PM
Nikki mentioned this in T344249: [SW] Constraint violation checker for Lexemes.Aug 29 2023, 7:24 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits