Page MenuHomePhabricator
Create Task
Maniphest T218197

CacheAwarePropertyInfoStore & CachingPropertyInfoLookup should use WANObjectCache instead of BagOStuff
Closed, ResolvedPublic5 Estimated Story Points
Actions

Description

Per T97368#5018549

When writing a combination of delete and set should be used per T218197#5021050

Details

SubjectRepoBranchLines +/-
Use WanCache for PropertyInfoStore thingsmediawiki/extensions/Wikibasemaster+416 -322
Customize query in gerrit

Related Objects
Search...

Event Timeline

Addshore triaged this task as High priority.Mar 13 2019, 11:00 AM
Addshore created this task.
Restricted Application added a project: Wikidata. · View Herald TranscriptMar 13 2019, 11:00 AM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Addshore moved this task from Incoming to Ready to estimate on the Wikidata-Campsite board.Mar 13 2019, 11:00 AM
elukey added a subscriber: aaron.Mar 13 2019, 12:10 PM

Adding also @aaron that knows better what is best (and hopefully can confirm what I am saying).

aaron added a comment.Mar 13 2019, 2:53 PM

Yes, and CacheAwarePropertyInfoStore should use delete() or such for purges rather than set(). Using set() would only effect one DC.

Addshore updated the task description. (Show Details)Mar 14 2019, 10:44 AM
Addshore set the point value for this task to 5.Mar 19 2019, 3:41 PM
Addshore moved this task from Ready to estimate to Wikidata-Campsite-Iteration-∞ (On Hold) on the Wikidata-Campsite board.Mar 19 2019, 3:57 PM
Addshore edited projects, added Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)); removed Wikidata-Campsite.
Addshore claimed this task.Mar 22 2019, 9:59 AM
Addshore moved this task from To Do (prioritised from top to bottom) to Doing on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.
Restricted Application added a project: User-Addshore. · View Herald TranscriptMar 22 2019, 9:59 AM
elukey awarded a token.Mar 22 2019, 10:40 AM
Addshore moved this task from incoming to in progress on the Wikidata board.Mar 25 2019, 4:06 PM
gerritbot added a comment.Mar 25 2019, 8:06 PM

Change 498348 had a related patch set uploaded (by Addshore; owner: Addshore):
[mediawiki/extensions/Wikibase@master] WIP DNM WANCACHE for property info store?

https://gerrit.wikimedia.org/r/498348

gerritbot added a project: Patch-For-Review.Mar 25 2019, 8:06 PM
Addshore moved this task from Doing to Peer Review on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Mar 26 2019, 12:30 PM
gerritbot added a comment.Apr 2 2019, 4:50 PM

Change 498348 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Use WanCache for PropertyInfoStore things

https://gerrit.wikimedia.org/r/498348

ReleaseTaggerBot added a project: MW-1.33-notes (1.33.0-wmf.24; 2019-04-02).Apr 2 2019, 5:01 PM
• alaa_wmde moved this task from Peer Review to Test (Verification) on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Apr 4 2019, 12:31 AM
• alaa_wmde subscribed.Apr 4 2019, 12:41 AM

We should watch https://grafana.wikimedia.org/d/000000574/t204083-investigation and see some significant improvements .. if none, maybe this wasn't enough. I'm watching it for a week or two

Addshore added a comment.Apr 5 2019, 10:08 PM

It looks like the train didn't make it past group0 this week, so no change really spotted yet.

Addshore closed this task as Resolved.Apr 9 2019, 9:32 AM
Addshore mentioned this in T93142: [Task] Look into Wikibase use of memcached to see what needs broadcasted purges.May 13 2019, 7:59 PM
Addshore mentioned this in T254536: CacheAwarePropertyInfoStore performs 4000 Memc ops/s (APC not working?).Jun 5 2020, 11:45 AM
Maintenance_bot removed a project: Patch-For-Review.Jun 5 2020, 12:10 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits