Page MenuHomePhabricator
Create Task
Maniphest T197260

Create an API module to allow apps to set local exceptions
Closed, ResolvedPublic3 Estimated Story Points
Actions

Description

Discussion: T196314: UniversalLanguageSelector doesn't work if language is set globally in global preferences

Deliverables:

  • API module to allow apps to set local exceptions for preference values if global preference is set for a preference.

See also:

Details

SubjectRepoBranchLines +/-
Add an API module to change local preference overridesmediawiki/extensions/GlobalPreferencesmaster+115 -3
Add an API module to read global prefs/local overridesmediawiki/extensions/GlobalPreferencesmaster+285 -2
Customize query in gerrit

Related Objects
Search...

Event Timeline

Niharika created this task.Jun 14 2018, 6:49 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 14 2018, 6:49 PM
Niharika added a parent task: T16950: [Epic] Support global preferences on Wikimedia wikis.Jun 14 2018, 6:50 PM
Niharika mentioned this in T62856: Create an API module to allow apps to set global preference.Jun 14 2018, 7:49 PM
Niharika updated the task description. (Show Details)Jun 18 2018, 5:54 PM
Niharika added a subscriber: MaxSem.Jun 18 2018, 5:56 PM

@MaxSem If you are out of things to work on for this sprint, could you pick up this or one of the "See also" tasks? We can estimate them afterwards. Thanks.

Niharika set the point value for this task to 3.Jun 26 2018, 11:25 PM
Niharika moved this task from Needs Discussion to Up Next (June 3-21) on the Community-Tech board.
Niharika edited projects, added Community-Tech-Sprint; removed Community-Tech.Jun 26 2018, 11:44 PM
MaxSem claimed this task.Jun 28 2018, 8:56 PM
MaxSem moved this task from Ready to Needs Review/Feedback on the Community-Tech-Sprint board.
gerritbot subscribed.Jun 28 2018, 8:56 PM

Change 442983 had a related patch set uploaded (by MaxSem; owner: MaxSem):
[mediawiki/extensions/GlobalPreferences@master] Add an API module to read global prefs/local overrides

https://gerrit.wikimedia.org/r/442983

gerritbot added a project: Patch-For-Review.Jun 28 2018, 8:56 PM
• Vvjjkkii renamed this task from Create an API module to allow apps to set local exceptions to vzaaaaaaaa.Jul 1 2018, 1:03 AM
• Vvjjkkii removed MaxSem as the assignee of this task.
• Vvjjkkii triaged this task as High priority.
• Vvjjkkii added projects: CheckUser, Connected-Open-Heritage-Batch-uploads (RAÄ-KMB_1_2017-02), Tamil-Sites, Gamepress, Hashtags, Jade, KartoEditor, Language-2018-Apr-June, New-Editor-Experiences, Mail, TCB-Team (now WMDE-TechWish).
• Vvjjkkii updated the task description. (Show Details)
• Vvjjkkii removed the point value for this task.
• Vvjjkkii removed subscribers: gerritbot, Aklapper.
CommunityTechBot renamed this task from vzaaaaaaaa to Create an API module to allow apps to set local exceptions.Jul 2 2018, 6:38 AM
CommunityTechBot assigned this task to MaxSem.
CommunityTechBot raised the priority of this task from High to Needs Triage.
CommunityTechBot set the point value for this task to 3.
CommunityTechBot updated the task description. (Show Details)
CommunityTechBot removed projects: TCB-Team (now WMDE-TechWish), Mail, New-Editor-Experiences, Language-2018-Apr-June, KartoEditor, Jade, Hashtags, Gamepress, Tamil-Sites, Connected-Open-Heritage-Batch-uploads (RAÄ-KMB_1_2017-02), CheckUser.
CommunityTechBot added subscribers: gerritbot, Aklapper.
gerritbot added a comment.Jul 6 2018, 3:58 AM

Change 442983 merged by jenkins-bot:
[mediawiki/extensions/GlobalPreferences@master] Add an API module to read global prefs/local overrides

https://gerrit.wikimedia.org/r/442983

ReleaseTaggerBot added a project: MW-1.32-notes (WMF-deploy-2018-07-10 (1.32.0-wmf.12)).Jul 6 2018, 4:00 AM
Niharika added a comment.Jul 6 2018, 5:13 PM

@MaxSem To clarify, does the above patch also cover this ticket? The commit message is ambiguous.

MaxSem added a comment.Jul 6 2018, 5:56 PM

Err, no. That patch is coming shortly.

Niharika moved this task from Needs Review/Feedback to In Development on the Community-Tech-Sprint board.Jul 9 2018, 5:29 PM
Mooeypoo added a subtask: T198935: Clean up the mess with one-off transformations for some preferences.Jul 10 2018, 11:43 PM
gerritbot added a comment.Jul 13 2018, 10:45 PM

Change 445728 had a related patch set uploaded (by MaxSem; owner: MaxSem):
[mediawiki/extensions/GlobalPreferences@master] Add an API module to change local preference overrides

https://gerrit.wikimedia.org/r/445728

MaxSem moved this task from In Development to Needs Review/Feedback on the Community-Tech-Sprint board.Jul 13 2018, 10:45 PM
gerritbot added a comment.Jul 17 2018, 12:19 AM

Change 445728 merged by jenkins-bot:
[mediawiki/extensions/GlobalPreferences@master] Add an API module to change local preference overrides

https://gerrit.wikimedia.org/r/445728

ReleaseTaggerBot edited projects, added MW-1.32-notes (WMF-deploy-2018-07-17 (1.32.0-wmf.13)); removed MW-1.32-notes (WMF-deploy-2018-07-10 (1.32.0-wmf.12)).Jul 17 2018, 1:00 AM
MaxSem added a comment.Jul 21 2018, 1:28 AM

Sigh. For the reference, the output of

$array = [ 'foo' => null ];
var_dump( isset( $array['foo'] ) );

will be false, not true.

MaxSem closed this task as Resolved.Jul 23 2018, 8:51 PM
MaxSem moved this task from Needs Review/Feedback to Q1 2018-19 on the Community-Tech-Sprint board.
Niharika closed subtask T198935: Clean up the mess with one-off transformations for some preferences as Resolved.Jul 27 2018, 12:49 AM
Niharika added a project: Community-Tech.Jul 27 2018, 9:14 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits