global_preferences.gp_user should be unsigned
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Reedy
	Mar 1 2018, 7:33 PM

Description

Although globaluser.gu_id isn't unsigned (it probably should be changed to be so), we should make global_preferences.gp_user in preparation, so it doesn't need a schema change in future

See also T62962 and T89737 (where cores user_properties.up_user was made unsigned! But not deployed yet)

Also, why is it INT(11) not just int?

Ping T184666: DBA review for GlobalPreferences schema

Details

	Subject	Repo	Branch	Lines +/-
	Make gp_user the same type as user_id	mediawiki/extensions/GlobalPreferences	master	+6 -1

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
Resolved	Niharika	T139145 global disabling of compact language list
Resolved	None	T16950 [Epic] Support global preferences on Wikimedia wikis
Resolved	MaxSem	T188657 global_preferences.gp_user should be unsigned

Event Timeline

Reedy created this task.Mar 1 2018, 7:33 PM

Restricted Application added a project: Community-Tech. · View Herald TranscriptMar 1 2018, 7:33 PM

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Niharika added subscribers: Samwilson, MaxSem.Mar 1 2018, 7:34 PM

• TBolliger triaged this task as Medium priority.Mar 1 2018, 8:56 PM

• TBolliger moved this task from New & TBD Tickets to Needs Discussion on the Community-Tech board.

FWIW, it shouldn't take someone familiar with SQL and MW more than 10-15 minutes to fix this, and also include a migratory patch

Reedy mentioned this in T184666: DBA review for GlobalPreferences schema.Mar 1 2018, 11:33 PM

• TBolliger added a parent task: T16950: [Epic] Support global preferences on Wikimedia wikis.Mar 2 2018, 12:26 AM

MaxSem claimed this task.Mar 2 2018, 7:20 PM

Change 415924 had a related patch set uploaded (by MaxSem; owner: MaxSem):
[mediawiki/extensions/GlobalPreferences@master] Make gp_user the same type as user_id

https://gerrit.wikimedia.org/r/415924

gerritbot added a project: Patch-For-Review.Mar 2 2018, 8:00 PM

Change 415924 merged by jenkins-bot:
[mediawiki/extensions/GlobalPreferences@master] Make gp_user the same type as user_id

https://gerrit.wikimedia.org/r/415924

Reedy closed this task as Resolved.Mar 2 2018, 11:25 PM

Reedy removed a project: Patch-For-Review.