Page MenuHomePhabricator
Create Task
Maniphest T186855

Add support for log-thanks to the Thanks API
Closed, ResolvedPublic8 Estimated Story Points
Actions

Description

The Thanks API currently supports action=thanks with three keys: rev, source, and token. To these we should add log, which sends thanks for the specified log entry.

Details

SubjectRepoBranchLines +/-
Reintroduce the API to thank for log entriesmediawiki/extensions/Thanksmaster+307 -49
Add support to the Thanks API for thanking log entriesmediawiki/extensions/Thanksmaster+266 -47
Rename files and classes in preparation for adding log-thanksmediawiki/extensions/Thanksmaster+15 -14
Customize query in gerrit

Related Objects
Search...

Event Timeline

Samwilson created this task.Feb 9 2018, 6:46 AM
Restricted Application added a project: Collaboration-Team-Triage. · View Herald TranscriptFeb 9 2018, 6:46 AM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Samwilson added a project: Community-Tech-Sprint.Feb 9 2018, 6:46 AM
Samwilson added a parent task: T186763: Add thank link to the end of log entries which have associated revisions .Feb 9 2018, 6:52 AM
Samwilson mentioned this in T186763: Add thank link to the end of log entries which have associated revisions .
gerritbot subscribed.Feb 9 2018, 7:05 AM

Change 409227 had a related patch set uploaded (by Samwilson; owner: Samwilson):
[mediawiki/extensions/Thanks@master] Add support to the Thanks API for thanking log entries

https://gerrit.wikimedia.org/r/409227

gerritbot added a project: Patch-For-Review.Feb 9 2018, 7:05 AM
Niharika removed a parent task: T186763: Add thank link to the end of log entries which have associated revisions .Feb 9 2018, 8:04 PM
Niharika added a parent task: T60485: [Epic] Allow thanks of log entry.Feb 9 2018, 8:07 PM
MGChecker subscribed.Feb 10 2018, 12:22 AM
Samwilson claimed this task.Feb 12 2018, 7:54 AM
Samwilson moved this task from Ready to In Development on the Community-Tech-Sprint board.
Niharika set the point value for this task to 8.Feb 14 2018, 12:20 AM
• TBolliger mentioned this in T184309: Investigation: Thanks notification for log entry.Feb 20 2018, 10:29 PM
Niharika mentioned this in T60485: [Epic] Allow thanks of log entry.Feb 21 2018, 12:11 AM
gerritbot added a comment.Feb 21 2018, 4:49 AM

Change 413092 had a related patch set uploaded (by Samwilson; owner: Samwilson):
[mediawiki/extensions/Thanks@master] Rename files and classes in preparation for adding log-thanks

https://gerrit.wikimedia.org/r/413092

gerritbot added a comment.Feb 23 2018, 8:40 PM

Change 413092 merged by jenkins-bot:
[mediawiki/extensions/Thanks@master] Rename files and classes in preparation for adding log-thanks

https://gerrit.wikimedia.org/r/413092

ReleaseTaggerBot added a project: MW-1.31-release-notes (WMF-deploy-2018-02-27 (1.31.0-wmf.23)).Feb 23 2018, 9:00 PM
Samwilson moved this task from In Development to Needs Review/Feedback on the Community-Tech-Sprint board.Feb 27 2018, 1:45 AM

This patch is ready for review: https://gerrit.wikimedia.org/r/#/c/409227

Samwilson moved this task from Needs Review/Feedback to In Development on the Community-Tech-Sprint board.Mar 1 2018, 1:10 AM
Samwilson updated the task description. (Show Details)Mar 1 2018, 1:18 AM
Samwilson added a subscriber: MaxSem.

Thanks @MaxSem I've updated this task desc with what we talked about this morning.

Niharika subscribed.Mar 1 2018, 4:45 AM
In T186855#4012567, @Samwilson wrote:

Thanks @MaxSem I've updated this task desc with what we talked about this morning.

What was the reasoning behind not deprecating the existing param?

Samwilson added a comment.Mar 1 2018, 5:00 AM

Max can probably explain more fully, but generally I guess it's better to not change APIs unless really necessary. If we have a third type of core thank in the future we can make it generic then.

Samwilson moved this task from In Development to Needs Review/Feedback on the Community-Tech-Sprint board.Mar 1 2018, 5:15 AM

Max, is it looking now more like what you've got in mind?

gerritbot added a comment.Mar 2 2018, 6:14 AM

Change 409227 merged by jenkins-bot:
[mediawiki/extensions/Thanks@master] Add support to the Thanks API for thanking log entries

https://gerrit.wikimedia.org/r/409227

Niharika closed this task as Resolved.Mar 2 2018, 6:00 PM
Niharika moved this task from Needs Review/Feedback to Q1 2018-19 on the Community-Tech-Sprint board.

Awesomesauce!

MaxSem added a subtask: Restricted Task.Mar 2 2018, 11:01 PM
Niharika reopened this task as Open.Mar 3 2018, 1:33 AM
Niharika moved this task from Q1 2018-19 to In Development on the Community-Tech-Sprint board.

Been reverted due to T188791.

gerritbot added a comment.Mar 3 2018, 4:09 AM

Change 416207 had a related patch set uploaded (by MaxSem; owner: MaxSem):
[mediawiki/extensions/Thanks@master] WIP: Reintroduce API to thank for log entries

https://gerrit.wikimedia.org/r/416207

ReleaseTaggerBot edited projects, added MW-1.31-release-notes (WMF-deploy-2018-03-06 (1.31.0-wmf.24)); removed MW-1.31-release-notes (WMF-deploy-2018-02-27 (1.31.0-wmf.23)).Mar 6 2018, 12:01 PM
• jmatazzoni moved this task from Untriaged to External on the Collaboration-Team-Triage board.Mar 6 2018, 8:03 PM
MaxSem closed subtask Restricted Task as Resolved.Mar 6 2018, 11:31 PM
gerritbot added a comment.Mar 9 2018, 7:38 PM

Change 416207 merged by jenkins-bot:
[mediawiki/extensions/Thanks@master] Reintroduce the API to thank for log entries

https://gerrit.wikimedia.org/r/416207

Niharika closed this task as Resolved.Mar 9 2018, 7:46 PM
Niharika moved this task from In Development to Q1 2018-19 on the Community-Tech-Sprint board.
• TBolliger moved this task from Q1 2018-19 to Archive on the Community-Tech-Sprint board.Apr 11 2018, 11:57 PM
Niharika edited projects, added Community-Tech; removed Community-Tech-Sprint.Jun 26 2018, 11:54 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits