| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| HTMLCompletionProfileSettings: Use OOUI radios when in OOUI form | mediawiki/extensions/CirrusSearch | master | +42 -22 |
Details
Details
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Open | None | T49145 Formally deprecate jQuery UI after we've stopped using jQuery UI in extensions and core | |||
| Open | None | T100270 Replace use of jQuery UI and MW UI with OOUI across all Wikimedia-deployed extensions and core | |||
| Open | None | T100161 Convert all of MediaWiki core to OOUI PHP (tracking) | |||
| Resolved | matmarex | T101480 Remove 'wgUseMediaWikiUIEverywhere' and code forks, always using the off/false path | |||
| Invalid | None | T101471 Convert core forms that use MW UI with wgUseMediaWikiUIEverywhere false to OOUI FormSpecialPage or explicit OOUI PHP | |||
| Open | None | T107037 Convert all MW core special pages to OOUI | |||
| Open | None | T64559 Redesign Special:Preferences (tracking) | |||
| Resolved | Volker_E | T180538 Improve Special:Preferences UI/UX | |||
| Resolved | Volker_E | T117781 Convert Special:Preferences to OOUI | |||
| Resolved | matmarex | T180709 CirrusSearch "Completion suggester " feature inserts raw options into the Search preferences panel, so they look unlike all the others |
Event Timeline
Comment Actions
Other than "use the right controls" (i.e. the full-size radio controls), no. Fixing that could be a few minutes' work, though I've not yet tried it out.
However, this is the only bit of the preferences interface that over-rides behaviour like this (to insert two different headings for one set of radio controls), so it's a bit odd/disruptive from a design perspective. Might be worth re-considering longer-term.
Comment Actions
None of us really knew what we were doing when adding these preferences. I made a rough spec for what I wanted it to look like, and David implemented it. It looks okay and functions fine, but as James notes it's a mess under the hood, and inconsistent with other preferences. Sounds like a minimum viable product! I don't know whether I have the expertise to fix this myself.
Comment Actions
The Search Platform team does not have a front-end engineer to work on this right now unfortunately, moving to later.
Comment Actions
I'm going to change the radio buttons for our fancy big blue ones, I think that's all we need here.
Comment Actions
Change 392541 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[mediawiki/extensions/CirrusSearch@master] HTMLCompletionProfileSettings: Use OOUI radios when in OOUI form
Comment Actions
Change 392541 merged by jenkins-bot:
[mediawiki/extensions/CirrusSearch@master] HTMLCompletionProfileSettings: Use OOUI radios when in OOUI form