Page MenuHomePhabricator

Notification preferences are wrong
Closed, ResolvedPublic

Description

When it was decided that this will be opt-out for new users, I thought it would be ok to make it a default preference. However, since the preference key wasn't in the database until the deployment, all users have had the default since then.

The above means all users now get the notification. Now it's necessary to quickly replace the wrong hook and backport to wikis. Then everyone who haven't changed their preferences should have them fixed.

Event Timeline

Change 356374 had a related patch set uploaded (by Matěj Suchánek; owner: Matěj Suchánek):
[mediawiki/extensions/Wikibase@master] Fix default notification preference

https://gerrit.wikimedia.org/r/356374

Change 356629 had a related patch set uploaded (by Thiemo Mättig (WMDE); owner: Matěj Suchánek):
[mediawiki/extensions/Wikibase@wmf/1.30.0-wmf.1] Fix default notification preference

https://gerrit.wikimedia.org/r/356629

Change 356374 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Fix default notification preference

https://gerrit.wikimedia.org/r/356374

Change 356629 merged by Aude:
[mediawiki/extensions/Wikibase@wmf/1.30.0-wmf.1] Fix default notification preference

https://gerrit.wikimedia.org/r/356629

Change 356784 had a related patch set uploaded (by Aude; owner: Aude):
[mediawiki/extensions/Wikidata@wmf/1.30.0-wmf.1] Update Wikidata - Fix default echo notification preference

https://gerrit.wikimedia.org/r/356784

Ladsgroup moved this task from Review to Done on the Wikidata-Former-Sprint-Board board.

Change 356784 abandoned by Aude:
Update Wikidata - Fix default echo notification preference

Reason:
wmf4 is deployed now, which includes these changes

https://gerrit.wikimedia.org/r/356784