Fix bug with Froms' statements always switching to edit mode on page load
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	• Aleksey_WMDE
	May 16 2017, 11:03 AM

Description

Currently, when you open a Lexeme page, Form's statements rendered correctly, but switch to edit mode as soon as page is loaded.

They should stay in view mode unless user clicked an Edit button.

Details

Subject	Repo	Branch	Lines +/-
JS LexemeDeserializer also deserializes statements on forms	mediawiki/extensions/WikibaseLexeme	master	+107 -23
LexemeSerializer also serializes statements on forms	mediawiki/extensions/WikibaseLexeme	master	+35 -6
Lexeme can find statements on LexemeForms by GUID	mediawiki/extensions/WikibaseLexeme	master	+90 -40
Move example data from LexemeView to LexemeContent to make it "visible" to serializers	mediawiki/extensions/WikibaseLexeme	master	+55 -34
Optional statement data embedding	mediawiki/extensions/Wikibase	master	+164 -60

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
Open	None	T194253 Configure the CI job that runs WikibaseLexeme's browser tests against test wikidata
Resolved	Addshore	T168260 Deploy WikibaseLexeme extension on Wikimedia cluster
Resolved	Addshore	T191457 Deploy WikibaseLexeme on www.wikidata.org
Resolved	Addshore	T191458 Deploy WikibaseLexeme on test.wikidata.org
Resolved	Lydia_Pintscher	T168263 WikibaseLexeme functional baseline
Resolved	Lydia_Pintscher	T159703 [Tracking] Support for Forms and Senses
Resolved	Lydia_Pintscher	T150178 Wikidata 2017 Q2 goals
Resolved	Lydia_Pintscher	T169708 Wikidata 2017 Q3 goals
Resolved	Lydia_Pintscher	T160052 [Epic] Support for Forms
Resolved	daniel	T160521 [Epic] Forms of a Lexeme (UI)
Resolved	None	T160520 [Story] Section header for Forms
Resolved	thiemowmde	T161092 Create LexemeFormsView and use it in LexemeView
Resolved	None	T161093 Create browser tests for section header for forms
Resolved	• Jonas	T161201 Run browser tests in CI
Resolved	Lydia_Pintscher	T160522 [Story] List of Forms (UI)
Resolved	daniel	T164743 [Story] Add Form to list of Forms (UI)
Resolved	None	T160524 [Story] Add Form to list of Forms (non-persistent)
Resolved	thiemowmde	T161789 [Task] Introduce HTML templates infrastructure for Wikibase Lexeme
Resolved	Jakob_WMDE	T162254 [Task] Move existing HTML from views to templates.php
Resolved	Jakob_WMDE	T162338 Add browsertests for 'Add Form to list of Forms'
Resolved	WMDE-leszek	T162339 Create "formlist" widget for list of Forms
Resolved	WMDE-leszek	T162340 Implement Form widget
Resolved	WMDE-leszek	T162341 Create an "add" button to add a Form to a list of Forms and wire it to display "add Form"
Duplicate	None	T162342 Make the "add" button display the "add Form" form
Resolved	WMDE-leszek	T162343 Make the "save" button add the new form to the list widget
Resolved	Lydia_Pintscher	T173743 [Story] Representations of a Form
Resolved	None	T173744 persistently addable/editable/removable Representations of a Form via the UI (M)
Resolved	Lucas_Werkmeister_WMDE	T178389 Create API for updating Form descriptions
Resolved	Lydia_Pintscher	T160525 [Story] Grammatical Feature of a Form
Resolved	• Aleksey_WMDE	T162788 [Story] basic non-editable list of Grammatical Features of a Form
Resolved	WMDE-leszek	T162790 [Story] basic editable list of Grammatical Features of a Form
Resolved	• Jonas	T163971 Investigate what widget could be used to render the editable list of Grammatical Features of a Form
Resolved	• Jonas	T164361 Create MenuTagMultiselectWidget for Grammatical Feature List
Resolved	Jakob_WMDE	T163972 Create browser test for the editing the list of Grammatical Features of a Form feature
Resolved	• Jonas	T164471 Create jquery ui widget for Grammatical Feature List
Invalid	None	T162797 [Story] Grammatical Forms look like faked statements
Resolved	Lydia_Pintscher	T163785 [Story] UX design for a Form's list of grammatical features
Resolved	None	T173742 persistently editable Grammatical Feature of a Form via the UI (M)
Resolved	• Aleksey_WMDE	T176473 [Task] Split Lexeme serializer into ExternalSerializer and StorageSerializer
Resolved	WMDE-leszek	T184409 Create the API module allowing editing the representation, and the grammatical features of a Form (days: 4)
Resolved	Lydia_Pintscher	T184411 UI: Use the API to save edits of grammatical features of the form (days: 1)
Resolved	None	T184702 Set the edit summary when editing the representation and/or grammatical features of the form
Resolved	Lydia_Pintscher	T160526 [Story] List of Statements for a Form
Resolved	None	T164742 [Story] Add Form to list of Forms (persistent)
Resolved	Ladsgroup	T182424 Diffs for statements, grammatical features and representations of a form (M) (days: 9)
Resolved	Lydia_Pintscher	T165588 tasks for lexicographical data support until Wikimania 2017
Resolved	Lydia_Pintscher	T163723 [Story] non-persistently editable statements on a Form
Resolved	• Aleksey_WMDE	T165480 Fix bug with Froms' statements always switching to edit mode on page load
Resolved	Jakob_WMDE	T165575 [Story] Multi-variant Representations (UI)

Event Timeline

• Aleksey_WMDE created this task.May 16 2017, 11:03 AM

• Aleksey_WMDE updated the task description. (Show Details)May 16 2017, 11:08 AM

Change 353337 had a related patch set uploaded (by Aleksey Bekh-Ivanov (WMDE); owner: Aleksey Bekh-Ivanov (WMDE)):
[mediawiki/extensions/Wikibase@master] Optional statement data embedding

https://gerrit.wikimedia.org/r/353337

gerritbot added a project: Patch-For-Review.May 16 2017, 11:16 AM

• Aleksey_WMDE renamed this task from Bix bug with Froms' statements always switching to edit mode on page load to Fix bug with Froms' statements always switching to edit mode on page load.May 16 2017, 11:17 AM

Change 353337 abandoned by Aleksey Bekh-Ivanov (WMDE):
Optional statement data embedding

Reason:
Abandoned in favor of Iaf14bbb4df9ec0af0879aa206a28a77bb52db671

https://gerrit.wikimedia.org/r/353337

• Aleksey_WMDE moved this task from Proposed to Doing on the Wikidata-Former-Sprint-Board board.May 18 2017, 6:56 PM

Change 354239 had a related patch set uploaded (by Aleksey Bekh-Ivanov (WMDE); owner: Aleksey Bekh-Ivanov (WMDE)):
[mediawiki/extensions/WikibaseLexeme@master] Move example data from LexemeView to LexemeContent to make it "visible" to serializers

https://gerrit.wikimedia.org/r/354239

Change 354219 had a related patch set uploaded (by Aleksey Bekh-Ivanov (WMDE); owner: Aleksey Bekh-Ivanov (WMDE)):
[mediawiki/extensions/WikibaseLexeme@master] LexemeSerializer also serializes statements on forms

https://gerrit.wikimedia.org/r/354219

Change 354231 had a related patch set uploaded (by Aleksey Bekh-Ivanov (WMDE); owner: Aleksey Bekh-Ivanov (WMDE)):
[mediawiki/extensions/WikibaseLexeme@master] JS LexemeDeserializer also serializes statements on forms

https://gerrit.wikimedia.org/r/354231

• Aleksey_WMDE mentioned this in rEWLE0f2338995d2e: JS LexemeDeserializer also serializes statements on forms.May 18 2017, 6:58 PM

• Aleksey_WMDE mentioned this in rEWLEe4a1def21961: LexemeSerializer also serializes statements on forms.

• Aleksey_WMDE mentioned this in rEWLE3b6e76a481fa: Move example data from LexemeView to LexemeContent to make it "visible" to….

Change 354022 had a related patch set uploaded (by Aleksey Bekh-Ivanov (WMDE); owner: Aleksey Bekh-Ivanov (WMDE)):
[mediawiki/extensions/WikibaseLexeme@master] Lexeme can find statements on LexemeForms by GUID

https://gerrit.wikimedia.org/r/354022

• Aleksey_WMDE mentioned this in rEWLEf62d7e063129: Lexeme can find statements on LexemeForms by GUID.May 18 2017, 7:00 PM

• Aleksey_WMDE mentioned this in rEWLE47cd70e217af: Lexeme can find statements on LexemeForms by GUID.

• Aleksey_WMDE moved this task from Doing to Review on the Wikidata-Former-Sprint-Board board.May 18 2017, 7:02 PM

Change 354239 merged by jenkins-bot:
[mediawiki/extensions/WikibaseLexeme@master] Move example data from LexemeView to LexemeContent to make it "visible" to serializers

https://gerrit.wikimedia.org/r/354239

• Aleksey_WMDE mentioned this in rEWLE7e306fa9c9e7: LexemeSerializer also serializes statements on forms.May 21 2017, 10:41 AM

• Aleksey_WMDE mentioned this in rEWLEaaa16da11a45: JS LexemeDeserializer also serializes statements on forms.

• Aleksey_WMDE mentioned this in rEWLEcb1af3c7a9b5: LexemeSerializer also serializes statements on forms.May 21 2017, 10:45 AM

• Aleksey_WMDE mentioned this in rEWLE2b21ba08074f: LexemeSerializer also serializes statements on forms.May 21 2017, 10:57 AM

• Aleksey_WMDE mentioned this in rEWLE6bb5944bc53e: JS LexemeDeserializer also serializes statements on forms.May 21 2017, 11:08 AM

• Aleksey_WMDE mentioned this in rEWLE1323c542356f: Lexeme can find statements on LexemeForms by GUID.May 21 2017, 12:03 PM

• Aleksey_WMDE mentioned this in rEWLEd4bce1727914: Lexeme can find statements on LexemeForms by GUID.May 21 2017, 12:33 PM

WMDE-leszek mentioned this in rEWLEc29f833e6e82: LexemeSerializer also serializes statements on forms.May 23 2017, 11:12 AM

• Aleksey_WMDE mentioned this in rEWLE3212f4ec44f5: JS LexemeDeserializer also serializes statements on forms.May 23 2017, 5:04 PM

• Aleksey_WMDE mentioned this in rEWLEaf615fd0034a: JS LexemeDeserializer also serializes statements on forms.

• Aleksey_WMDE mentioned this in rEWLE2a5b4fef4b27: JS LexemeDeserializer also deserializes statements on forms.