Page MenuHomePhabricator
Create Task
Maniphest T160588

VisualDiffs: Show annotation creations and removals in the sidebar
Open, MediumPublic8 Estimated Story Points
Actions

Description

So that users can see where the link is going, annotations should optionally be able to output a string.

Details

SubjectRepoBranchLines +/-
Update VE core submodule to master (3fc99cc9c)mediawiki/extensions/VisualEditormaster+5 -1
Describe link addition/removalsVisualEditor/VisualEditormaster+37 -1
Describe text style annotation changes, instead of showing remove-insertVisualEditor/VisualEditormaster+92 -9
Update VE core submodule to master (f46b51b83)mediawiki/extensions/VisualEditormaster+1 -1
Add visual diff messages for changed dir: and style: attributesVisualEditor/VisualEditormaster+63 -2
Customize query in gerrit

Related Objects
Search...

Event Timeline

Jdforrester-WMF created this task.Mar 15 2017, 11:29 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 15 2017, 11:29 PM
Jdforrester-WMF added a parent task: T143350: Let users choose a visual or wikitext diff in the review-your-changes tab.Mar 15 2017, 11:42 PM
• Elitre subscribed.Apr 28 2017, 9:32 AM
Tchanders mentioned this in T178248: Move visual diff out of beta in visual and 2017 wikitext editors.Oct 15 2017, 11:43 AM
Jdforrester-WMF updated the task description. (Show Details)Mar 6 2018, 2:04 PM
Jdforrester-WMF changed the point value for this task from 1 to 8.
Jdforrester-WMF updated the task description. (Show Details)Mar 6 2018, 2:07 PM
gerritbot subscribed.Mar 6 2018, 2:20 PM

Change 416684 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[VisualEditor/VisualEditor@master] Add visual diff messages for changed dir: and style: attributes

https://gerrit.wikimedia.org/r/416684

gerritbot added a project: Patch-For-Review.Mar 6 2018, 2:20 PM
Jdforrester-WMF updated the task description. (Show Details)Mar 6 2018, 2:21 PM
Jdforrester-WMF added a project: VisualEditor-VisualDiffs.
Jdforrester-WMF removed a parent task: T143350: Let users choose a visual or wikitext diff in the review-your-changes tab.Mar 6 2018, 2:26 PM

This clearly didn't block T143350 as we released without it.

gerritbot added a comment.Mar 6 2018, 6:37 PM

Change 416684 merged by jenkins-bot:
[VisualEditor/VisualEditor@master] Add visual diff messages for changed dir: and style: attributes

https://gerrit.wikimedia.org/r/416684

Jdforrester-WMF removed a project: Patch-For-Review.Mar 6 2018, 8:54 PM
Jdforrester-WMF updated the task description. (Show Details)
gerritbot added a comment.Mar 7 2018, 9:00 PM

Change 417033 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (f46b51b83)

https://gerrit.wikimedia.org/r/417033

gerritbot added a project: Patch-For-Review.Mar 7 2018, 9:00 PM
gerritbot added a comment.Mar 7 2018, 11:26 PM

Change 417033 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (f46b51b83)

https://gerrit.wikimedia.org/r/417033

Jdforrester-WMF removed a project: Patch-For-Review.Mar 8 2018, 12:17 AM
gerritbot added a comment.Dec 18 2020, 7:46 PM

Change 650589 had a related patch set uploaded (by Esanders; owner: Esanders):
[VisualEditor/VisualEditor@master] Describe text style annotation changes, instead of showing remove-insert

https://gerrit.wikimedia.org/r/650589

gerritbot added a project: Patch-For-Review.Dec 18 2020, 7:46 PM
gerritbot added a comment.Dec 18 2020, 8:31 PM

Change 650589 merged by jenkins-bot:
[VisualEditor/VisualEditor@master] Describe text style annotation changes, instead of showing remove-insert

https://gerrit.wikimedia.org/r/650589

gerritbot added a comment.Dec 18 2020, 8:35 PM

Change 650597 had a related patch set uploaded (by Esanders; owner: Esanders):
[VisualEditor/VisualEditor@master] Describe link addition/removals

https://gerrit.wikimedia.org/r/650597

gerritbot added a comment.Dec 18 2020, 8:45 PM

Change 650597 merged by jenkins-bot:
[VisualEditor/VisualEditor@master] Describe link addition/removals

https://gerrit.wikimedia.org/r/650597

Esanders updated the task description. (Show Details)Dec 18 2020, 8:46 PM
Esanders added a subscriber: Tchanders.
gerritbot added a comment.Dec 18 2020, 8:49 PM

Change 650601 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (3fc99cc9c)

https://gerrit.wikimedia.org/r/650601

Esanders renamed this task from VisualDiffs: Show complex annotation creations and removals in the sidebar (link, language, span) to VisualDiffs: Show annotation creations and removals in the sidebar.Dec 18 2020, 9:20 PM
gerritbot added a comment.Dec 18 2020, 9:31 PM

Change 650601 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (3fc99cc9c)

https://gerrit.wikimedia.org/r/650601

ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.25; 2021-01-05).Dec 18 2020, 10:00 PM
Maintenance_bot removed a project: Patch-For-Review.Dec 18 2020, 10:10 PM
Esanders closed subtask T189006: Be able to describe annotation additions/removals, not just changes as Resolved.Dec 19 2020, 6:26 PM
• Elitre unsubscribed.Jan 25 2021, 11:31 AM
Esanders moved this task from Backlog to In progress on the VisualEditor-VisualDiffs board.Jan 19 2022, 1:17 PM
Esanders moved this task from In progress to Backlog on the VisualEditor-VisualDiffs board.Nov 5 2023, 1:37 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits