Order of operations has changed in AbuseFilters
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Nirmos
	Oct 19 2016, 6:57 PM

Description

See https://sv.wikipedia.org/w/index.php?diff=37667389 and https://sv.wikipedia.org/w/index.php?diff=37667490

This is not only on sv.wikipedia.org

See https://en.wikipedia.org/wiki/Wikipedia:Village_pump_(technical)#Edit_filter_gone_nuts

Details

	Subject	Repo	Branch	Lines +/-
	Revert "Enable AbuseFilterCachingParser by default"	operations/mediawiki-config	master	+5 -2

Customize query in gerrit

Related Objects

Mentioned In: T153217: Some abuse filters can be bypassed (never match any actions)
T149490: AbuseFilter Messages shown as html

Event Timeline

Nirmos created this task.Oct 19 2016, 6:57 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 19 2016, 6:57 PM

Nirmos triaged this task as Unbreak Now! priority.Oct 19 2016, 6:58 PM

Restricted Application added subscribers: Jay8g, Luke081515, TerraCodes. · View Herald TranscriptOct 19 2016, 6:58 PM

Tegel subscribed.Oct 19 2016, 7:19 PM

Technically speaking

cond | cond

now needs to be changed to

(cond | cond)

jhsoby subscribed.Oct 19 2016, 7:58 PM

Nirmos renamed this task from Edits trigger all AbuseFilters to Order of operations has changed in AbuseFilters.Oct 20 2016, 12:48 AM

cond | cond & cond

used to be interpreted as

( cond | cond ) & cond

but is now interpreted as

cond | ( cond & cond )

Change 316917 had a related patch set uploaded (by Legoktm):
Revert "Enable AbuseFilterCachingParser by default"

https://gerrit.wikimedia.org/r/316917

gerritbot added a project: Patch-For-Review.Oct 20 2016, 1:13 AM

Change 316917 merged by jenkins-bot:
Revert "Enable AbuseFilterCachingParser by default"

https://gerrit.wikimedia.org/r/316917

Mentioned in SAL (#wikimedia-operations) [2016-10-20T01:17:35Z] <legoktm@mira> Synchronized wmf-config/InitialiseSettings.php: Revert Enable AbuseFilterCachingParser by default - T148673 (duration: 00m 51s)

Should be reverted for now. CC: @ori and @vvv

Oh, leaving open as someone presumably needs to fix the new AbuseFilterCachingParser.

Legoktm lowered the priority of this task from Unbreak Now! to Medium.Oct 20 2016, 1:20 AM

The specific change which happened, as far as I understand it, is that the precedence remained the same, but apparently the new parser treats boolean operators as right-associative, whereas it used to treat them as left-associative. This is an oversight on my part. I will write a patch to fix that and add tests.

ori reassigned this task from Legoktm to vvv.Oct 20 2016, 8:15 PM

Johan added a project: User-notice.Oct 21 2016, 12:57 PM

Johan moved this task from To Triage to Announce in next Tech/News on the User-notice board.

Johan moved this task from Announce in next Tech/News to In current Tech/News draft on the User-notice board.Oct 21 2016, 6:03 PM

Liuxinyu970226 subscribed.Oct 22 2016, 12:11 AM

He7d3r subscribed.Oct 24 2016, 5:49 PM

Nemo_bis subscribed.Oct 24 2016, 5:53 PM

Trizek-WMF moved this task from In current Tech/News draft to Recently announced in Tech/News on the User-notice board.Oct 27 2016, 3:17 PM

tom29739 subscribed.Oct 28 2016, 7:23 PM

Jack_who_built_the_house mentioned this in T149490: AbuseFilter Messages shown as html.Oct 29 2016, 6:32 PM

@vvv, are you still planning on working on this?

RandomDSdevel awarded a token.Nov 10 2016, 12:48 AM