Extension loader ignores 'merge_strategy' key
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Yurik
	Oct 18 2016, 4:45 AM

Description

This code from SemanticForms is the only instance of the "manifest_version": 2 that I found that tries to use merge_strategy, and it clearly fails because of the wrong variable used in the code. Fix is coming in a sec, and it will let us properly fix ZeroBanner config loading.

"sfgDatePickerSettings": {
	"value": {
		"@note": "See SF_DefaultInputSettings.php for allowed values",
		"FirstDate": null,
		...
	},
	"merge_strategy": "array_plus"
}

Details

	Subject	Repo	Branch	Lines +/-
	registration: Fix ignoring 'merge_strategy' key in manifest_version 2	mediawiki/core	wmf/1.28.0-wmf.22	+1 -1
	registration: Fix ignoring 'merge_strategy' key in manifest_version 2	mediawiki/core	master	+1 -1

Customize query in gerrit

Related Objects
Search...

Status	Subtype	Assigned	Task
Resolved		thcipriani	T146998 MW-1.28.0-wmf.22 deployment blockers
Resolved	BUG REPORT	Yurik	T147971 [BUG] ZeroConfig broke parsing of configuration
Resolved		Yurik	T148493 Extension loader ignores 'merge_strategy' key

Event Timeline

Yurik created this task.Oct 18 2016, 4:45 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 18 2016, 4:45 AM

Change 316519 had a related patch set uploaded (by Yurik):
Fix extension loader ignoring 'merge_strategy' key

https://gerrit.wikimedia.org/r/316519

gerritbot added a project: Patch-For-Review.Oct 18 2016, 4:47 AM

Yurik mentioned this in T147971: [BUG] ZeroConfig broke parsing of configuration .Oct 18 2016, 4:51 AM

Yurik added a parent task: T147971: [BUG] ZeroConfig broke parsing of configuration .

Paladox subscribed.Oct 18 2016, 6:25 AM

Change 316519 merged by jenkins-bot:
registration: Fix ignoring 'merge_strategy' key in manifest_version 2

https://gerrit.wikimedia.org/r/316519

ReleaseTaggerBot added projects: MW-1.28-release (WMF-deploy-2016-10-25_(1.28.0-wmf.23)), MW-1.28-release-notes.Oct 18 2016, 7:00 AM

Florian closed this task as Resolved.Oct 18 2016, 7:09 AM

Change 316531 had a related patch set uploaded (by Paladox):
registration: Fix ignoring 'merge_strategy' key in manifest_version 2

https://gerrit.wikimedia.org/r/316531

Change 316531 abandoned by Paladox:
registration: Fix ignoring 'merge_strategy' key in manifest_version 2