⚓ T147239 Add visualhide css from common.css

	Subject	Repo	Branch	Lines +/-
	Add visualhide class from Common.css	mediawiki/extensions/MobileApp	master	+11 -0

		Status	Subtype	Assigned	Task
		Resolved		Dbrant	T146974 [BUG] Problem with displaying pages containing sfrac template
		Resolved		Mhurd	T147239 Add visualhide css from common.css

• JMinor created this task.Oct 3 2016, 11:23 PM

• JMinor moved this task from Tasks from Product Backlog to Needs Engineering Sync on the iOS-app-v5.3.0-Welsh-Dragon board.

• JMinor moved this task from Needs Triage to Bug Backlog on the Wikipedia-iOS-App-Backlog board.

• JMinor moved this task from Needs Engineering Sync to Ready for Development on the iOS-app-v5.3.0-Welsh-Dragon board.Oct 18 2016, 6:47 PM

In T146974#2730305, @RHo wrote:

Just did a quick check and pulling in the entire common.css on iOS messes up the layout of the article a bit (particularly display of the info box), so suggest that for iOS at least, we only pull in the .visualhide class into our existing styleoverrides.css file.

Quick screencast:
https://youtu.be/OO4rqDLdbmk

@RHo We have a process for pulling upstream css and iirc we don't pull wholesale as you tried. I can give it a go after I finish the welcome ticket...

No worries @Mhurd – I just had a quick go at just adding the visualhide class on this PR:
https://github.com/wikimedia/wikipedia-ios/pull/962

@RHo Unfortunately that PR won't work because of the way we build our css files. That's actually the output file built when we run Grunt to process our less/css. For the visual hide bits we'll most likely want to have that added upstream so we can run it through the existing process that brings in all our other upstream css.

I assume this can be added it in such a way that both apps can inherit the change :)

@Mhurd – derp yes I completely blanked on the processing, did it once before so can go through the process again tomorrow (unless you get to it first :p)

I assume this can be added it in such a way that both apps can inherit the change :)

@RHo per Dbrant's comment we'll probably want to check about adding it upstream before we do anything...

• Fjalapeno assigned this task to RHo.Oct 20 2016, 5:48 PM

• Fjalapeno moved this task from Ready for Development to Needs Code Review on the iOS-app-v5.3.0-Welsh-Dragon board.

hi @Mhurd – per our chat offline just PR updated with addition to the correct file (misc.less instead of styleoverrides.css) ready for grunting :)

https://github.com/wikimedia/wikipedia-ios/pull/962

@RHo I ran it and pushed. Should be able to pull and test now.

Diffusion mentioned this in rAPIOSa56039405f05: Merge branch 'develop' into visualhide-fraction-fix/T147239.Oct 20 2016, 7:39 PM

Diffusion mentioned this in rAPIOS489580f02c5d: Merge remote-tracking branch 'origin/visualhide-fraction-fix/T147239' into….Oct 20 2016, 8:11 PM

Diffusion mentioned this in rAPIOSca4a4972461d: Merge branch 'develop' into visualhide-fraction-fix/T147239.

Diffusion mentioned this in rAPIOS8f6c6e48f716: Merge branch 'develop' into visualhide-fraction-fix/T147239.Oct 20 2016, 8:15 PM

Diffusion mentioned this in rAPIOS72ade279650d: Revert "Merge branch 'develop' into visualhide-fraction-fix/T147239".

Diffusion mentioned this in rAPIOSe93c99dcb3fb: Merge branch 'develop' into visualhide-fraction-fix/T147239.Oct 20 2016, 8:35 PM

@RHo

Hey I met with @Dbrant and he or one of the android guys are going to add this upstream then I'll sync the iOS app's css again.

Change 317293 had a related patch set uploaded (by Dbrant):
Add visualhide class from Common.css

https://gerrit.wikimedia.org/r/317293

gerritbot added a project: Patch-For-Review.Oct 21 2016, 11:50 PM

Change 317293 merged by jenkins-bot:
Add visualhide class from Common.css

https://gerrit.wikimedia.org/r/317293

ReleaseTaggerBot added a project: MW-1.28-release (WMF-deploy-2016-10-25_(1.28.0-wmf.23)).Oct 22 2016, 1:00 AM

As soon as this gets deployed I'll re-sync iOS css...

@Dbrant hmm I tried re-syncing our CSS and I don't see the addition...

Hey @Mhurd, I think this'll roll out to enwiki (where it looks like you're pulling down from) during today's MediaWiki train deployment. Mind giving it another try after 2pm PDT?