Page MenuHomePhabricator
Create Task
Maniphest T146182

NWE should let you edit talk pages, templates, and JSON blobs, (but not let you switch)
Closed, ResolvedPublic8 Estimated Story Points
Actions

Description

The namespace and content model checks in init.isAvailable should only apply to VE, not NWE, and we should disable the switch button in such circumstances. Not sure how to factor out it from the rest neatly.

Details

SubjectRepoBranchLines +/-
Disable switch-to-VE button in NWE if VE is unavailable, don't hide itmediawiki/extensions/VisualEditormaster+10 -5
Allow NWE on non-VE namespacesmediawiki/extensions/VisualEditormaster+1 -1
NWE: Don't show button to switch to VE if it isn't availablemediawiki/extensions/VisualEditormaster+5 -1
Split isAvailable from visual-specific checksmediawiki/extensions/VisualEditormaster+36 -42
Customize query in gerrit

Related Objects
Search...

Event Timeline

Jdforrester-WMF created this task.Sep 20 2016, 6:27 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 20 2016, 6:27 PM
Jdforrester-WMF added a parent task: T141149: Provide a Beta Feature of a modern wikitext editor integrated into the visual editor.Sep 20 2016, 6:27 PM
Jdforrester-WMF moved this task from To Triage to TR1: Releases on the VisualEditor board.
Techbby renamed this task from NWE should let you edit talk pages, templates, and JSON blobs, (but not let you switch) to Outreachy proposal for project task.Sep 20 2016, 10:19 PM
Techbby claimed this task.
Techbby removed subscribers: Jdforrester-WMF, Aklapper.
• AlexMonk-WMF renamed this task from Outreachy proposal for project task to NWE should let you edit talk pages, templates, and JSON blobs, (but not let you switch).Sep 20 2016, 10:26 PM
• AlexMonk-WMF removed Techbby as the assignee of this task.
• AlexMonk-WMF added subscribers: Jdforrester-WMF, Aklapper, Techbby.
• JAufrecht mentioned this in T144516: Velocity tracking in Phlogiston for VE/NWE seems off?.Sep 20 2016, 10:29 PM
gerritbot subscribed.Sep 20 2016, 10:57 PM

Change 311860 had a related patch set uploaded (by Alex Monk):
Split isAvailable from visual-specific checks

https://gerrit.wikimedia.org/r/311860

gerritbot added a project: Patch-For-Review.Sep 20 2016, 10:57 PM
gerritbot added a comment.Sep 20 2016, 11:20 PM

Change 311860 merged by jenkins-bot:
Split isAvailable from visual-specific checks

https://gerrit.wikimedia.org/r/311860

ReleaseTaggerBot added a project: MW-1.28-release (WMF-deploy-2016-10-04_(1.28.0-wmf.21)).Sep 21 2016, 12:00 AM
Jdforrester-WMF added a comment.Sep 22 2016, 7:14 PM

This first half of this is done, but the switch button needs to be disabled where isAvailable is true but isVisualAvailable isn't.

Jdforrester-WMF removed a project: Patch-For-Review.Sep 22 2016, 7:14 PM
gerritbot added a comment.Sep 24 2016, 1:44 AM

Change 312618 had a related patch set uploaded (by Alex Monk):
NWE: Don't show button to switch to VE if it isn't available

https://gerrit.wikimedia.org/r/312618

gerritbot added a project: Patch-For-Review.Sep 24 2016, 1:44 AM
gerritbot added a comment.Sep 28 2016, 4:40 PM

Change 312618 merged by jenkins-bot:
NWE: Don't show button to switch to VE if it isn't available

https://gerrit.wikimedia.org/r/312618

Jdforrester-WMF removed a project: Patch-For-Review.Oct 3 2016, 8:07 PM
gerritbot added a comment.Oct 3 2016, 9:20 PM

Change 313908 had a related patch set uploaded (by Alex Monk):
Allow NWE on non-VE namespaces

https://gerrit.wikimedia.org/r/313908

gerritbot added a project: Patch-For-Review.Oct 3 2016, 9:20 PM
gerritbot added a comment.Oct 4 2016, 5:42 PM

Change 314040 had a related patch set uploaded (by Alex Monk):
Disable switch-to-VE button in NWE if VE is unavailable, don't hide it

https://gerrit.wikimedia.org/r/314040

gerritbot added a comment.Oct 5 2016, 6:22 PM

Change 313908 merged by jenkins-bot:
Allow NWE on non-VE namespaces

https://gerrit.wikimedia.org/r/313908

gerritbot added a comment.Oct 5 2016, 6:29 PM

Change 314040 merged by jenkins-bot:
Disable switch-to-VE button in NWE if VE is unavailable, don't hide it

https://gerrit.wikimedia.org/r/314040

Jdforrester-WMF closed this task as Resolved.Oct 5 2016, 6:33 PM
Jdforrester-WMF claimed this task.
Jdforrester-WMF removed a project: Patch-For-Review.
ReleaseTaggerBot added a project: MW-1.28-release (WMF-deploy-2016-10-11_(1.28.0-wmf.22)).Oct 5 2016, 7:00 PM
Jdforrester-WMF reassigned this task from Jdforrester-WMF to • AlexMonk-WMF.Oct 5 2016, 7:36 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits